[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Mention - Report mention #admins is not styled when editing comment in room chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when validating #41731
Version Number: 1.4.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to a room.
3. Send a message.
4. Right click on the message > Edit comment.
5. Type #admins.

Expected Result:

Report mention #admins will be styled because the chat is part of the workspace (not 1:1 DM).

Actual Result:

Report mention #admins is not styled when editing comment in room chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489346_1716465317917.20240523_195141.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[trjExpensify]

@puneetlath, can you help clarify what's a bug here:

1. The edit comment composer does not have auto-complete. Is that expected?
2. Clicking "Edit comment" on a room mention results in a blank composer. This is not expected? The value should be in the composer when you go to edit it
3. If the value is there and there's no auto-complete, when should it get "highlighted"? Is it when there's an exact match to a room name/person, or just as soon as you use the type a character after the # or @ operator?

[carlosmiceli]

Yes, I'm also not sure I understand what the bug is in the video? Also, doesn't feel like an hourly/urgent issue, right?

[rlinoz]

Editing mentions is not supported yet, it is being worked on here #39550

[carlosmiceli]

Gotcha @rlinoz , what would be the proper update of labels in this case?

[puneetlath]

The edit comment composer does not have auto-complete. Is that expected?

Yes, this is currently expected until we support inline auto-suggestion: #16078

I think we should just close this issue for now.

[lanitochka17]

Issue is still reproducible on the latest build 1.4.84-0

Bug6514097_1718444974287.Web-40565.mp4

[carlosmiceli]

Being investigated.

[war-in]

@eh2077 Yes! I'll post an update here when I find something

[war-in]

Hmm, I'm not sure if you're aware of it but on the current main all mentions are displayed as IDs 🥶

I found the root cause of this issue. MentionReportRendered can't get the correct report (and its' name).

The fix will be quick. Should I do it as a part of this issue or maybe we want to fix it ASAP?
cc @carlosmiceli

Edit: I've posted a comment in the related issue

[war-in]

I think I found the issue 🎉

Composer now has the isGroupPolicyReport prop (set by default to false) which defines if the room mentions are on or off (e.g. we don't want to mention rooms in DMs).

I'll prepare the fix :)

[war-in]

FYI, PR is ready and waiting for the review!

[eh2077]

Reviewing PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix room mentions in editing comments #44160

If no regressions arise, payment will be issued on 2024-07-02. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@carlosmiceli] The PR that introduced the bug has been identified. Link to the PR: [Mentions v2] Support mentions in editing comments #40565
• [@carlosmiceli] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Mentions v2] Support mentions in editing comments #40565 (comment)
• [@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1718053423534159
• [@carlosmiceli] Determine if we should create a regression test for this bug.
• [@carlosmiceli] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

Assigning @eh2077, as Eric is due payment for the C+ review. The Applause team flagged this regression through existing testing, so not adding a new one.

No payment due here, as it was a regression from #44160 caught during the regression period. Closing!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix room mentions in editing comments #44160

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @eh2077 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eh2077] Determine if we should create a regression test for this bug.
• [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: