[HOLD #50349] Chat - Opened offline image preview switches to previously uploaded image online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #49832

Action Performed:

1. Open a chat
2. Go offline
3. Upload an image
4. Open the image
5. Go online
6. Verify that image preview modal not dismissed

Expected Result:

Image preview modal is not dismissed after going online, preview of the uploaded offline image is opened

Actual Result:

Opened preview of the uploaded offline image switches to the preview of previously uploaded image after going online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6625168_1728103368755.Preview.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

Production:

Preview.on.prod.MP4

[thienlnam]

This was the note on the linked PR

There is a known issue in the native platform where the attachment index incorrectly switches even after setting it correctly #49832 (comment). This is a known upstream issue that should be addressed separately #49832 (comment).

[thienlnam]

cc @s77rt @wildan-m @rlinoz If I'm reading that comment correctly - are we saying that this current bug was broken elsewhere and needs to fixed upstream? Because this is not reproducible on production so it seems like somewhere along the line it was changed

[AndrewGable]

Thanks for noticing that @thienlnam - Do we have a follow up issue we can link here or can we just use this as the issue?

[rlinoz]

Yeah, it is not reproducible in prod right now because when going online again in prod the modal is dismissed (that is what the PR is fixing)

This are the related upstream issues we found:
callstack/react-native-pager-view#791
callstack/react-native-pager-view#597

I don't think we have an issue to track that on our side yet

[s77rt]

@thienlnam In production I believe the behaviour was that after you get online the modal will be dismissed which is already considered a bug. Now the modal is not dismissed but the attachment changes. Since this was not working at all it is not a regression. The new bug on native is upstream and we should fix it as well however this does not need to be a deploy blocker.

[thienlnam]

Ahh okay I see, thanks for the clarification - yeah let's create an issue to track that on our side and then we can solve it seperately

[thienlnam]

Created the issue here: #50349

[AndrewGable]

Do we need to keep this one open @thienlnam ?

[thienlnam]

I imagine this one might get re-reported so was thinking it could be good to leave it open and on hold for the other issue - but feel free to close if you want

[mallenexpensify]

We're holding on creating a regression test to this linked issue, so we'll likely want one here.

[AndrewGable]

I'm a bit confused on the next steps here, seems like we are waiting on making a regression test, but we are waiting on this issue to create the regression test?

[s77rt]

@AndrewGable Making a regression test now won't make much sense because there is still an ongoing bug and the QA team won't be able to complete the test. Once #50349 is fixed we can proceed

[AndrewGable]

Still on hold

[AndrewGable]

Seems like the issue on hold is getting close

[AndrewGable]

Deployed to staging, let's wait a little bit longer

[AndrewGable]

@s77rt @thienlnam - What's next steps here?

[s77rt]

@AndrewGable Let's add the following regression test and close the issue:

1. Open any chat
2. Go offline
3. Upload an image
4. Open the image
5. Go online
6. Verify the image is still displayed and that the modal is not dismissed

[mallenexpensify]

Thanks @s77rt test case created, gonna close

• https://github.com/Expensify/Expensify/issues/451331