[HOLD for payment 2024-11-22] [$250] Fix upstream [react-native-pager-view] - PagerView displays incorrect pages when content changes dynamically without re-mounting

[thienlnam]

Potentially linked upstream issues:
callstack/react-native-pager-view#597
callstack/react-native-pager-view#791

Reproduction steps from @wildan-m:
#49832 (comment)

Associated bugs in Expensify:
#50296

Issue Owner

Current Issue Owner: @strepanier03

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846637497650257060
• Upwork Job ID: 1846637497650257060
• Last Price Increase: 2024-10-16

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thienlnam]

Will reach out in the callstack room first to see if anyone wants to pick it up

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[thienlnam]

@MrRefactor will look into this when he's back next week!

[MrRefactor]

Hey, its Kuba from Callstack, and I would love to take that issue.

[strepanier03]

I am going to apply the external label to get a C+ assigned to this for review.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021846637497650257060

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[MrRefactor]

Hey hey, still working on resolving the issue upstream, will give more detailed update once I will have it working

[hungvu193]

Not overdue.

[MrRefactor]

Hey, tomorrow I will create PR for react-native-pager-view and create a new release, I will also open pr for bumping version here.

[hungvu193]

Not overude

[MrRefactor]

Hey, I have just released react-native-pager-view version 6.5.0 with a fix for adding/changing pages dynamically. I will create a PR with a bump of the version.

[melvin-bot]

@strepanier03, @hungvu193, @thienlnam, @MrRefactor Still overdue 6 days?! Let's take care of this!

[hungvu193]

@thienlnam #52166 is ready for your final review!

[thienlnam]

Changes look good, but we'll need to apply the patch changes to Mobile-Expensify as well

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgrade react-native-pager-view to 6.5.0 #52166

If no regressions arise, payment will be issued on 2024-11-22. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @MrRefactor does not require payment (Contractor)

[melvin-bot]

@hungvu193 @strepanier03 @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[hungvu193]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: This issue was found in a PR while we tried to resolve another isssue.

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: No offending PR, this issue was found by a contributor while they were working on another issue.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not a critical one, user can still use the App, we don't need to create slack convo.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open a chat.
2. Go offline.
3. Upload an image.
4. Open the image.
5. Go online.
6. Verify that the image preview modal is not dismissed.

Do we 👍 or 👎 ?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot
• Contributor: @MrRefactor is from an agency-contributor and not due payment

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1846637497650257060/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@strepanier03, @hungvu193, @thienlnam, @MrRefactor Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

https://github.com/Expensify/Expensify/issues/447711

[strepanier03]

@hungvu193 - Feel free to request payment in ND, summary is here. Per the payment SO I'm going to close this now since it doesn't need to stay open for ND payments.

[garrettmknight]

$250 approved for @hungvu193