[HOLD for payment 2024-11-26] [$250] Distance - After tapping split expense with amount button, briefly "split expense" button shown

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open a room chat with few members invited
3. Tap plus icon left to chat input
4. Tap split expense - distance
5. Enter start and stop points
6. Tap next
7. Note tap split expense with amount button displayed
8. Tap on it

Expected Result:

After tapping split expense with amount button, briefly "split expense" button must not be shown before showing conversation page.

Actual Result:

After tapping split expense with amount button, briefly "split expense" button is shown before showing conversation page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6657658_1730988489659.Screenrecorder-2024-11-07-19-29-40-188.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021855539288770032834
• Upwork Job ID: 1855539288770032834
• Last Price Increase: 2024-11-10
• Automatic offers:
• FitseTLT | Contributor | 104839763

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-11-07 16:12:46 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - After tapping split expense with amount button, briefly "split expense" button shown

What is the root cause of that problem?

We reset the draft transaction on creating the expense and we show the split expense button if the iouAmount is 0

App/src/components/MoneyRequestConfirmationList.tsx

Lines 414 to 415 in 8a83e2b

	} else if (isTypeSplit && iouAmount === 0) {
	text = translate('iou.splitExpense');

so as the draft transaction amount is not available (0) it will show 'split expense'

What changes do you think we should make in order to solve the problem?

We can remove the draft transaction clearing code every where we are clearing it now like here

App/src/libs/actions/IOU.ts

Lines 4134 to 4136 in 8a83e2b

	key: `${ONYXKEYS.COLLECTION.TRANSACTION}${splitTransaction.transactionID}`,
	value: splitTransaction,
	},

here here here
Because we are already clearing the draft transaction in startMoneyRequest

App/src/libs/actions/IOU.ts

Lines 392 to 393 in 8a83e2b

	function startMoneyRequest(iouType: ValueOf<typeof CONST.IOU.TYPE>, reportID: string, requestType?: IOURequestType, skipConfirmation = false) {
	clearMoneyRequest(CONST.IOU.OPTIMISTIC_TRANSACTION_ID, skipConfirmation);

We can apply the change for our split case related to the current issue but I think it is better to apply it globally.

What alternative solutions did you explore? (Optional)

Alternatively we can use TransactionEdit.removeDraftTransaction with runAfterInteraction here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 377 in 8a83e2b

formHasBeenSubmitted.current = true;

            InteractionManager.runAfterInteractions(() => removeDraftTransaction(CONST.IOU.OPTIMISTIC_TRANSACTION_ID));

If we feel unsafe clearing the draft transaction before the create request actions have been called ( as we need the draft transaction value inside the functions) we can call it after the createTransaction function calls

[jliexpensify]

@FitseTLT @IuliiaHerets a few questions:

Version Number: 5.0.49-0

Do you mean 59-0 @IuliiaHerets?

Open a room chat with few members invited

Does this mean more than 1 other person? Is there a minimum number?

[IuliiaHerets]

@jliexpensify Yes, you are right, build - v9.0.59-0.
The number of members is not important, the main thing is that it is possible to create a split request.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021855539288770032834

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[jliexpensify]

Thanks for cionfirming - adding External as I could repro the other day.

[s77rt]

@FitseTLT Thanks for the proposal. The RCA and the solution look good to me.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.63-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Distance - After tapping split expense with amount button, briefly "split expense" button shown #52428

If no regressions arise, payment will be issued on 2024-11-26. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

@s77rt @jliexpensify @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[s77rt]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: fix: Split Bill - Group members disappeared in a split bill when make second split bill in a row #37048 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: n/a

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[jliexpensify]

@s77rt no regression test right?

[s77rt]

@jliexpensify Right, I don't feel that this flow requires a regression test

[jliexpensify]

Payment Summary

• C: @FitseTLT $250 (to be paid via Upworks)
• C+: @s77rt $250 (to be paid via N.D requests)

Upwork job

[jliexpensify]

Paid and job closed. @s77rt please request via ND.

[JmillsExpensify]

$250 approved for @s77rt