-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated logic to handle unread messages case #25935
Merged
MonilBhavsar
merged 43 commits into
Expensify:main
from
gedu:edu/23171_manually_unread_marking
Nov 16, 2023
Merged
Changes from 5 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
fab7506
Updated logic to handle the shouldDisplayNewMarker
gedu 47dd5cd
Sending an event when the user mark as unread a message
gedu 922fbf3
lint fixes
gedu 85dddae
Merge branch 'main' into edu/23171_manually_unread_marking
gedu b9f1f17
Merge branch 'main' into edu/23171_manually_unread_marking
gedu ec2e0fb
Merge branch 'main' into edu/23171_manually_unread_marking
gedu 3646848
Listening to the specific reports and clearing unread marker cache
gedu c71ecae
disable dependency hook, no need to listen to the messageManuallyMarked
gedu ebdeddb
Merge branch 'main' into edu/23171_manually_unread_marking
gedu de5b8fe
removed console logs
gedu c483c10
Merge branch 'main' into edu/23171_manually_unread_marking
gedu 8925515
fixed lint issues
gedu 7149558
Moved the DeviceEventEmitter into the markCommentAsUnread function
gedu 89d15d2
Merge branch 'main' into edu/23171_manually_unread_marking
gedu 748c8ad
Merge branch 'main' into edu/23171_manually_unread_marking
gedu a434c3a
Merge branch 'main' into edu/23171_manually_unread_marking
gedu f40773b
Updated scrolling direction and amount
gedu c784057
Fix to add report into map
gedu 51f8117
Merge branch 'main' into edu/23171_manually_unread_marking
gedu eee1e83
Fixed green line placement
gedu f1de924
fixed lint errors
gedu c8d4853
fixed lint issue
gedu c9722d9
Fixed test
gedu 8782bf7
fixed lint error
gedu d3ddefd
Merge branch 'main' into edu/23171_manually_unread_marking
gedu cea0759
Merge branch 'main' into edu/23171_manually_unread_marking
gedu 3ff86e2
Merge branch 'main' into edu/23171_manually_unread_marking
gedu 3630dac
Merge branch 'main' into edu/23171_manually_unread_marking
gedu 57978b6
updated dependency array
gedu 6546ba5
Prettier fixes
gedu 6b2beed
Merge branch 'main' into edu/23171_manually_unread_marking
gedu dc93b9e
Merge branch 'main' into edu/23171_manually_unread_marking
gedu 95cc451
Merge branch 'main' into edu/23171_manually_unread_marking
gedu cdb1b80
reverting changes
gedu 5dde6f2
Fixed comments
gedu 2b83ba6
fixed more comments
gedu c4541fb
improved the comments
gedu 58e2f9c
added new line after pods
gedu 12a92a7
explaining why we cache
gedu 823f3b7
Update src/pages/home/report/ReportActionsList.js
gedu d1a347c
Merged main into edu/23171_manually_unread_marking
gedu 0a578dd
Moved out the the prevReportID
gedu 8bb02a4
commenting the new variable
gedu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is weird. I'm not sure if we're returning unrelated parameters from an action elsewhere. A better way would be to just use onyx to get
lastReadTime
from the report.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was for emitting the even, but I will move the emitting into the function, so it won't need to return it