[CP Staging] Make sure that split bills follow the correct routes for editing category/tag #32541

yuwenmemon · 2023-12-06T03:28:09Z

Puller bearing (@rushatgabhane)
cc @srikarparsi @youssef-lr @rezkiy37 @cubuspl42 @puneetlath

Details

Fixes what I believe is an oversight from #31647. The SplitBill flow uses a different route than IOUs for editing transactions. So use the proper route and add analogous handlers to the EditSplitBillPage for editing a split bill.

Fixed Issues

$ #32517

Tests

Go to workspace chat of a workspace that has Category and tag
Click + > Spit money > Scan
Upload a receipt and create a Scan request
Click on the split preview
Click Category and select a category
Click Tag and select a tag
Make sure that each time, the selected tag/category shows up on the Split Bill view

Verify that no errors appear in the JS console

Kapture.2023-12-05.at.19.22.44.mp4

Offline tests

Perform the same steps above, offline.

QA Steps

Perform the steps in the two sections above

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Kapture.2023-12-06.at.10.04.39.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Kapture.2023-12-05.at.19.22.44.mp4

MacOS: Desktop

…gory/tag

melvin-bot · 2023-12-06T03:28:14Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

yuwenmemon · 2023-12-06T03:28:51Z

src/pages/EditSplitBillPage.js

            key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${route.params.reportID}`,
            canEvict: false,
        },
+        report: {
+            key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT}${route.params.reportID}`,
+        }
    }),
    // eslint-disable-next-line rulesdir/no-multiple-onyx-in-file
    withOnyx({


Why do we have two calls to withOnyx here?

puneetlath · 2023-12-06T18:08:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2023-12-06T18:17:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] Make sure that split bills follow the correct routes for editing category/tag (cherry picked from commit e349d69)

OSBotify · 2023-12-06T20:32:57Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:42:29Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

cubuspl42 · 2023-12-07T10:45:27Z

Thanks!

eVoloshchak · 2024-03-29T18:21:23Z

src/pages/EditSplitBillPage.js

+                defaultCategory={transactionCategory}
+                policyID={lodashGet(report, 'policyID', '')}
+                onSubmit={(transactionChanges) => {
+                    setDraftSplitTransaction({category: transactionChanges.category.trim()});


Coming from #37146, this has caused a bug where you can't un-select a category when editing split bill

Make sure that split bills follow the correct routes for editing cate…

455a2bc

…gory/tag

yuwenmemon self-assigned this Dec 6, 2023

yuwenmemon requested a review from a team as a code owner December 6, 2023 03:28

melvin-bot bot requested review from rushatgabhane and removed request for a team December 6, 2023 03:28

yuwenmemon commented Dec 6, 2023

View reviewed changes

ESLint

ddbe1f5

yuwenmemon changed the title ~~Make sure that split bills follow the correct routes for editing category/tag~~ [CP Staging] Make sure that split bills follow the correct routes for editing category/tag Dec 6, 2023

Prettier

ed724d1

yuwenmemon mentioned this pull request Dec 6, 2023

[Wave 6: Tags] Support Tag in Bill Split #31631

Closed

puneetlath approved these changes Dec 6, 2023

View reviewed changes

puneetlath merged commit e349d69 into main Dec 6, 2023
19 checks passed

puneetlath deleted the yuwen-editSplitBillCategory branch December 6, 2023 18:13

OSBotify pushed a commit that referenced this pull request Dec 6, 2023

Merge pull request #32541 from Expensify/yuwen-editSplitBillCategory

ddda85c

[CP Staging] Make sure that split bills follow the correct routes for editing category/tag (cherry picked from commit e349d69)

github-actions bot mentioned this pull request Dec 6, 2023

Deploy Checklist: New Expensify 2023-12-05 #32463

Closed

66 tasks

melvin-bot bot mentioned this pull request Dec 8, 2023

[HOLD for payment 2023-12-15] Scan - Selected category and tag do not show up in the row in Split action menu #32517

Closed

6 tasks

eVoloshchak reviewed Mar 29, 2024

View reviewed changes

eVoloshchak mentioned this pull request Mar 29, 2024

[HOLD for payment 2024-03-25] [$500] Can't unselect category when editing a split bill #37146

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Make sure that split bills follow the correct routes for editing category/tag #32541

[CP Staging] Make sure that split bills follow the correct routes for editing category/tag #32541

yuwenmemon commented Dec 6, 2023 •

edited

Loading

melvin-bot bot commented Dec 6, 2023

yuwenmemon Dec 6, 2023

puneetlath commented Dec 6, 2023 •

edited

Loading

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

cubuspl42 commented Dec 7, 2023

eVoloshchak Mar 29, 2024

[CP Staging] Make sure that split bills follow the correct routes for editing category/tag #32541

[CP Staging] Make sure that split bills follow the correct routes for editing category/tag #32541

Conversation

yuwenmemon commented Dec 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 6, 2023

yuwenmemon Dec 6, 2023

Choose a reason for hiding this comment

puneetlath commented Dec 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

cubuspl42 commented Dec 7, 2023

eVoloshchak Mar 29, 2024

Choose a reason for hiding this comment

yuwenmemon commented Dec 6, 2023 •

edited

Loading

puneetlath commented Dec 6, 2023 •

edited

Loading