-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mandatory exit survey for users going back to OldDot #34925
Merged
Merged
Changes from 38 commits
Commits
Show all changes
97 commits
Select commit
Hold shift + click to select a range
8f4e247
Remove unnecessary directory
roryabraham d9d97ca
Set up pages and navigation
roryabraham 835c2da
Build basic layout for reason page
roryabraham e77baf7
Add translations for copy
roryabraham a566335
Add constants for reasons
roryabraham d043c79
Use correct reasons from CONST in reasons page
roryabraham f5e2ded
Fix radio button styles
roryabraham 1f1b22f
Implement validation in reason page
roryabraham 6ccfdd8
Simplify routes
roryabraham 344bd5e
Fix skeletons of response and confirm page
roryabraham 138e14c
Localize page headers
roryabraham 19991af
Translate title and subtitle on reason page
roryabraham d764869
Implement basic layout of ResponsePage
roryabraham 8ccecea
Style response input better
roryabraham 1063d50
Get multiline styles implemented correctly
roryabraham 5f226ab
Merge branch 'main' into Rory-TransitionSurvey
roryabraham 0f1fc68
Compute maxHeight for TextInput in component
roryabraham 14351a7
Polish response input height
roryabraham 142b59c
Merge branch 'main' into Rory-TransitionSurvey
roryabraham af1110f
Make response required
roryabraham 21d0449
Add mushroom-top-hat illustration asset
roryabraham 93c5a87
Implement confirm page
roryabraham 3035ce0
Add Onyx types for forms
roryabraham b83bdef
Fix route type
roryabraham 733dd6a
Add obligatory draft keys for forms
roryabraham ca73fcf
Make spanish copy informal
roryabraham 899d16c
Merge branch 'main' into Rory-TransitionSurvey
roryabraham 99b7809
Hook up with API
roryabraham fa6fa15
Merge branch 'main' into Rory-TransitionSurvey
roryabraham fa47d7f
whoops, forgot to commit this file
roryabraham fb01ab5
Fix types for API params
roryabraham 6f7026f
Fix regression: https://github.com/Expensify/App/pull/34787\#issuecom…
roryabraham bf336ce
Bump type-fest
roryabraham d85a2fe
Wrap RadioButtons with forwardRef
roryabraham e1e5283
Add ExitSurveyForm onyx types
roryabraham b5cfed1
Add Onyx type in Form.ts as well
roryabraham b66d8d3
Merge branch main into Rory-TransitionSurvey
roryabraham 86bf87f
Fix typecheck
roryabraham 688a49b
Remove TODOs
roryabraham 2b2a148
Fix forwardRef
roryabraham 8c909c1
Clear onyx form data after sending to API
roryabraham 639afcd
Attempt to apply drafts - seeing cryptic type error
roryabraham 1ee4118
Populate response TextInput with draft response
roryabraham 41457dc
Use Onyx.set instead of Onyx.merge
roryabraham f738173
Remove errant console.log
roryabraham 0faf0c5
Implement loading state in confirm page
roryabraham 645c0d0
Merge branch 'main' into Rory-TransitionSurvey
roryabraham ef706f9
Fix linking config
roryabraham 8fab4f9
Consolidate goToExpensifyClassic copy
roryabraham 222cfb6
Upgrade react-native-onyx
roryabraham 25d1268
Merge branch 'main' into Rory-TransitionSurvey
roryabraham 33d614d
Hide reason page back button on wide layouts
roryabraham db6b991
Remove unnecessary ref
roryabraham 3bff7db
Submit response form on CMD+Enter
roryabraham a7f4a2f
Fix form second submission
roryabraham a61b8d5
Make isOffline a true boolean
roryabraham 566000b
Implement offline UI for reason page
roryabraham b3245a3
Implement offline UI for the other pages in the survey as well
roryabraham 220a974
Disable button in confirm page when offline
roryabraham aed59f1
Move survey back to RHP
roryabraham 4222758
Fix typo
roryabraham edbf8a4
Fix navigation to RHP
roryabraham 7c5e331
Remove unnecessary offline navigation effect
roryabraham 1893e7a
Add backTo param to response and confirm page, even though it doesn't…
roryabraham ecfc373
Add missing spanish translation
roryabraham fb01bd2
Fix backTo bug
roryabraham 211f166
Merge branch 'main' into Rory-TransitionSurvey
roryabraham 50d47e9
Move switch to Expensify Classic to top of account settings page
roryabraham 3ee8832
Subtract keyboard height from maxHeight of form and input
roryabraham 50db2a4
Merge branch main into Rory-TransitionSurvey
roryabraham dcd132f
Make textinput uncontrolled for better performance on android, remove…
roryabraham 57fdf94
Fix offline icon on mobile
roryabraham 13cd0e5
Add padding to offline view
roryabraham f0091e4
Fix offline and mushroomtophat styles
roryabraham 3c64ea8
Merge branch 'main' into Rory-TransitionSurvey
roryabraham adbae00
Fix lockfiles after merge
roryabraham e3ac42d
Center align text on offline and confirm page
roryabraham 5d7c22a
Merge branch 'main' into Rory-TransitionSurvey
roryabraham 90a0b4a
Fix most types after merge
roryabraham 349f6d8
Fix types in ExitSurveyResponsePage
roryabraham 8e243fb
Merge branch 'main' into Rory-TransitionSurvey
roryabraham 45882a4
Fix typo in english translation
roryabraham 07a802d
Update MushroomTopHat illustration
roryabraham 1c4111b
Prepopulate reason form with draft reason
roryabraham 043601d
Remove outdated cleanup
roryabraham 3dfac29
Fix comment in NumberUtils
roryabraham c7f2b57
fix draft on reason page
roryabraham 22b6390
Setup RadioButtons to work as a controlled input
roryabraham 7be4f46
Switch backTo for response and confirm page if you're offline
roryabraham b5f26ed
Merge branch 'main' into Rory-TransitionSurvey
roryabraham ed8ef0d
Merge branch 'main' into Rory-TransitionSurvey
roryabraham faf6741
Use stable reference for onPress
roryabraham a5fb310
Delete gremlin file
roryabraham 411b281
Merge branch 'main' into Rory-TransitionSurvey
roryabraham 6040f50
Fix package-lock.json after conflict resolution
roryabraham c98c48f
Fix TS errors
roryabraham bd00fc3
Merge branch 'main' into Rory-TransitionSurvey
roryabraham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import type {ValueOf} from 'type-fest'; | ||
import type CONST from '@src/CONST'; | ||
|
||
type SwitchToOldDotParams = { | ||
reason: ValueOf<typeof CONST.EXIT_SURVEY.REASONS>; | ||
surveyResponse: string; | ||
}; | ||
|
||
export default SwitchToOldDotParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this down into
RadioButtons