[Audit][Implementation] getOrderedReportIDs - cache removal #36565

kacper-mikolajczak · 2024-02-15T10:52:46Z

Details

PR is a part of Callstack performance audit.

PR removes the cache from getORderedReportIDs function.

Fixed Issues

$ #36799
PROPOSAL: #33070

Tests

Open app
Open report
Write a message
Go back to LHN
See if ordering is correct (chat with draft is ordered correctly)
In general verify the order of the LHN is as expected with pinned, archived chats, rooms/ groups, IOUs, expense reports

Offline tests

N/A

QA Steps

Open app
Open report
Write a message
Go back to LHN
See if ordering is correct (chat with draft is ordered correctly)
1. In general verify the order of the LHN is as expected with pinned, archived chats, rooms/ groups, IOUs, expense reports

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mandroid.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mios.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…-cache-removal

melvin-bot · 2024-02-19T10:32:03Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-02-19T12:26:13Z

Running a test build https://github.com/Expensify/App/actions/runs/7959488503

jjcoffee · 2024-02-19T12:28:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2024-02-19_15.14.28.mp4

Android: mWeb Chrome

android-chrome-2024-02-19_13.49.03.mp4

iOS: Native

ios-native-2024-02-19_15.02.59.mp4

iOS: mWeb Safari

ios-safari-2024-02-19_14.17.47.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-02-19_13.40.44.mp4

MacOS: Desktop

desktop-app-2024-02-19_13.42.24.mp4

jjcoffee · 2024-02-19T12:30:40Z

@kacper-mikolajczak Could you add an Android mWeb screenshot?

github-actions · 2024-02-19T12:46:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/36565/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/36565/NewExpensify.dmg	https://36565.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

adhorodyski · 2024-02-19T14:13:59Z

src/pages/home/sidebar/SidebarLinksData.js

@@ -111,6 +110,7 @@ const defaultProps = {
        accountID: '',
    },
    transactionViolations: {},
+    allReportActions: {},


afaik this is still being passed down to the component, right? Is it still necessary?

the original comment also stripped down the prop being passed as a dependency, is this still a thing?

@kacper-mikolajczak Would you be able to check this one out please?

Please don't remove this prop. I need this in #35907

Ok in that case we can go ahead with merge, right?

cc @mountiny @shubham1206agra I'm a little worried that the above mentioned PR can introduce a performance regression in this scope - didn't have time to measure it yet, but since it eg. maps, reduces all of the keys or checks against regexp on this big data set it can become a bottleneck rather quickly (if not already). This is not related to this PR, but I wanted to let you know that we should test it first with this in mind as it directly impacts all of our core metrics.

Lets keep an eye out for that one, also I have asked Adam to try to add more complex test scenario for the reassure test so we can have better integrated protection from regressing this method

@adhorodyski Thanks for the heads up. I, too have the same doubt honestly. I will try to do something about this.

jjcoffee

Tests well!

kacper-mikolajczak · 2024-02-20T08:47:41Z

Could you add an Android mWeb screenshot?

Hey @jjcoffee sorry, it must've slipped through my fingers :D Updated ✅

mountiny

Looking good, lets merge this

OSBotify · 2024-02-20T17:48:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:07:50Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:56:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

remove caching

76c7490

adhorodyski approved these changes Feb 15, 2024

View reviewed changes

kacper-mikolajczak added 3 commits February 15, 2024 14:39

Merge branch 'main' into audit/implementation/get-ordered-raports-ids…

7aad33c

…-cache-removal

fix merge issues

c103561

Merge branch 'main' into audit/implementation/get-ordered-raports-ids…

035d65a

…-cache-removal

kacper-mikolajczak marked this pull request as ready for review February 19, 2024 10:31

kacper-mikolajczak requested a review from a team as a code owner February 19, 2024 10:31

melvin-bot bot requested review from jjcoffee and removed request for a team February 19, 2024 10:32

mountiny assigned kacper-mikolajczak Feb 19, 2024

mountiny added the Ready To Build label Feb 19, 2024

adhorodyski reviewed Feb 19, 2024

View reviewed changes

jjcoffee approved these changes Feb 19, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny February 19, 2024 14:15

mountiny approved these changes Feb 20, 2024

View reviewed changes

mountiny merged commit 12fc2cb into Expensify:main Feb 20, 2024
26 checks passed

jbroma mentioned this pull request Feb 23, 2024

perf: make switch between chat list and workspaces smoother #36420

Merged

50 tasks

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

jjcoffee mentioned this pull request Mar 7, 2024

[Payment due March 7] [Performance] Remove cache from the getOrderedReportIDs method #36799

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Audit][Implementation] getOrderedReportIDs - cache removal #36565

[Audit][Implementation] getOrderedReportIDs - cache removal #36565

kacper-mikolajczak commented Feb 15, 2024 •

edited

Loading

melvin-bot bot commented Feb 19, 2024

mountiny commented Feb 19, 2024

jjcoffee commented Feb 19, 2024 •

edited

Loading

jjcoffee commented Feb 19, 2024

github-actions bot commented Feb 19, 2024

adhorodyski Feb 19, 2024

adhorodyski Feb 19, 2024

mountiny Feb 19, 2024

shubham1206agra Feb 19, 2024

mountiny Feb 19, 2024

adhorodyski Feb 20, 2024 •

edited

Loading

mountiny Feb 20, 2024

shubham1206agra Feb 21, 2024

jjcoffee left a comment

kacper-mikolajczak commented Feb 20, 2024

mountiny left a comment

OSBotify commented Feb 20, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

[Audit][Implementation] getOrderedReportIDs - cache removal #36565

[Audit][Implementation] getOrderedReportIDs - cache removal #36565

Conversation

kacper-mikolajczak commented Feb 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 19, 2024

mountiny commented Feb 19, 2024

jjcoffee commented Feb 19, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Feb 19, 2024

github-actions bot commented Feb 19, 2024

adhorodyski Feb 19, 2024

Choose a reason for hiding this comment

adhorodyski Feb 19, 2024

Choose a reason for hiding this comment

mountiny Feb 19, 2024

Choose a reason for hiding this comment

shubham1206agra Feb 19, 2024

Choose a reason for hiding this comment

mountiny Feb 19, 2024

Choose a reason for hiding this comment

adhorodyski Feb 20, 2024 • edited Loading

Choose a reason for hiding this comment

mountiny Feb 20, 2024

Choose a reason for hiding this comment

shubham1206agra Feb 21, 2024

Choose a reason for hiding this comment

jjcoffee left a comment

Choose a reason for hiding this comment

kacper-mikolajczak commented Feb 20, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 20, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

kacper-mikolajczak commented Feb 15, 2024 •

edited

Loading

jjcoffee commented Feb 19, 2024 •

edited

Loading

adhorodyski Feb 20, 2024 •

edited

Loading