Remove underscore usage #40346

bernhardoj · 2024-04-17T12:11:56Z

Details

Removing underscore usage from the codebase.

Fixed Issues

$ #39121
PROPOSAL: #39121 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open the money request page
Enter any amount and press Next
Verify the Recent and Contact lists are shown correctly
Press Split to add a user to the split participant
Verify the user is added
Press the checked icon to unchecked it
Verify the user is unchecked
Press Split on a workspace and a user
Verify the Add to split button is disabled and there is an error message
Search for an unexisting user
Verify the unexisting user is shown
Select the user
Verify the user is shown on the confirmation page

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-04-17.at.19.59.11.mov

MacOS: Desktop

melvin-bot · 2024-04-17T12:12:01Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-04-17T12:17:24Z

A few notes:

Waiting for Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js #35822 before we can remove transactionPropTypes and MoneyRequestParticipantsSelector.
Since BaseOptionsSelector and MoneyTemporaryForRefactorRequestParticipantsSelector is still in JS, we got a lint error that prefers using underscore/lodash.

a. BaseOptionsSelector is deprecated and I see that we are replacing it with SelectionList in this issue, but I don't see the plan to do that in MoneyTemporaryForRefactorRequestConfirmationList yet.

BaseOptionsSelector usages left are in MoneyTemporaryForRefactorRequestConfirmationList and MoneyRequestConfirmationList. MoneyRequestConfirmationList is being replaced with MoneyTemporaryForRefactorRequestConfirmationList in #40176.

b. I don't see any issue migrating MoneyTemporaryForRefactorRequestParticipantsSelector, do we want to migrate this to TS?

@hungvu193 @mountiny

blazejkustra · 2024-04-17T14:41:48Z

@bernhardoj Lint is failing 👀

blazejkustra · 2024-04-17T14:48:02Z

Couple things that I noticed:

We should remove all // eslint-disable-next-line rulesdir/prefer-underscore-method comments from the codebase now.
You didn't uninstall underscore from the repo
Let's remove underscore from CIGitLogicTest.sh too
If needed let's use lodash in JS files to unblock this PR (in proptypes files and all remaining)
How a bout adjusting all comments in the codebase that refers to underscore? Example: // underscore promises in sequence without for-loop

src/SCREENS.ts

blazejkustra · 2024-04-17T14:49:05Z

src/components/OptionsSelector/BaseOptionsSelector.js

        this.relatedTarget = null;
-        this.accessibilityRoles = _.values(CONST.ROLE);
+        this.accessibilityRoles = Object.values(CONST.ROLE);


Let's disable the lint error with a comment

I think it would be better if we removed the ESLint config.

Or should i just use lodash here?

Updated to use lodash

hungvu193 · 2024-04-17T16:09:35Z

Since we will have 2,3 reviewers here, @bernhardoj can you also include my suggestion here in this PR?
Besides @blazejkustra's comment here, we need to do some additional tasks.

Remove underscore in eslint and webpack config
Remove (Update) underscore usage from our contributing guides

bernhardoj · 2024-04-18T03:59:28Z

We should remove all // eslint-disable-next-line rulesdir/prefer-underscore-method comments from the codebase now.

You didn't uninstall underscore from the repo

Let's remove underscore from CIGitLogicTest.sh too

If needed let's use lodash in JS files to unblock this PR (in proptypes files and all remaining)

How a bout adjusting all comments in the codebase that refers to underscore? Example: // underscore promises in sequence without for-loop

Done, but after removing the underscore from CIGitLogicTest.sh, the unit test fails. @blazejkustra Do you know how to fix it? Or is it expected?

Remove underscore in eslint and webpack config

@hungvu193 Removed from eslint, but I don't see any underscore-related config in webpack.

Remove (Update) underscore usage from our contributing guides

@mountiny Do we need to update this?

bernhardoj · 2024-04-18T04:07:06Z

.eslintrc.js

@@ -238,7 +238,6 @@ module.exports = {
                'jsdoc/no-types': 'error',
                'rulesdir/no-default-props': 'error',
                'import/no-extraneous-dependencies': 'off',
-                'rulesdir/prefer-underscore-method': 'off',


@blazejkustra We got lint errors when I removed this. Do we want to update eslint-config-expensify to remove this rule or keep turning this rule off?

I feel like we should eslint-config-expensify.

@mountiny can you confirm?

I will update this tomorrow

I have turned this off and added back npm install underscore in CIGitLogicTest for now since we don't have any answer yet. I think you can start reviewing it. @hungvu193

Btw, I ask for the help in slack

Sure. I'll review in a while

hungvu193 · 2024-04-19T20:11:00Z

We have conflicts here @bernhardoj

bernhardoj · 2024-04-20T04:40:13Z

Conflicts solved.

Waiting for Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js #35822 before we can remove transactionPropTypes and MoneyRequestParticipantsSelector.

Deleted both files

mountiny · 2024-04-20T19:21:14Z

Ready for a review @hungvu193

hungvu193 · 2024-04-21T08:00:50Z

Sure thing

hungvu193

Looks good. I left few NAB comments/

hungvu193 · 2024-04-22T01:47:39Z

src/components/OptionsSelector/BaseOptionsSelector.js

-            !this.props.isReadOnly && (this.props.shouldShowConfirmButton || this.props.footerContent) && !(this.props.canSelectMultipleOptions && _.isEmpty(this.props.selectedOptions));
-        const defaultConfirmButtonText = _.isUndefined(this.props.confirmButtonText) ? this.props.translate('common.confirm') : this.props.confirmButtonText;
+            !this.props.isReadOnly && (this.props.shouldShowConfirmButton || this.props.footerContent) && !(this.props.canSelectMultipleOptions && this.props.selectedOptions.length === 0);
+        const defaultConfirmButtonText = typeof this.props.confirmButtonText === 'undefined' ? this.props.translate('common.confirm') : this.props.confirmButtonText;


NAB, I think this.props.confirmButtonText === 'undefined' is enough.

You're right, updated!

src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

hungvu193 · 2024-04-22T01:53:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mChrome.mov

iOS: Native

Screen.Recording.2024-04-22.at.12.09.50.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

chrome.mov

MacOS: Desktop

desktop.mov

hungvu193 · 2024-04-22T09:15:13Z

We had some conflicts again @bernhardoj

bernhardoj · 2024-04-22T11:29:00Z

@hungvu193 conflicts solved

bernhardoj · 2024-04-22T11:57:57Z

tests/unit/CIGitLogicTest.sh

@@ -77,7 +76,7 @@ function bump_version {
  setup_git_as_osbotify
  git switch main
  npm --no-git-tag-version version "$(ts-node "$bumpVersion" "$(print_version)" "$1")"
-  git add package.json package-lock.json


So, the package-lock.json doesn't exist anymore after removing the npm install underscore, so not adding it to the git fix the error.

I think we shouldn't remove these two lines, maybe a better idea would be to install a different package?

npm install lodash

Ah, totally agree with that. Updated!

blazejkustra · 2024-04-22T13:35:25Z

tests/unit/CIGitLogicTest.sh

@@ -77,7 +76,7 @@ function bump_version {
  setup_git_as_osbotify
  git switch main
  npm --no-git-tag-version version "$(ts-node "$bumpVersion" "$(print_version)" "$1")"
-  git add package.json package-lock.json


I think we shouldn't remove these two lines, maybe a better idea would be to install a different package?

npm install lodash

blazejkustra · 2024-04-22T13:37:15Z

contributingGuides/STYLE.md

 ## Accessing Object Properties and Default Values

-Use `lodashGet()` to safely access object properties and `||` to short circuit null or undefined values that are not guaranteed to exist in a consistent way throughout the codebase. In the rare case that you want to consider a falsy value as usable and the `||` operator prevents this then be explicit about this in your code and check for the type using an underscore method e.g. `_.isBoolean(value)` or `_.isEqual(0)`.
+Use `lodashGet()` to safely access object properties and `||` to short circuit null or undefined values that are not guaranteed to exist in a consistent way throughout the codebase. In the rare case that you want to consider a falsy value as usable and the `||` operator prevents this then be explicit about this in your code and check for the type.


We are going to adjust this markdown in a separate PR, so we can leave it as it is now 👍

blazejkustra · 2024-04-22T13:38:25Z

contributingGuides/STYLE.md

@@ -448,7 +419,7 @@ const propTypes = {

 ### Important Note:

-In React Native, one **must not** attempt to falsey-check a string for an inline ternary. Even if it's in curly braces, React Native will try to render it as a `<Text>` node and most likely throw an error about trying to render text outside of a `<Text>` component. Use `_.isEmpty()` instead.
+In React Native, one **must not** attempt to falsey-check a string for an inline ternary. Even if it's in curly braces, React Native will try to render it as a `<Text>` node and most likely throw an error about trying to render text outside of a `<Text>` component. Use `.length > 0` instead.


Why not double negation?

Suggested change

In React Native, one **must not** attempt to falsey-check a string for an inline ternary. Even if it's in curly braces, React Native will try to render it as a `<Text>` node and most likely throw an error about trying to render text outside of a `<Text>` component. Use `.length > 0` instead.

In React Native, one **must not** attempt to falsey-check a string for an inline ternary. Even if it's in curly braces, React Native will try to render it as a `<Text>` node and most likely throw an error about trying to render text outside of a `<Text>` component. Use `!!` instead.

Oh, didn't think of that. I was just converting isEmpty to .length > 0.

Updated

src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

hungvu193

All yours @mountiny

mountiny

thanks, great job on this one

mountiny · 2024-04-22T16:55:23Z

contributingGuides/STYLE.md

@@ -112,38 +112,9 @@ if (someCondition) {
 }
 ```

-## Object / Array Methods
-
-We have standardized on using [underscore.js](https://underscorejs.org/) methods for objects and collections instead of the native [Array instance methods](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array#instance_methods). This is mostly to maintain consistency, but there are some type safety features and conveniences that underscore methods provide us e.g. the ability to iterate over an object and the lack of a `TypeError` thrown if a variable is `undefined`.


Should we still add this information in here? Seems like there is a preference and posibility of using lodash so it makes sense to leave a guide here in terms of what is preferred

mountiny · 2024-04-22T16:56:53Z

contributingGuides/STYLE.md

 ## Accessing Object Properties and Default Values

-Use `lodashGet()` to safely access object properties and `||` to short circuit null or undefined values that are not guaranteed to exist in a consistent way throughout the codebase. In the rare case that you want to consider a falsy value as usable and the `||` operator prevents this then be explicit about this in your code and check for the type using an underscore method e.g. `_.isBoolean(value)` or `_.isEqual(0)`.
+Use `lodashGet()` to safely access object properties and `||` to short circuit null or undefined values that are not guaranteed to exist in a consistent way throughout the codebase. In the rare case that you want to consider a falsy value as usable and the `||` operator prevents this then be explicit about this in your code and check for the type.


OSBotify · 2024-04-22T17:19:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-24T00:07:26Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T13:45:45Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

remove underscore and unused file

3a905c7

bernhardoj requested a review from a team as a code owner April 17, 2024 12:11

melvin-bot bot requested review from hungvu193 and removed request for a team April 17, 2024 12:12

bernhardoj mentioned this pull request Apr 17, 2024

[HOLD for payment 2024-05-02] [$250] [TS Migration] Remove underscore completely #39121

Closed

blazejkustra suggested changes Apr 17, 2024

View reviewed changes

bernhardoj added 11 commits April 18, 2024 11:13

remove unnecessary eslint disable

81f4716

Merge branch 'main' into chore/39121-remove-underscore

2fe221d

remove unnecessary eslint disable

84ab150

don't install underscore

7c9704b

replace underscore with lodash

ac5a4dd

fix lint

0cc0b12

prettier

861ea79

uninstall underscore

cca7dd7

update comment

c95933b

fix lint

5995e6c

remove underscore rule

612b324

bernhardoj commented Apr 18, 2024

View reviewed changes

bernhardoj added 6 commits April 19, 2024 18:22

Merge branch 'main' into chore/39121-remove-underscore

5901f28

turn off prefer underscore lint back

583ccaa

add back underscore

880ef45

prettier

99760ff

remove underscore guideline

b7bb995

Merge branch 'main' into chore/39121-remove-underscore

26e3367

bernhardoj added 2 commits April 20, 2024 12:38

Merge branch 'main' into chore/39121-remove-underscore

15c00f0

remove unused files

3c4bcf8

remove underscore from code example

2b51b64

mountiny assigned bernhardoj Apr 20, 2024

mountiny requested a review from blazejkustra April 21, 2024 21:07

hungvu193 reviewed Apr 22, 2024

View reviewed changes

bernhardoj added 2 commits April 22, 2024 19:25

Merge branch 'main' into chore/39121-remove-underscore

2be0ef2

simplify code

60b1ade

bernhardoj commented Apr 22, 2024

View reviewed changes

blazejkustra suggested changes Apr 22, 2024

View reviewed changes

replaced underscore with lodash

c6ee94f

bernhardoj force-pushed the chore/39121-remove-underscore branch from e626327 to c6ee94f Compare April 22, 2024 14:07

bernhardoj added 2 commits April 22, 2024 22:12

Merge branch 'main' into chore/39121-remove-underscore

fbb7e8b

update doc

8ce0836

blazejkustra approved these changes Apr 22, 2024

View reviewed changes

hungvu193 approved these changes Apr 22, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny April 22, 2024 14:31

mountiny approved these changes Apr 22, 2024

View reviewed changes

mountiny merged commit 42c494e into Expensify:main Apr 22, 2024
23 checks passed

github-actions bot mentioned this pull request Apr 23, 2024

Deploy Checklist: New Expensify 2024-04-23 #40843

Closed

74 tasks

	In React Native, one must not attempt to falsey-check a string for an inline ternary. Even if it's in curly braces, React Native will try to render it as a `<Text>` node and most likely throw an error about trying to render text outside of a `<Text>` component. Use `.length > 0` instead.
	In React Native, one must not attempt to falsey-check a string for an inline ternary. Even if it's in curly braces, React Native will try to render it as a `<Text>` node and most likely throw an error about trying to render text outside of a `<Text>` component. Use `!!` instead.

Remove underscore usage #40346

Remove underscore usage #40346

Conversation

bernhardoj commented Apr 17, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 17, 2024

bernhardoj commented Apr 17, 2024

blazejkustra commented Apr 17, 2024

blazejkustra commented Apr 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hungvu193 commented Apr 17, 2024

bernhardoj commented Apr 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hungvu193 commented Apr 19, 2024

bernhardoj commented Apr 20, 2024

mountiny commented Apr 20, 2024

hungvu193 commented Apr 21, 2024

hungvu193 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hungvu193 commented Apr 22, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 commented Apr 22, 2024

bernhardoj commented Apr 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bernhardoj Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

hungvu193 left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Apr 22, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

hungvu193 commented Apr 22, 2024 •

edited

Loading

bernhardoj Apr 22, 2024 •

edited

Loading