React Native 0.74 upgrade

[MrRefactor]

Details

Upgrade to react native 0.74

PATCHES:
Added/Changed:
@expensify+react-native-live-markdown+0.1.88.patch - link to upstream PR -> link
patches/expo-asset+10.0.9.patch - patch for Storybook to work
patches/react-native+0.74.2+010+Bridgeless.patch - disable bridgeless for both Android and iOS
patches/react-native+0.74.2+011+mapbufferjni.patch - link to upstream issue -> link
patches/react-native+0.74.2+014+invertedFlatList.patch - link to upstream PR - link
patches/react-native+0.74.2+015+nativeDriver.patch - link to upstream PR - link
patches/react-native-image-picker+7.0.3+001+allowedMimeTypes.patch - link to upstream PR - link
patches/react-native-vision-camera+4.0.0-beta.13.patch - link to upstream issue - link
patches/react-native-device-info+10.3.1+002+turbomodule.patch - link to upstream PR - link
patches/@react-native-community+netinfo+11.2.1+002+turbomodule.patch - link to upstream PR - link
patches/@onfido+react-native-sdk+10.6.0.patch - link to upstream PR - link

Removed:
patches/expo+50.0.4.patch
patches/expo-av+13.10.4.patch
patches/expo-modules-autolinking+1.10.2.patch
patches/expo-modules-core+1.11.8+001+initial.patch
patches/react-native+0.73.4+002+SuspenseFix.patch
patches/react-native+0.73.4+006+Codegen.patch
patches/react-native+0.73.4+011+optionalViewRecycling.patch
patches/react-native+0.73.4+013+exposePrefabs.patch
patches/react-native+0.73.4+014+fix-inverted-flatlist.patch
patches/react-native+0.73.4+014+fixPath.patch
patches/react-native+0.73.4+015+fixIOSWebViewCrash.patch
patches/react-native+0.73.4+016+iOS-textinput-onscroll-event.patch
patches/react-native-reanimated+3.7.2+001+fix-boost-dependency.patch
patches/react-native-reanimated+3.7.2+002+copy-state.patch

Fixed Issues

$ #37374
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[roryabraham]

Two things:

1. For any new patches, please include a link to the upstream PR in this PR description. This is critical for us because when upgrade the dependency in the future we need a clear record of what the patch is and does to understand how or if it needs to be migrated to the new version of the dependency. We should only be adding patches where there is an existing PR upstream. The ideal path is to get those upstream PRs merged and to upgrade the dependency rather than introducing a patch.
2. Let's try to find ways to incrementally land portions of this PR to reduce the diff and decrease the likelihood of regressions. There appear to be a number of changes that we could introduce in separate PRs and merge sooner. Most notably, all the dependency upgrades (onfido, mapbox, reanimated, webview, safe-area-context, eslint + jest). Please try to work with your coworkers to create several separate upgrade PRs so we can land those upgrades in production ASAP.

[MrRefactor]

@staszekscp I have updated all of the expo patches you mentioned, please take a look if everything seems fine

[staszekscp]

Thanks @MrRefactor! Is the app buildable from this PR at the moment? If so, tomorrow I will try to build HybridApp from this PR

EDIT: I will test it this week, but currently I'm swamped with some other issues

[MrRefactor]

Thanks @MrRefactor! Is the app buildable from this PR at the moment? If so, tomorrow I will try to build HybridApp from this PR

Yes, it is

[shubham1206agra]

@MrRefactor Can you update description to reflect correct patches?

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40548/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40548/NewExpensify.dmg	https://40548.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40548/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40548/NewExpensify.dmg	https://40548.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[perunt]

Can you try this workaround? It should work. It is not the ideal solution, but it will be removed in RN75. MrRefactor#1

[staszekscp]

So, I've managed to have a go, and tried to build the HybridApp from this PR - there are some build errors, though. 😢 However I think they shouldn't be very difficult to resolve. A couple of patches and tweaks in build.gradle/Podfile should do the trick. 😄

It may take me like a day or two to resolve everything, but I won't be able to jump in at this moment. That's why I don't want the HybridApp to be a blocker of this PR. However, when it gets merged HybridApp may be broken for some time

cc: @AndrewGable

[MrRefactor]

So, I've managed to have a go, and tried to build the HybridApp from this PR - there are some build errors, though. 😢 However I think they shouldn't be very difficult to resolve. A couple of patches and tweaks in build.gradle/Podfile should do the trick. 😄

It may take me like a day or two to resolve everything, but I won't be able to jump in at this moment. That's why I don't want the HybridApp to be a blocker of this PR. However, when it gets merged HybridApp may be broken for some time

cc: @AndrewGable

Thanks for checking that @staszekscp , after talking to @AndrewGable on Monday I was told that next HybridApp release is planned around 8/14, so we cannot merge PR until the release. Please let me know when you will be able to work on adjusting build.gradle/Podfile

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40548/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40548/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40548/NewExpensify.dmg	https://40548.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40548/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40548/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40548/NewExpensify.dmg	https://40548.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[perunt]

@MrRefactor, how is it going here? Do we have any plans/estimates for this?

[chrispader]

... I was told that next HybridApp release is planned around 8/14, so we cannot merge PR until the release.

Was there a new HybridApp release and can we continue working on this PR? It would be awesome if we could push this PR through, since there are some other major PRs that are on HOLD for this:

#37891
#42143

[roryabraham]

Closing this in favor of the 0.75 upgrade

[IuliiaHerets]

Tasks - App crashes when assigning someone to a task without assignees

Version Number: 9.0.17-1
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4843131
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Launch new Expensify
2. Navigate to any chat with a task not yet assigned (or create one)
3. Tap on the chat > assign > select any assignee

Expected Result:

The selected assignee is added without issues

Actual Result:

The app crashes. An already assigned task can change assignees without issues. Issue is reproducible only on tasks without any assignees

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6581806_1724548130495.RPReplay_Final1724547776.mp4

View all open jobs on GitHub

[MrRefactor]

hey @IuliiaHerets this PR is closed, and shouldnt be tested anymore, did that issue occur on builds from 0.75 upgrade as well?