Fix LHN shows Not found when navigated from global create menu or report parent navigation link #43086

bernhardoj · 2024-06-05T02:24:15Z

Details

Navigating from global create (FAB) or from report parent navigation link while in search page shows not found in LHN.

Fixed Issues

$ #42995
PROPOSAL: #42995 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

A.

Open search page
Click on the global create menu
Submit an expense
(small screen) Go back
Verify the LHN shows the chat list

B.

Open search page
Click on a result
Click on the header "From" link
(small screen) Go back
Verify the LHN shows the chat list

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-05.at.10.19.13.mov

Android: mWeb Chrome

Screen.Recording.2024-06-05.at.10.09.42.mov

iOS: Native

Screen.Recording.2024-06-05.at.10.18.07.mov

iOS: mWeb Safari

Screen.Recording.2024-06-05.at.10.04.13.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-05.at.09.50.53.mov

Screen.Recording.2024-06-05.at.09.51.52.mov

MacOS: Desktop

Screen.Recording.2024-06-05.at.10.00.39.1.mov

melvin-bot · 2024-06-05T02:24:20Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-06-05T02:26:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

43086-android.mp4

Android: mWeb Chrome

43086-androidmWeb.mp4

iOS: Native

43086-iOS.mp4

iOS: mWeb Safari

43086-iOSmWeb.mp4

MacOS: Chrome / Safari

43086-webChrome.mp4

MacOS: Desktop

43086-desktop.mp4

bernhardoj · 2024-06-05T02:29:55Z

I notice another small issue. After performing the test step, you can notice the chat icon in the bottom tab isn't highlighted.

It's because if the topmost central pane is the search page, we return the search page as the current tab name.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 58 to 66 in 3c04b02

    
           const currentTabName = useNavigationState<RootStackParamList, string | undefined>((state) => { 
        
               const topmostCentralPaneRoute = getTopmostCentralPaneRoute(state); 
        
               if (topmostCentralPaneRoute && topmostCentralPaneRoute.name === SCREENS.SEARCH.CENTRAL_PANE) { 
        
                   return SCREENS.SEARCH.CENTRAL_PANE; 
        
               } 
        
               const topmostBottomTabRoute = getTopmostBottomTabRoute(state); 
        
               return topmostBottomTabRoute?.name ?? SCREENS.HOME;

I haven't checked further the reason behind it, but I think the current tab name should only depend on the topmost bottom tab.

bernhardoj · 2024-06-05T02:32:10Z

Also, for some reason, when I testing on other platforms other than web, the search type returned from the BE is transactions,

App/src/components/Search.tsx

Line 93 in 3c04b02

const type = SearchUtils.getSearchType(searchResults?.search);

App/src/libs/SearchUtils.ts

Lines 38 to 41 in 3c04b02

    
           function getSearchType(search: OnyxTypes.SearchResults['search']): SearchDataTypes | undefined { 
        
               if (!isSearchDataType(search.type)) { 
        
                   return undefined; 
        
               }

which doesn't exist on the search data type CONST, so the type is undefined and the list is empty/blank.

App/src/CONST.ts

Lines 4802 to 4805 in 3c04b02

    
           SEARCH_DATA_TYPES: { 
        
               TRANSACTION: 'transaction', 
        
               REPORT: 'report', 
        
           },

I manually add transactions to the CONST to be able to test this.

c3024

LGTM

trjExpensify · 2024-06-05T09:29:33Z

I notice another small issue. After performing the test step, you can notice the chat icon in the bottom tab isn't highlighted.
It's because if the topmost central pane is the search page, we return the search page as the current tab name.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 58 to 66 in 3c04b02

const currentTabName = useNavigationState<RootStackParamList, string | undefined>((state) => {

const topmostCentralPaneRoute = getTopmostCentralPaneRoute(state);

if (topmostCentralPaneRoute && topmostCentralPaneRoute.name === SCREENS.SEARCH.CENTRAL_PANE) {

return SCREENS.SEARCH.CENTRAL_PANE;

}

const topmostBottomTabRoute = getTopmostBottomTabRoute(state);

return topmostBottomTabRoute?.name ?? SCREENS.HOME;

I haven't checked further the reason behind it, but I think the current tab name should only depend on the topmost bottom tab.

@c3024 did you notice this as well?

trjExpensify · 2024-06-05T09:31:16Z

Also, for some reason, when I testing on other platforms other than web, the search type returned from the BE is transactions,

App/src/components/Search.tsx

Line 93 in 3c04b02

const type = SearchUtils.getSearchType(searchResults?.search);

App/src/libs/SearchUtils.ts

Lines 38 to 41 in 3c04b02

function getSearchType(search: OnyxTypes.SearchResults['search']): SearchDataTypes | undefined {

if (!isSearchDataType(search.type)) {

return undefined;

}

which doesn't exist on the search data type CONST, so the type is undefined and the list is empty/blank.

App/src/CONST.ts

Lines 4802 to 4805 in 3c04b02

SEARCH_DATA_TYPES: {

TRANSACTION: 'transaction',

REPORT: 'report',

},

I manually add transactions to the CONST to be able to test this.

This transaction vs transactions issue seems related to what we fixed the other day in an authPR, but had to revert when we rolled a deploy back. Carlos has a new authPR up here (you won't be able to access that link) to revert the revert to get it redeployed.

c3024 · 2024-06-05T09:47:20Z

I don't see it on MacOS Chrome.

chatIconFilled.mp4

bernhardoj · 2024-06-05T10:15:47Z

@c3024 it's only on the small screen

luacmartins · 2024-06-05T15:01:16Z

I notice another small issue. After performing the test step, you can notice the chat icon in the bottom tab isn't highlighted.

I do see this issue on small screens. I think it's small enough that we could tackle as a follow up. @bernhardoj would you be able to investigate that and work on a fix please?

Also, for some reason, when I testing on other platforms other than web, the search type returned from the BE is transactions

Yea, this is expected for now. Should be fixed later today

OSBotify · 2024-06-05T15:14:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2024-06-06T15:42:26Z

Hey, I'm struggling to locate a regression where opening users comment on a new MoneyReport, then 'Reply in Thread' and try to tap the blue Thread link causes a 'Report not found' error.

This is one of a few PRs that seem either a cause or just related. If you have any thoughts or suggestions, please let me know.

luacmartins · 2024-06-06T17:02:38Z

I confirmed above that reverting this PR doesn't solve the issue.

Julesssss · 2024-06-07T08:28:48Z

Thanks for testing

OSBotify · 2024-06-11T23:35:04Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ZhenjaHorbach · 2024-08-28T07:41:54Z

src/libs/Navigation/linkTo/index.ts


            // If we navigate to SCREENS.SEARCH.CENTRAL_PANE, it's necessary to pass the current policyID, but we have to remember that this param is called policyIDs on this page
            if (action.payload.params?.screen === SCREENS.SEARCH.CENTRAL_PANE && action.payload?.params?.params && policyID) {
                action.payload.params.params.policyIDs = policyID;
            }

+            // If the type is UP, we deeplinked into one of the RHP flows and we want to replace the current screen with the previous one in the flow
+            // and at the same time we want the back button to go to the page we were before the deeplink
+        } else if (type === CONST.NAVIGATION.TYPE.UP) {


Came from this issue
We have specific case when navigation will replace the last route with the target report which is the expense report and the stack navigator becomes Bottom tab bar --> Chat report --> Expense report --> Expense report.
As result App returns to the same expense report when tapping back button

bernhardoj added 2 commits June 5, 2024 10:12

only switch to search bottom tab if there is no route passed

e0fc838

prioritize central pane screen case over UP

9a61f72

bernhardoj requested a review from a team as a code owner June 5, 2024 02:24

melvin-bot bot removed the request for review from a team June 5, 2024 02:24

melvin-bot bot requested a review from c3024 June 5, 2024 02:24

c3024 approved these changes Jun 5, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins June 5, 2024 05:45

luacmartins approved these changes Jun 5, 2024

View reviewed changes

luacmartins merged commit 8dbec8d into Expensify:main Jun 5, 2024
16 checks passed

github-actions bot mentioned this pull request Jun 6, 2024

Deploy Checklist: New Expensify 2024-06-06 #43168

Closed

Julesssss mentioned this pull request Jun 6, 2024

[HOLD for payment 2024-08-19] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Thread - App shows not here page when clicking on blue "Thread" in thread view #43172

Closed

6 tasks

luacmartins mentioned this pull request Jun 6, 2024

Revert "Fix LHN shows Not found when navigated from global create menu or report parent navigation link" #43200

Closed

melvin-bot bot mentioned this pull request Jun 11, 2024

[HOLD for payment 2024-06-20] [$500] [Search v1] LHN shows Not found when navigated from global create menu #42995

Closed

6 tasks

ZhenjaHorbach mentioned this pull request Aug 28, 2024

[Paid] [$250] [Held requests] Back button on expense report reopens same report after returning from Hold page #47259

Closed

6 tasks

ZhenjaHorbach reviewed Aug 28, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix LHN shows Not found when navigated from global create menu or report parent navigation link #43086

Fix LHN shows Not found when navigated from global create menu or report parent navigation link #43086

bernhardoj commented Jun 5, 2024

melvin-bot bot commented Jun 5, 2024

c3024 commented Jun 5, 2024 •

edited

Loading

bernhardoj commented Jun 5, 2024

bernhardoj commented Jun 5, 2024

c3024 left a comment

trjExpensify commented Jun 5, 2024

trjExpensify commented Jun 5, 2024

c3024 commented Jun 5, 2024

bernhardoj commented Jun 5, 2024

luacmartins commented Jun 5, 2024

OSBotify commented Jun 5, 2024

Julesssss commented Jun 6, 2024 •

edited

Loading

luacmartins commented Jun 6, 2024

Julesssss commented Jun 7, 2024

OSBotify commented Jun 11, 2024

ZhenjaHorbach Aug 28, 2024

Fix LHN shows Not found when navigated from global create menu or report parent navigation link #43086

Fix LHN shows Not found when navigated from global create menu or report parent navigation link #43086

Conversation

bernhardoj commented Jun 5, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 5, 2024

c3024 commented Jun 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

bernhardoj commented Jun 5, 2024

bernhardoj commented Jun 5, 2024

c3024 left a comment

Choose a reason for hiding this comment

trjExpensify commented Jun 5, 2024

trjExpensify commented Jun 5, 2024

c3024 commented Jun 5, 2024

bernhardoj commented Jun 5, 2024

luacmartins commented Jun 5, 2024

OSBotify commented Jun 5, 2024

Julesssss commented Jun 6, 2024 • edited Loading

luacmartins commented Jun 6, 2024

Julesssss commented Jun 7, 2024

OSBotify commented Jun 11, 2024

ZhenjaHorbach Aug 28, 2024

Choose a reason for hiding this comment

c3024 commented Jun 5, 2024 •

edited

Loading

Julesssss commented Jun 6, 2024 •

edited

Loading