Fix loading skeleton displays behaviors when opening report #43970

tsa321 · 2024-06-19T01:39:45Z

Details

Fixed Issues

$ #43791
PROPOSAL: #43791 (comment)

Tests

Sign-out then sign-in
Open a report with expense
Notice there is no reportpreview message at the bottom and full skeleton loading is shown
Open other report
go back to report (2) Notice the report is shown immediately without skeleton loading displays
Open a report with linked message
Click on the linked message. Notice if the linked message is displayed previously, skeleton won't be shown
Click on report preview. Then go back using header link. Notice the skeleton loading isn't displayed
Try navigating to other reports. Notice the behavior when opening a report are full skeleton loading is displayed or report displayed immediately.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Sign-out then sign-in
Open a report with expense
Notice there is no reportpreview message at the bottom and full skeleton loading is shown
Open other report
go back to report (2) Notice the report is shown immediately without skeleton loading displays
Open a report with linked message
Click on the linked message. Notice if the linked message is displayed previously, skeleton won't be shown
Click on report preview. Then go back using header link. Notice the skeleton loading isn't displayed
Try navigating to other reports. Notice the behavior when opening a report are full skeleton loading is displayed or report displayed immediately.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-d.mp4

Android: mWeb Chrome

android-mweb_d.mp4

iOS: Native

ios-native_d.mp4

iOS: mWeb Safari

ios-msfari_d.mp4

MacOS: Chrome / Safari

macos-web-d.mp4

MacOS: Desktop

macos-desktop_d.mp4

Signed-off-by: Tsaqif <[email protected]>

melvin-bot · 2024-06-19T01:39:49Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

akinwale · 2024-06-19T13:24:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

43970-android-native.mp4

Android: mWeb Chrome

43970-android-chrome.mp4

iOS: Native

43970-ios-native.mp4

iOS: mWeb Safari

43970-ios-safari.mp4

MacOS: Chrome / Safari

43970-web.mp4

MacOS: Desktop

43970-desktop.mp4

akinwale

LGTM.

tgolen · 2024-06-21T16:39:31Z

src/pages/home/ReportScreen.tsx

        [sortedAllReportActions, reportActionIDFromRoute],
    );
+    const isCreatedActionExist = ReportActionsUtils.isCreatedAction(reportActions.at(-1));


Please rename this to doesCreatedActionExists

Signed-off-by: Tsaqif <[email protected]>

tsa321 · 2024-06-21T19:11:20Z

@tgolen I have changed the constant name.

tgolen

Thank you!

OSBotify · 2024-06-21T19:48:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-21T21:44:11Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dangrous · 2024-06-24T19:22:58Z

Hi! looks like this PR caused #44280 - specifically commit 07ed891 . Can you take a look? I will too

EDIT: latest notes - #44280 (comment)

Closed that issue since it was fixed with the revert - but here are the testing steps:

Login to an account
Disable the internet connection in the device
Navigate to a chat with history that you have not opened
Notice that the chat opens and the loading animation is shown
Send a message
Sent Message is not shown - SHOULD BE SHOWN AT 50% OPACITY

tsa321 · 2024-06-24T21:33:49Z

I am sorry

OSBotify · 2024-06-25T19:44:47Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sakluger · 2024-07-22T23:41:00Z

@ishpaul777 I saw you tried reverting this PR then closed that revert. Did this PR cause any regressions, or no?

tsa321 · 2024-07-23T00:04:03Z

@sakluger, the context is in this issue: #45910
and my second PR is here: #44488

This PR is my first PR that caused a regression.

Fix loading skeleton displays behaviors on opening report

07ed891

Signed-off-by: Tsaqif <[email protected]>

tsa321 requested a review from a team as a code owner June 19, 2024 01:39

melvin-bot bot removed the request for review from a team June 19, 2024 01:39

melvin-bot bot requested a review from akinwale June 19, 2024 01:39

akinwale approved these changes Jun 20, 2024

View reviewed changes

melvin-bot bot requested a review from tgolen June 20, 2024 23:47

tgolen requested changes Jun 21, 2024

View reviewed changes

tsa321 added 2 commits June 22, 2024 01:54

Change the constant name isCreatedActionExist to doesCreatedActionExist

a3a90e6

Signed-off-by: Tsaqif <[email protected]>

Fix typo

487a38e

Signed-off-by: Tsaqif <[email protected]>

tsa321 requested a review from tgolen June 21, 2024 19:11

tgolen approved these changes Jun 21, 2024

View reviewed changes

tgolen merged commit 854a8a1 into Expensify:main Jun 21, 2024
14 checks passed

github-actions bot mentioned this pull request Jun 21, 2024

Deploy Checklist: New Expensify 2024-06-21 #44186

Closed

tsa321 mentioned this pull request Jun 24, 2024

[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Search - RHP loads infinitely when deleting expense from report details page #44212

Closed

6 tasks

dangrous mentioned this pull request Jun 24, 2024

Chat - messages sent while the conversation is loading in offline are not shown #44280

Closed

6 tasks

tgolen mentioned this pull request Jun 24, 2024

Revert "Fix loading skeleton displays behaviors when opening report" #44335

Merged

48 tasks

melvin-bot bot mentioned this pull request Jun 25, 2024

[HOLD for payment 07-31-2024][$250] CRITICAL [UX Reliability] The loading skeleton exhibits three different behaviors #43791

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix loading skeleton displays behaviors when opening report #43970

Fix loading skeleton displays behaviors when opening report #43970

tsa321 commented Jun 19, 2024 •

edited

Loading

melvin-bot bot commented Jun 19, 2024

akinwale commented Jun 19, 2024 •

edited

Loading

akinwale left a comment

tgolen Jun 21, 2024

tsa321 commented Jun 21, 2024

tgolen left a comment

OSBotify commented Jun 21, 2024

OSBotify commented Jun 21, 2024

dangrous commented Jun 24, 2024 •

edited

Loading

tsa321 commented Jun 24, 2024

OSBotify commented Jun 25, 2024

sakluger commented Jul 22, 2024

tsa321 commented Jul 23, 2024

Fix loading skeleton displays behaviors when opening report #43970

Fix loading skeleton displays behaviors when opening report #43970

Conversation

tsa321 commented Jun 19, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 19, 2024

akinwale commented Jun 19, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

akinwale left a comment

Choose a reason for hiding this comment

tgolen Jun 21, 2024

Choose a reason for hiding this comment

tsa321 commented Jun 21, 2024

tgolen left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 21, 2024

OSBotify commented Jun 21, 2024

dangrous commented Jun 24, 2024 • edited Loading

tsa321 commented Jun 24, 2024

OSBotify commented Jun 25, 2024

sakluger commented Jul 22, 2024

tsa321 commented Jul 23, 2024

tsa321 commented Jun 19, 2024 •

edited

Loading

akinwale commented Jun 19, 2024 •

edited

Loading

dangrous commented Jun 24, 2024 •

edited

Loading