Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump expensify-common and react-native-live-markdown #44262

Merged
merged 9 commits into from
Jul 9, 2024
Merged

Bump expensify-common and react-native-live-markdown #44262

merged 9 commits into from
Jul 9, 2024

Conversation

BrtqKr
Copy link
Contributor

@BrtqKr BrtqKr commented Jun 24, 2024 •
edited
Loading

There have been a couple of fixes related to the empty blockquotes, which will be enabled by this version update.

I'd assume that all the changes included in those versions have been verified in the PRs from the corresponding libraries, but this should probably be tested more precisely, probably during QA.

Details

Fixed Issues

$ #43323
$ #40969
$ #40412
$ #40692

PROPOSAL:

Tests

  1. Emoji alignment:
  • Insert emoji to the report input
  • Verify that the cursor is aligned to the middle, instead of the bottom
image
  1. Phone number mention
  • Go to chat.
  • Send a phone number mention.
  • Right click on the message > Edit comment
  • Verify that mention in edit comment is not showing @expensify.sms.](url)
  1. Enable empty blockquotes
  • Go to the chat
  • Type
> test
> 
> test2
  • Send the message
  • Verify that the line starting with > is included in the blockquote and treated as an empty line. The result should look like this:
  1. Excluding incorrect blockquote
  • Type
>hey
> hey
>   hey

  • Send the message

  • The first line shouldn't be treated as a part of the blockquote

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Quite a general change, so I'd suggest checking any regressions emphasizing the blockquotes.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2024-06-25.at.15.21.47.mov
Android: mWeb Chrome
Screen.Recording.2024-06-25.at.15.28.50.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-25.at.14.53.46.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-25.at.15.35.26.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-06-25.at.14.41.04.mov
Screen.Recording.2024-06-25.at.14.39.23.mov
MacOS: Desktop
Screen.Recording.2024-06-25.at.14.57.44.mov

@BrtqKr BrtqKr mentioned this pull request Jun 24, 2024
Closed
6 tasks
@BrtqKr BrtqKr mentioned this pull request Jun 24, 2024
Closed
6 tasks
@BrtqKr BrtqKr marked this pull request as ready for review June 24, 2024 13:48
@BrtqKr BrtqKr requested a review from a team as a code owner June 24, 2024 13:48
@melvin-bot melvin-bot bot removed the request for review from a team June 24, 2024 13:48
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 24, 2024

@dannymcclain @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@BartoszGrajdek BartoszGrajdek mentioned this pull request Jun 24, 2024
Closed
6 tasks
@mountiny
Copy link
Contributor

There have been a couple of fixes related to the empty blockquotes, which will be enabled by this version update.

@BrtqKr @BartoszGrajdek Can you please include all the issues that should be fixed in this bump and list testing steps for them?

Furthermore include recordings in the checklist confirming your testing of all the issues this bump should fix? thank

situchan
situchan reviewed Jun 25, 2024
View reviewed changes
ios/Podfile.lock Outdated
@@ -282,27 +282,10 @@ PODS:
- nanopb/encode (= 2.30908.0)
- nanopb/decode (2.30908.0)
- nanopb/encode (2.30908.0)
- Onfido (29.7.1)
- Onfido (29.6.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of unrelated changes in this file 😮

These are all we need:
image
image

Please undo all other changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those dependencies are coming from the new architecture - it's because of pod update Onfido, without that pod install isn't going through 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we might have to test for anything the pod install changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those dependencies are coming from the new architecture - it's because of pod update Onfido, without that pod install isn't going through 🤷

Hmm, it works fine to me without pod update.
If it's required, can we do that in separate PR?

@VickyStash VickyStash mentioned this pull request Jun 25, 2024
Merged
53 tasks
@BrtqKr
Copy link
Contributor Author

BrtqKr commented Jun 25, 2024 •
edited
Loading

@mountiny I've added the recordings and all related issues with testing steps.

Regarding Podfile - I've talked about this with @j-piasecki and we hoped this could be solved with RCT_NEW_ARCH_ENABLED=1 pod update Onfido, but the result was the same. Right now it's still containing some other things, but it's much better, so I guess we can probably test it during QA if necessary.

@BrtqKr BrtqKr requested review from mountiny and situchan June 25, 2024 14:07
situchan
situchan reviewed Jun 26, 2024
View reviewed changes
ios/Podfile.lock
@@ -2623,7 +2629,7 @@ SPEC CHECKSUMS:
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
Turf: 13d1a92d969ca0311bbc26e8356cca178ce95da2
VisionCamera: 1394a316c7add37e619c48d7aa40b38b954bf055
Yoga: 64cd2a583ead952b0315d5135bf39e053ae9be70
Yoga: 1b901a6d6eeba4e8a2e8f308f708691cdb5db312
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checksum is still 64cd2a583ead952b0315d5135bf39e053ae9be70 for me. Maybe depend on device.

Other changes look good

@situchan
Copy link
Contributor

Bug on iOS: emoji glitch

https://drive.google.com/file/d/1Sns-YA3uf7WWcHeI8nrO11yAVkymxpwa/view?usp=sharing

@situchan
Copy link
Contributor

@BrtqKr #42082 is not fixed yet. Please check the expected result.

@BrtqKr
Copy link
Contributor Author

BrtqKr commented Jun 26, 2024

@BrtqKr #42082 is not fixed yet. Please check the expected result.

I'll resolve this separately, I've updated the description

@BrtqKr BrtqKr requested a review from situchan June 26, 2024 10:52
@BrtqKr
Copy link
Contributor Author

BrtqKr commented Jun 26, 2024

Bug on iOS: emoji glitch

https://drive.google.com/file/d/1Sns-YA3uf7WWcHeI8nrO11yAVkymxpwa/view?usp=sharing

@BartoszGrajdek has been working on the emojis, he'll take a look at that soon

@BartoszGrajdek
Copy link
Contributor

Hi!

No changes we have added in these versions should have affected iOS emojis the way it's shown in the video. The PR containing vertical alignment for emoji only changes it on the web version, so this shouldn't be related to the version bump. I've tried reverting these changes locally and the same bug happened, let me check it on main as well to confirm 🤓

@BartoszGrajdek
Copy link
Contributor

Confirmed, same thing happening on main cc @situchan

@situchan
Copy link
Contributor

situchan commented Jul 9, 2024

@situchan, I can't reproduce this. It looks as expected

image

Not reproducible anymore in this build. Reproduced in the past build.

situchan
situchan approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@situchan situchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

mountiny
mountiny previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but asked in Slack one question

.github/actions/javascript/bumpVersion/index.js Show resolved Hide resolved
mountiny
mountiny previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mountiny mountiny merged commit 9eea405 into Expensify:main Jul 9, 2024
18 checks passed
This was referenced Jul 9, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
Open
Open
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@devguest07 devguest07 mentioned this pull request Jul 10, 2024
Open
6 tasks
@pecanoro
Copy link
Contributor

This caused the regression here, but I am not sure if it's bad enough to hold the deploy on it.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@situchan situchan situchan approved these changes

@mountiny mountiny mountiny approved these changes

@dannymcclain dannymcclain Awaiting requested review from dannymcclain

@sobitneupane sobitneupane Awaiting requested review from sobitneupane

Assignees

@BrtqKr BrtqKr

Labels
Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BrtqKr @mountiny @situchan @BartoszGrajdek @OSBotify @pecanoro