Feature: Implement 3ds flow #44321

waterim · 2024-06-24T19:52:47Z

Details

Implemented 3ds flow

Fixed Issues

$ #42432, #42433
PROPOSAL: N/A

Tests

NOTE: You need to connect to someone local backend to test live mode of the stripe

Navigate to /settings/subscription/add-payment-card
Fill the data with card which requires authentication from here https://docs.stripe.com/testing#regulatory-cards
Select GBP currency
Observe that modal appears correctly
Try to close it

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

None

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

…t_3ds_flow

melvin-bot · 2024-06-26T11:23:23Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2024-06-27T05:35:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-07-23.at.17.49.55.mov

MacOS: Desktop

Pujan92 · 2024-06-27T06:45:29Z

@waterim The modal isn't getting closed after fail/success. I believe the backend needs to send a pusher event with the privateStripeCustomerID status.

Screen.Recording.2024-06-27.at.12.10.49.mov

ios/Podfile.lock

src/libs/actions/PaymentMethods.ts

src/pages/settings/Subscription/CardAuthenticationModal/types.ts

src/pages/settings/Subscription/CardAuthenticationModal/index.tsx

…t_3ds_flow

waterim · 2024-06-27T11:46:38Z

@Pujan92 because of the merge conflicts the code changed a bit, better to retest it

waterim · 2024-06-27T11:47:44Z

@waterim The modal isn't getting closed after fail/success. I believe the backend needs to send a pusher event with the privateStripeCustomerID status.

Screen.Recording.2024-06-27.at.12.10.49.mov

Yes, Im wondering is this a problem of test mode of stripe or the same will be with live mode too

Pujan92 · 2024-06-27T12:56:50Z

@waterim The modal isn't getting closed after fail/success. I believe the backend needs to send a pusher event with the privateStripeCustomerID status.
Screen.Recording.2024-06-27.at.12.10.49.mov

Yes, Im wondering is this a problem of test mode of stripe or the same will be with live mode too

@blimpich I think someone from backend team helps here to figure this out

Pujan92 · 2024-06-27T13:04:02Z

After merge with main the error isn't shown for the payment card page if api AddPaymentCardGBP gives an error, it seems to be bcoz we are now using onyx addPaymentCardForm for the form but API response merges to addDebitCardForm.

Screen.Recording.2024-06-27.at.18.25.56.mov

Pujan92 · 2024-06-27T13:08:09Z

@waterim Do we still need CardAuthenticationModal implementation for native bcoz now I can see it renders not found?
As per the design doc we don't need to allow Add Payment Card from native, if that is the case then we can remove CardAuthenticationModal native file.

App/src/pages/settings/Subscription/PaymentCard/index.native.tsx

Lines 7 to 13 in 5e464ea

    
           <ScreenWrapper 
        
               testID={AddPaymentCard.displayName} 
        
               includeSafeAreaPaddingBottom 
        
               shouldEnableMaxHeight 
        
           > 
        
               <FullPageNotFoundView shouldShow /> 
        
           </ScreenWrapper>

waterim · 2024-06-27T14:11:20Z

Thats a good question
Thats true that we don't need a screen for native for adding cards, but Im not sure about will we add this in the future and for that I added native code as well
I will ask in the Slack about that

waterim · 2024-06-27T14:15:15Z

The add card page was updated meanwhile in another PR into 2 screens with notFound for native, I think I need to remove my part also

blimpich · 2024-06-27T20:26:57Z

I will look into this.

We need to push privateStripeCustomerID via pusher event, as shown here
We need to make the backend update the correct onyx data as outlined here

Please hold until I can fix this.

blimpich · 2024-06-27T23:01:22Z

Alright this is really hurting my 🧠. The backend code for this is complicated, but I think I've figured out the general issue. We don't seem to be calling User_VerifySetupIntent after the user clicks on "complete" for some reason which is a necessary component of getting the data in the backend to be setup correctly. Looking into why.

blimpich · 2024-06-28T00:26:51Z

Spent most of my day looking into the 1st issue. Didn't succeed. Made a post in #wave-collect here asking for help.

blimpich · 2024-06-28T23:20:26Z

Again threw myself at this problem today, continued asking for help (link), but no solution. Better understanding of the problem, but no solution.

blimpich · 2024-07-02T01:24:48Z

Tried again today, no success. Reached out for help here. This issue is kicking my butt. Will come back again tomorrow with fresh eyes.

…t_3ds_flow

… correct data

waterim · 2024-07-22T17:38:34Z

@blimpich Updated, but can't test it locally because of the stripe test/prod modes

blimpich · 2024-07-22T18:55:36Z

Been talking with @waterim in DM, looks like contributors might not be able to test this due to how our web-secure repository works. Didn't realize the necessary permissions required more than just ngrok. The good news is that I can still test this locally and confirm it.

I told this to @waterim but I'll repeat it here for anyone else following this: we are almost there but we need to add one more parameter to the request we are making for User_VerifySetupIntent. We need to pass isVerifying parameter set to true.

src/pages/settings/Subscription/CardAuthenticationModal/index.tsx

waterim · 2024-07-23T12:03:44Z

@Pujan92 Updated

Pujan92 · 2024-07-23T12:22:18Z

@waterim We need to add a step to choose GBP for the currency in the test steps.

waterim · 2024-07-23T12:23:26Z

Updated!
Thank you

Pujan92

Code looks good to me! @blimpich Can you plz test this on your side as we are unable to receive the message event of 3DS-authentication-complete?

blimpich · 2024-07-23T16:49:55Z

I will test this today 👍

blimpich

It works, lets get this merged!

newDotFlow1.mov

OSBotify · 2024-07-23T18:42:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-25T03:37:50Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2024-07-25T03:47:54Z

@Pujan92 @waterim @blimpich Do we need to QA anything in this PR in Staging?

blimpich · 2024-07-25T16:54:32Z

@mvtglobally I'm not sure if its possible to QA this in staging unless we have a credit card that we can use in staging that will trigger a SCA authentication, which means it would need to be a card that has a default currency of GBP. Do we have that?

kavimuru · 2024-07-25T19:22:43Z

@blimpich We don't have card in GBP in staging with SCA authentication

blimpich · 2024-07-25T20:15:46Z

@kavimuru, okay, in that case please skip this for QA. I'll make a note to try and have us test this internally with a UK employee.

OSBotify · 2024-07-26T05:13:01Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-26T05:36:08Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

DylanDylann · 2024-09-26T18:49:46Z

@Pujan92 In this PR, Is there any reason why we skip testing on mobile?

DylanDylann · 2024-09-26T18:51:29Z

src/pages/settings/Subscription/CardAuthenticationModal/index.tsx

+    useEffect(() => {
+        window.addEventListener('message', handleGBPAuthentication);
+        return () => {
+            window.removeEventListener('message', handleGBPAuthentication);


This change caused this bug

This component we were not rendering for the native, so while testing in mobile it wasn't crash for me.

@Pujan92

This component we were not rendering for the native

Why no? We don't have native.tsx file

Ahh I see. Thanks

My bad 😄

I mean it is from the place where we render this component, in this PR PaymentCard component is responsible for calling this and there we have this platform specific file. And if I remember correctly, in the doc it is mentioned that stripe flow won't be allowed in native.

waterim added 3 commits June 24, 2024 21:45

add gbp auth stripe

d078648

Merge remote-tracking branch 'upstream/main' into feat-42432-Implemen…

a5a8059

…t_3ds_flow

Merge remote-tracking branch 'upstream/main' into feat-42432-Implemen…

9f131d6

…t_3ds_flow

waterim force-pushed the feat-42432-Implement_3ds_flow branch from c6b0072 to 9f131d6 Compare June 25, 2024 15:57

Merge remote-tracking branch 'upstream/main' into feat-42432-Implemen…

29edc5d

…t_3ds_flow

waterim marked this pull request as ready for review June 26, 2024 11:23

waterim requested a review from a team as a code owner June 26, 2024 11:23

melvin-bot bot removed the request for review from a team June 26, 2024 11:23

melvin-bot bot requested a review from Pujan92 June 26, 2024 11:23

Pujan92 suggested changes Jun 27, 2024

View reviewed changes

waterim added 2 commits June 27, 2024 13:38

fixes

3898b2c

Merge remote-tracking branch 'upstream/main' into feat-42432-Implemen…

1cfac81

…t_3ds_flow

waterim added 2 commits June 27, 2024 13:59

fix ts lint

3ca9d86

remove podfile

7bf7f0d

Merge remote-tracking branch 'upstream/main' into feat-42432-Implemen…

be23e36

…t_3ds_flow

update flow with new API call and adjust modal to close after getting…

dc01b39

… correct data

remove getBack

ade7ac2

Pujan92 reviewed Jul 22, 2024

View reviewed changes

src/pages/settings/Subscription/CardAuthenticationModal/index.tsx Outdated Show resolved Hide resolved

waterim added 2 commits July 23, 2024 13:52

add isVerifying param

7e67295

add clean-up for event listener

ee3d7d1

Pujan92 approved these changes Jul 23, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich July 23, 2024 12:25

blimpich approved these changes Jul 23, 2024

View reviewed changes

blimpich merged commit bf770dd into Expensify:main Jul 23, 2024
17 of 18 checks passed

blimpich mentioned this pull request Jul 24, 2024

[$250] [Payment card / Subscription] "Change payment card" button doesn’t work after using 3DS flow to add GBP payment card #46146

Closed

github-actions bot mentioned this pull request Jul 25, 2024

Deploy Checklist: New Expensify 2024-07-25 #46161

Closed

64 tasks

melvin-bot bot mentioned this pull request Jul 26, 2024

[HOLD for payment 2024-08-02] [Payment card / Subscription] Implement 3ds flow (UI) #42432

Closed

blimpich mentioned this pull request Aug 7, 2024

[$250] [Payment card / Subscription] Add SCA support in Transfer Owner flow #42490

Closed

DylanDylann mentioned this pull request Sep 26, 2024

[NO QA] Feature: Implement SCA support to transfer owner #49411

Merged

58 tasks

DylanDylann reviewed Sep 26, 2024

View reviewed changes

Feature: Implement 3ds flow #44321

Feature: Implement 3ds flow #44321

Conversation

waterim commented Jun 24, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 26, 2024

Pujan92 commented Jun 27, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Pujan92 commented Jun 27, 2024 • edited Loading

waterim commented Jun 27, 2024

waterim commented Jun 27, 2024

Pujan92 commented Jun 27, 2024

Pujan92 commented Jun 27, 2024

Pujan92 commented Jun 27, 2024 • edited Loading

waterim commented Jun 27, 2024

waterim commented Jun 27, 2024

blimpich commented Jun 27, 2024

blimpich commented Jun 27, 2024

blimpich commented Jun 28, 2024

blimpich commented Jun 28, 2024

blimpich commented Jul 2, 2024

waterim commented Jul 22, 2024

blimpich commented Jul 22, 2024

waterim commented Jul 23, 2024

Pujan92 commented Jul 23, 2024

waterim commented Jul 23, 2024

Pujan92 left a comment • edited Loading

Choose a reason for hiding this comment

blimpich commented Jul 23, 2024

blimpich left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 23, 2024

OSBotify commented Jul 25, 2024

mvtglobally commented Jul 25, 2024 • edited Loading

blimpich commented Jul 25, 2024

kavimuru commented Jul 25, 2024

blimpich commented Jul 25, 2024

OSBotify commented Jul 26, 2024

OSBotify commented Jul 26, 2024

DylanDylann commented Sep 26, 2024

DylanDylann Sep 26, 2024

Choose a reason for hiding this comment

Pujan92 Sep 26, 2024

Choose a reason for hiding this comment

DylanDylann Sep 26, 2024

Choose a reason for hiding this comment

DylanDylann Sep 26, 2024

Choose a reason for hiding this comment

DylanDylann Sep 26, 2024

Choose a reason for hiding this comment

Pujan92 Sep 26, 2024

Choose a reason for hiding this comment

waterim commented Jun 24, 2024 •

edited

Loading

Pujan92 commented Jun 27, 2024 •

edited

Loading

Pujan92 commented Jun 27, 2024 •

edited

Loading

Pujan92 commented Jun 27, 2024 •

edited

Loading

Pujan92 left a comment •

edited

Loading

mvtglobally commented Jul 25, 2024 •

edited

Loading