-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix concierge page infinite loading #46483
Fix concierge page infinite loading #46483
Conversation
@NJ-2020 please follow the mentioned way to link your issue and proposal
your section should be
|
@NJ-2020 please test all platforms and add videos in Screenshots/Videos section |
@ahmedGaber93 Sorry I do not have any recording video for MacOS, IOS, and Android, because I have a billing issue when trying to purchase Scaleway But I add browser recording in Windows Is that okay? |
Yes, sorry |
@NJ-2020 I hope you solve your problem with them quickly. Do you expect it will be fixed quickly? We can wait a few days |
@ahmedGaber93 I am solving it now and will put you in the loop as soon as I find a way. |
@ahmedGaber93 Sorry, I still have the billing issue because my card can not be used for international payment. Will that be ok? |
@NJ-2020 Bump for this #46483 (comment) Also update your test steps to be more clear - 2. Navigate to Concierge via link
+ 2. Navigate to Concierge via link: DOMAIN_URL/concierge
5. Verify that No Error page is displayed and the app is navigates to concierge page after finishing the onboarding flow |
Reviewer Checklist
Screenshots/VideosAndroid: Nativea.mp4Android: mWeb Chromeaw.mp4iOS: Nativei.mp4iOS: mWeb Safariiw.mp4MacOS: Chrome / Safariw.mp4MacOS: Desktopd.mp4 |
Thanks |
@NJ-2020 Please follow #46483 (comment) when you mention issue and proposal links, this important for automation. If you missed something, please ask me about it. |
@ahmedGaber93 Sorry, updated, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hmm the performance tests aren't passing. |
@madmax330 Done |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.18-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀
|
Details
Fixed Issues
$ #44235
PROPOSAL: #44235 (comment)
Tests
Offline tests
QA Steps
Same as the Tests section
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2024-07-30.17-26-00.mp4
MacOS: Desktop