Chat - File does not appear with strikethrough style when uploaded offline and deleted #47971

Krishna2323 · 2024-08-24T20:48:41Z

Details

Fixed Issues

$ #46616
PROPOSAL: #46616 (comment)

Tests

Go to any chat
Upload a file (format: .txt/.html/.zip/)
Upload image & video
Go offline
Right click on the file
Click Delete comment
Verify an overlay with trash icon is shown for deleted video & image and the filename is crossed for the other file. (format: .txt/.html/.zip/)
Stay offline and repeat step 2 to 7

Verify that no errors appear in the JS console

Offline tests

Go to any chat
Upload a file (format: .txt/.html/.zip/)
Upload image & video
Go offline
Right click on the file
Click Delete comment
Verify an overlay with trash icon is shown for deleted video & image and the filename is crossed for the other file. (format: .txt/.html/.zip/)
Stay offline and repeat step 2 to 7

QA Steps

Go to any chat
Upload a file (format: .txt/.html/.zip/)
Upload image & video
Go offline
Right click on the file
Click Delete comment
Verify an overlay with trash icon is shown for deleted video & image and the filename is crossed for the other file. (format: .txt/.html/.zip/)
Stay offline and repeat step 2 to 7

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Monosnap.screencast.2024-09-04.13-32-54.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.1.mp4

MacOS: Desktop

desktop_app.mp4

…ed offline and deleted. Signed-off-by: krishna2323 <[email protected]>

Signed-off-by: krishna2323 <[email protected]>

melvin-bot · 2024-08-24T20:48:46Z

@dubielzyk-expensify @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: krishna2323 <[email protected]>

dubielzyk-expensify · 2024-08-26T04:12:14Z

Let me know when there's something visual to check out :)

Krishna2323 · 2024-08-27T18:50:47Z

The code changes are done, I will test last time today and upload the screenshots.

Krishna2323 · 2024-08-28T00:02:15Z

@dubielzyk-expensify, please check the recording and let me know if we want some changes.

Monosnap.screencast.2024-08-28.05-29-20.mp4

dubielzyk-expensify · 2024-08-28T02:16:42Z

There seems to be something weird happening when you go into offline mode and it immediately showing this before you've even deleted anything:

The trash icon should only appear when something is deleted in offline mode. Which is does when you do your "Delete comment" action, but before that it shows a double or something?

Otherwise the rest of the recording looks good. cc @Expensify/design

shawnborton · 2024-08-28T11:41:42Z

Yup, I'm also curious about what Jon is mentioning.

dannymcclain · 2024-08-28T13:13:53Z

Same. Other than that weirdness Jon pointed out I think it's looking good.

Krishna2323 · 2024-08-28T15:50:08Z

Thanks for the review, I think that was already deleted action which might have failed that's why it was shown but I will double check that.

Krishna2323 · 2024-08-29T00:57:47Z

@Expensify/design, I apologize for forgetting to show the visuals in light mode 😅. Could you please confirm if the video looks correct in both modes?

Monosnap.screencast.2024-08-29.06-23-50.mp4

dubielzyk-expensify · 2024-08-29T04:20:05Z

Thanks for providing video for light mode 😄

Is the icon using the icon color variable? Cause it looks to be the same icon color as in dark mode which is a darker than we want. In light mode it should appear a bit lighter. But it could be the recording screwing up with me here.

shawnborton · 2024-08-29T11:52:46Z

I think the video might be correct? I think the color for icons is darker in light mode, and lighter in dark mode.

dannymcclain · 2024-08-29T14:03:09Z

Haha, I'm with both of you—the icon color in light mode doesn't quite look right to me 🤨

Here's a Figma screenshot. The icon is just using our standard icons color variable.

Krishna2323 · 2024-08-29T20:13:53Z

Thanks, I will update and provide the result shortly.

Krishna2323 · 2024-09-01T06:29:24Z

@Expensify/design, does this look correct? The color code has been updated to the icon variable, but it will appear lighter than in this design because the report comment has an opacity of .5 when deleted offline. I find it very difficult to maintain the original icon color with the reduced opacity. The only viable solution I can think of is to update the color to a brighter version of the icon variable so that it appears closer to the original even with the reduced opacity.

deleted_indicator_updated_color.mp4

Signed-off-by: krishna2323 <[email protected]>

mananjadhav

Left a few comments.

src/components/HTMLEngineProvider/HTMLRenderers/VideoRenderer.tsx

src/components/ThumbnailImage.tsx

src/components/Attachments/AttachmentView/index.tsx

src/components/Attachments/AttachmentView/DefaultAttachmentView/index.tsx

src/components/VideoPlayerPreview/VideoPlayerThumbnail.tsx

src/styles/index.ts

src/components/AttachmentDeletedIndicator.tsx

mananjadhav · 2024-09-24T21:26:57Z

src/components/AttachmentDeletedIndicator.tsx

+    return (
+        <>
+            <View
+                style={[styles.pAbsolute, styles.alignItemsCenter, styles.justifyContentCenter, styles.highlightBG, styles.deletedIndicatorOverlay, styles.deletedIndicator, containerStyles]}


Still going through these styles.

Signed-off-by: krishna2323 <[email protected]>

neil-marcellini · 2024-09-30T19:56:29Z

@Krishna2323 I think we'll need to fix the eslint issues even if they're unrelated to the PR. It is because we're touching those files and the new lint rules are failing.

@neil-marcellini can you please confirm?

Hi, thanks for asking. The latest I've heard is that if the ES Lint checks are related to files touched in the current PR, then we require them to be fixed before the issue can be considered complete and paid. If the fixes are small then we like to see the changes in the current PR. Otherwise, like in this case where we need to migrate to useOnyx, we should handle it in a separate PR. You could also search to see if there is already an issue to migrate to useOnyx for these files.

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-10-02T01:41:22Z

@mananjadhav, I have fixed other files but I'm no sure what to do with ImageRenderer file since the onyx value is used in the memo.

App/src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.tsx

Lines 117 to 126 in 7dde09e

    
           export default withOnyx<ImageRendererProps, ImageRendererWithOnyxProps>({ 
        
               user: { 
        
                   key: ONYXKEYS.USER, 
        
               }, 
        
           })( 
        
               memo( 
        
                   ImageRenderer, 
        
                   (prevProps, nextProps) => prevProps.tnode.attributes === nextProps.tnode.attributes && prevProps.user?.shouldUseStagingServer === nextProps.user?.shouldUseStagingServer, 
        
               ), 
        
           );

Krishna2323 · 2024-10-03T16:13:41Z

@mananjadhav, friendly bump on the comment above ^

Krishna2323 · 2024-10-07T04:25:33Z

@mananjadhav, any updates?

mananjadhav · 2024-10-07T04:27:44Z

I couldn't check this over the weekend, but I'll try to check today. I think it's best to post on open-source channel to get more eyes.

Krishna2323 · 2024-10-13T16:27:00Z

@mananjadhav, we no longer need to make this change, I guess it has been done somewhere else. You can continue with the checklist.

mananjadhav · 2024-10-14T04:44:24Z

Thanks for the update @Krishna2323. I will check this out today.

mananjadhav · 2024-10-15T17:10:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-delete-attachment.mov

MacOS: Desktop

desktop-delete-attachment.mov

Signed-off-by: krishna2323 <[email protected]>

mananjadhav · 2024-10-21T08:50:29Z

Did the latest review, left with the QA on mobile devices. Will finish the checklist today.

mananjadhav · 2024-10-22T12:14:55Z

@Krishna2323 Can you please fix conflicts? Also there's a recent node and npm change that causes the performance tests to fail.

I am having some trouble with my Xcode, rest screenshots updated.

mananjadhav

I am having issues with iOS so skipping that one. Screenshots for the rest are uploaded and I verified iOS on the author checklist.

neil-marcellini

The code looks fine and looks like it tests well. Thank you for the hard work.

OSBotify · 2024-10-23T17:48:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-25T02:08:05Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-29T09:13:45Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

github-actions · 2024-10-29T11:38:02Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

Krishna2323 added 5 commits August 1, 2024 18:56

fix: Chat - File does not appear with strikethrough style when upload…

24221c7

…ed offline and deleted. Signed-off-by: krishna2323 <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/46616

8bcdcbc

updated design.

05b2f2d

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/46616

ed9a174

add deleted indicator for video renderer.

365fd73

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 requested a review from a team as a code owner August 24, 2024 20:48

melvin-bot bot requested review from dubielzyk-expensify and mananjadhav and removed request for a team August 24, 2024 20:48

Krishna2323 marked this pull request as draft August 24, 2024 20:48

Krishna2323 added 2 commits August 25, 2024 03:02

add styles object for deleted indicator.

98aa154

Signed-off-by: krishna2323 <[email protected]>

add AttachmentDeletedIndicator.tsx

0100314

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'main' into krishna2323/issue/46616

dc8d1ce

Merge branch 'Expensify:main' into krishna2323/issue/46616

1eb1b71

Merge branch 'Expensify:main' into krishna2323/issue/46616

609dd79

fix icon colot.

15353c7

Signed-off-by: krishna2323 <[email protected]>

mananjadhav reviewed Sep 24, 2024

View reviewed changes

Krishna2323 added 2 commits September 27, 2024 05:30

Merge branch 'Expensify:main' into krishna2323/issue/46616

434b6a6

add suggested changes.

6ca5df9

Signed-off-by: krishna2323 <[email protected]>

mananjadhav mentioned this pull request Sep 27, 2024

[HOLD for payment 2024-11-05] [$250] Chat - File does not appear with strikethrough style when uploaded offline and deleted #46616

Closed

6 tasks

Krishna2323 added 2 commits October 2, 2024 06:54

Merge branch 'Expensify:main' into krishna2323/issue/46616

2f60806

fix: lint issues.

d4a068f

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/46616

ff3654b

Merge branch 'main' into krishna2323/issue/46616

2c26757

Krishna2323 added 2 commits October 18, 2024 17:32

Merge branch 'main' into krishna2323/issue/46616

98c927b

fix: lint issues.

a7821d1

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'main' into krishna2323/issue/46616

ec696aa

mananjadhav approved these changes Oct 22, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini October 22, 2024 16:55

neil-marcellini approved these changes Oct 23, 2024

View reviewed changes

neil-marcellini merged commit b8a0202 into Expensify:main Oct 23, 2024
18 checks passed

github-actions bot mentioned this pull request Oct 25, 2024

Deploy Checklist: New Expensify 2024-10-25 #51448

Closed

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chat - File does not appear with strikethrough style when uploaded offline and deleted #47971

Chat - File does not appear with strikethrough style when uploaded offline and deleted #47971

Krishna2323 commented Aug 24, 2024 •

edited

Loading

melvin-bot bot commented Aug 24, 2024

dubielzyk-expensify commented Aug 26, 2024

Krishna2323 commented Aug 27, 2024

Krishna2323 commented Aug 28, 2024

dubielzyk-expensify commented Aug 28, 2024 •

edited

Loading

shawnborton commented Aug 28, 2024

dannymcclain commented Aug 28, 2024

Krishna2323 commented Aug 28, 2024

Krishna2323 commented Aug 29, 2024

dubielzyk-expensify commented Aug 29, 2024 •

edited

Loading

shawnborton commented Aug 29, 2024

dannymcclain commented Aug 29, 2024

Krishna2323 commented Aug 29, 2024

Krishna2323 commented Sep 1, 2024

mananjadhav left a comment

mananjadhav Sep 24, 2024

neil-marcellini commented Sep 30, 2024

Krishna2323 commented Oct 2, 2024

Krishna2323 commented Oct 3, 2024

Krishna2323 commented Oct 7, 2024

mananjadhav commented Oct 7, 2024

Krishna2323 commented Oct 13, 2024

mananjadhav commented Oct 14, 2024

mananjadhav commented Oct 15, 2024 •

edited

Loading

mananjadhav commented Oct 21, 2024

mananjadhav commented Oct 22, 2024

mananjadhav left a comment •

edited

Loading

neil-marcellini left a comment

OSBotify commented Oct 23, 2024

github-actions bot commented Oct 25, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

Chat - File does not appear with strikethrough style when uploaded offline and deleted #47971

Chat - File does not appear with strikethrough style when uploaded offline and deleted #47971

Conversation

Krishna2323 commented Aug 24, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 24, 2024

dubielzyk-expensify commented Aug 26, 2024

Krishna2323 commented Aug 27, 2024

Krishna2323 commented Aug 28, 2024

dubielzyk-expensify commented Aug 28, 2024 • edited Loading

shawnborton commented Aug 28, 2024

dannymcclain commented Aug 28, 2024

Krishna2323 commented Aug 28, 2024

Krishna2323 commented Aug 29, 2024

dubielzyk-expensify commented Aug 29, 2024 • edited Loading

shawnborton commented Aug 29, 2024

dannymcclain commented Aug 29, 2024

Krishna2323 commented Aug 29, 2024

Krishna2323 commented Sep 1, 2024

mananjadhav left a comment

Choose a reason for hiding this comment

mananjadhav Sep 24, 2024

Choose a reason for hiding this comment

neil-marcellini commented Sep 30, 2024

Krishna2323 commented Oct 2, 2024

Krishna2323 commented Oct 3, 2024

Krishna2323 commented Oct 7, 2024

mananjadhav commented Oct 7, 2024

Krishna2323 commented Oct 13, 2024

mananjadhav commented Oct 14, 2024

mananjadhav commented Oct 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Oct 21, 2024

mananjadhav commented Oct 22, 2024

mananjadhav left a comment • edited Loading

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 23, 2024

github-actions bot commented Oct 25, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

Krishna2323 commented Aug 24, 2024 •

edited

Loading

dubielzyk-expensify commented Aug 28, 2024 •

edited

Loading

dubielzyk-expensify commented Aug 29, 2024 •

edited

Loading

mananjadhav commented Oct 15, 2024 •

edited

Loading

mananjadhav left a comment •

edited

Loading