Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to delegate access reauthentication #49375

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Sep 18, 2024

Needs https://github.com/Expensify/Web-Expensify/pull/43646

Details

This PR ensures:

  • You are brought back to the delegate's original account when the delegate token expires after connecting to delegated access.
  • You can reauthenticate with the stored credentials when the normal token expires after disconnecting from delegated access.

Fixed Issues

$ #48750

Tests/QA

Need someone in ring1 around while QAing to manually expire the authTokens

  1. Create two accounts, one main account and one copilot account.
  2. Using the main account, set the copilot as the delegate via OldDot.
  3. Sign into the copilot account and copilot into the main account in NewDot
  4. Expire the delegate token by running the following CQ
REPLACE INTO nameValuePairs (accountID, name, value, created) VALUES (<copilotAccountID>, 'private_minimumAuthTokenIssueTime', strftime('%s', 'now', 'utc') || '000000', Date('now'));
  1. Try to open a report.
  2. You should automatically get switched back to the delegate's original account. The profile UI should show the delegate's original account.
  3. Expire the normal token by running the following CQ
REPLACE INTO nameValuePairs (accountID, name, value, created) VALUES (<mainAccountID>, 'private_minimumAuthTokenIssueTime', strftime('%s', 'now', 'utc') || '000000', Date('now'));
  1. Try to open a report.
  2. You should be able to successfully the open the report and you shouldn't face any permissions errors.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-09-23.at.11.32.13.AM.mov
MacOS: Desktop

@jasperhuangg jasperhuangg self-assigned this Sep 18, 2024
@jasperhuangg jasperhuangg marked this pull request as ready for review September 18, 2024 10:17
@jasperhuangg jasperhuangg requested a review from a team as a code owner September 18, 2024 10:17
@melvin-bot melvin-bot bot requested review from eVoloshchak and removed request for a team September 18, 2024 10:17
Copy link

melvin-bot bot commented Sep 18, 2024

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jasperhuangg jasperhuangg requested review from dangrous and a team September 18, 2024 10:17
Copy link

melvin-bot bot commented Sep 18, 2024

@parasharrajat @puneetlath One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team September 18, 2024 10:17
@jasperhuangg jasperhuangg changed the title Ensure we don't clear the credentials when connecting/disconnecting delegates [HOLD Web-Expensify#43584] Ensure we don't clear the credentials when connecting/disconnecting delegates Sep 19, 2024
@jasperhuangg jasperhuangg added the InternalQA This pull request required internal QA label Sep 19, 2024
@jasperhuangg
Copy link
Contributor Author

jasperhuangg commented Sep 19, 2024

Marking this as InternalQA so that whoever QAs this doesn't need to wait 2 hours for an authToken to expire manually. More instructions on how to expire the authToken via CQ are provided in the QA steps.

dangrous
dangrous previously approved these changes Sep 19, 2024
Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work for me! @jasperhuangg I reached out separately with a question about related behavior though

puneetlath
puneetlath previously approved these changes Sep 19, 2024
@jasperhuangg
Copy link
Contributor Author

@dangrous and I are discussing the other issues via DM. They could potentially affect the solution presented in this PR so I'm going to hold off on merging this for the time being.

@jasperhuangg jasperhuangg changed the title [HOLD Web-Expensify#43584] Ensure we don't clear the credentials when connecting/disconnecting delegates [HOLD Web-Expensify#43584] Ensure can can successfully reauthenticate with credentials after delegated access Sep 20, 2024
@jasperhuangg jasperhuangg dismissed stale reviews from puneetlath and dangrous via 220645c September 23, 2024 17:00
@jasperhuangg jasperhuangg changed the title [HOLD Web-Expensify#43584] Ensure can can successfully reauthenticate with credentials after delegated access [HOLD Web-Expensify#43646] Ensure can can successfully reauthenticate with credentials after delegated access Sep 23, 2024
@jasperhuangg jasperhuangg changed the title [HOLD Web-Expensify#43646] Ensure can can successfully reauthenticate with credentials after delegated access [HOLD Web-Expensify#43646] Ensure we can successfully reauthenticate with credentials after delegated access Sep 23, 2024
@jasperhuangg jasperhuangg changed the title [HOLD Web-Expensify#43646] Ensure we can successfully reauthenticate with credentials after delegated access [HOLD Web-Expensify#43646] Fixes to delegate access reauthentication Sep 23, 2024
@jasperhuangg
Copy link
Contributor Author

@dangrous Addressed the bug. It seems we were clearing out the isSidebarLoaded key in Onyx when using delegate access. This was preventing the report screen from appearing as loaded.

It should be fine to preserve that key because we never unrender the sidebar.

Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeeee - this works well for me!

@jasperhuangg jasperhuangg removed the request for review from parasharrajat September 26, 2024 22:31
@jasperhuangg
Copy link
Contributor Author

Unassigned @parasharrajat since we only need one C+ here and @eVoloshchak was auto-assigned first

@jasperhuangg
Copy link
Contributor Author

This is ready for review!

@jasperhuangg
Copy link
Contributor Author

@eVoloshchak @puneetlath Friendly bump on this review!

@eVoloshchak
Copy link
Contributor

eVoloshchak commented Oct 1, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@eVoloshchak
Copy link
Contributor

@jasperhuangg, is there a way for C+ to do this?

Expire the delegate token by running the following CQ

 REPLACE INTO nameValuePairs (accountID, name, value, created) VALUES (<copilotAccountID>, 'private_minimumAuthTokenIssueTime', strftime('%s', 'now', 'utc') || '000000', Date('now'));`

@dangrous
Copy link
Contributor

dangrous commented Oct 1, 2024

No unfortunately it's not - @jasperhuangg or @puneetlath are you ring1? Can you help out with testing? If not, I think we're probably fine just having our internal review here...

@jasperhuangg
Copy link
Contributor Author

@dangrous Sadly no, my thinking with this QA was that the QAer could find someone in #engineering-chat by mentioning @Ring1 and walking through the QA steps together.

Agree, I think we should be fine to QA this on staging.

@jasperhuangg
Copy link
Contributor Author

I went ahead and merged https://github.com/Expensify/Web-Expensify/pull/43646 since it seems like we're not going to be making any other changes there.

@dangrous
Copy link
Contributor

dangrous commented Oct 2, 2024

So I think we're just waiting for a look from @puneetlath here?

@jasperhuangg
Copy link
Contributor Author

Yes, @puneetlath and @eVoloshchak please review!

@jasperhuangg
Copy link
Contributor Author

Puneet is OOO, @dangrous do you mind finishing the checklist?

@dangrous
Copy link
Contributor

dangrous commented Oct 4, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me! I've filled out the checklist, I'll let you do the honors

@jasperhuangg jasperhuangg changed the title [HOLD Web-Expensify#43646] Fixes to delegate access reauthentication Fixes to delegate access reauthentication Oct 4, 2024
@jasperhuangg jasperhuangg merged commit c986119 into main Oct 4, 2024
17 of 19 checks passed
@jasperhuangg jasperhuangg deleted the jasper-fixDelegateDisconnectReauth branch October 4, 2024 20:32
Copy link
Contributor

github-actions bot commented Oct 4, 2024

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.45-1 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@jasperhuangg
Copy link
Contributor Author

jasperhuangg commented Oct 7, 2024

The main account's ID is 18444945
The copilot account's ID is 18444957

REPLACE INTO nameValuePairs (accountID, name, value, created) VALUES (18444945, 'private_minimumAuthTokenIssueTime', '1728338742000000', '2024-10-07');
REPLACE INTO nameValuePairs (accountID, name, value, created) VALUES (18444957, 'private_minimumAuthTokenIssueTime', '1728338742000000', '2024-10-07');

@iwiznia
Copy link
Contributor

iwiznia commented Oct 7, 2024

👍

@iwiznia
Copy link
Contributor

iwiznia commented Oct 7, 2024

Done

[email protected]:~$ expensify_cqHelper.sh
This script is not a replacement for buddychecks
Pro-tip: did you remember to run a SELECT to estimate how long your query will take?
Using host: db1.sjc
WARNING: Skipping smokealarm initialization because we're in an interactive terminal
password:
query: REPLACE INTO nameValuePairs (accountID, name, value, created) VALUES (18444945, 'private_minimumAuthTokenIssueTime', '1728338742000000', '2024-10-07');
reason: https://github.com/Expensify/App/pull/49375

CustomQuery
query: REPLACE INTO nameValuePairs (accountID, name, value, created) VALUES (18444945, 'private_minimumAuthTokenIssueTime', '1728338742000000', '2024-10-07');
password: XXXXXXXX
reason: https://github.com/Expensify/App/pull/49375
connection: close
Execute? (ctrl-c to cancel)
200 OK
commitCount: 25125451734
Connection: close
nodeName: auth.db1.sjc
peekTime: 15
processTime: 278
requestID: QxSUx6
totalTime: 939
unaccountedTime: 250
Content-Length: 2

{}query: REPLACE INTO nameValuePairs (accountID, name, value, created) VALUES (18444957, 'private_minimumAuthTokenIssueTime', '1728338742000000', '2024-10-07');
reason: https://github.com/Expensify/App/pull/49375

CustomQuery
query: REPLACE INTO nameValuePairs (accountID, name, value, created) VALUES (18444957, 'private_minimumAuthTokenIssueTime', '1728338742000000', '2024-10-07');
password: XXXXXXXX
reason: https://github.com/Expensify/App/pull/49375
connection: close
Execute? (ctrl-c to cancel)
200 OK
commitCount: 25125453767
Connection: close
nodeName: auth.db1.sjc
peekTime: 26
processTime: 327
requestID: Q9CUTG
totalTime: 869
unaccountedTime: 139
Content-Length: 2

@jasperhuangg
Copy link
Contributor Author

This passed QA!

Copy link
Contributor

github-actions bot commented Oct 7, 2024

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.45-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
InternalQA This pull request required internal QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants