[HOLD #51296] [Unit & UI Tests]: add unit test for automatically approved expense #51330

allgandalf · 2024-10-23T12:27:57Z

Details

Fixed Issues

$ #50351
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allgandalf · 2024-10-23T13:17:30Z

package.json

@@ -33,6 +33,7 @@
    "ios-build": "bundle exec fastlane ios build_unsigned",
    "android-build": "bundle exec fastlane android build_local",
    "test": "TZ=utc NODE_OPTIONS=--experimental-vm-modules jest",
+    "test:unit": "TZ=utc NODE_OPTIONS=--experimental-vm-modules jest tests/unit/ReportUtilsTest.ts",


@Beamanator please ignore this, i have used this temporarily just to not use up all the memory testing all files 😅

haha yeah that's useful, you'll remove before we merge, eh? :D

lol, for sure !

melvin-bot · 2024-10-23T13:17:44Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-10-23T13:18:06Z

@shubham1206agra ignore the ping for now, idk if this would need a C+ review or not

Beamanator

So far so good! I have only 2 little comments so far.

But one thing we wanted to test is: UI tests rendering <ReportActionItem> using @testing-library/react-native. Can you please add a few of those as well?

Beamanator · 2024-10-24T14:27:10Z

package.json

@@ -33,6 +33,7 @@
    "ios-build": "bundle exec fastlane ios build_unsigned",
    "android-build": "bundle exec fastlane android build_local",
    "test": "TZ=utc NODE_OPTIONS=--experimental-vm-modules jest",
+    "test:unit": "TZ=utc NODE_OPTIONS=--experimental-vm-modules jest tests/unit/ReportUtilsTest.ts",


haha yeah that's useful, you'll remove before we merge, eh? :D

Beamanator · 2024-10-24T14:28:40Z

tests/unit/ReportUtilsTest.ts

+    describe('Automatically approved report message via automatic (not by a human) action is', () => {
+        test('Automatically Approved Report message when report is forwarded (Control feature)', () => {


I think we can clean up these names a bit - I believe ideally it reads almost like a sentence, starting with the describe text, followed by the test itself - you can see how in other places (like just above) we have describe('ParentReportAction is') + test('Manually Submitted Report Action')

cool cool, I'll update in the next commit

allgandalf · 2024-10-24T14:52:12Z

But one thing we wanted to test is: UI tests rendering using @testing-library/react-native. Can you please add a few of those as well?

On my todo list, UI tests are new for me. Getting my head around that screen rendering. I should have those tests updated soon. thanks for the review

allgandalf · 2024-11-13T08:45:43Z

sorry this slipped through the cracks, Working on this one now

update: Still getting through here

allgandalf added 4 commits October 23, 2024 17:56

add unit test for automatically approved expense

02316f3

Merge branch 'Expensify:main' into issue50351

358b107

add unit test

7270293

add more test cases and fix test params

7d7df77

allgandalf commented Oct 23, 2024

View reviewed changes

allgandalf marked this pull request as ready for review October 23, 2024 13:17

allgandalf requested a review from a team as a code owner October 23, 2024 13:17

melvin-bot bot requested review from shubham1206agra and removed request for a team October 23, 2024 13:17

allgandalf mentioned this pull request Oct 23, 2024

[hold for #51296] Write unit tests for updated ReportActionItem text depending on given originalMessage data #50351

Open

add new test case for approved automaticAction

f333ee5

allgandalf changed the title ~~[Unit Tests]: add unit test for automatically approved expense~~ [Unit & UI Tests]: add unit test for automatically approved expense Oct 23, 2024

Beamanator requested review from Beamanator and removed request for shubham1206agra October 23, 2024 14:37

Beamanator requested changes Oct 24, 2024

View reviewed changes

Merge branch 'main' into issue50351

242427d

allgandalf changed the title ~~[Unit & UI Tests]: add unit test for automatically approved expense~~ [HOLD #51296] [Unit & UI Tests]: add unit test for automatically approved expense Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD #51296] [Unit & UI Tests]: add unit test for automatically approved expense #51330

[HOLD #51296] [Unit & UI Tests]: add unit test for automatically approved expense #51330

allgandalf commented Oct 23, 2024

allgandalf Oct 23, 2024

Beamanator Oct 24, 2024

allgandalf Oct 24, 2024

melvin-bot bot commented Oct 23, 2024

allgandalf commented Oct 23, 2024

Beamanator left a comment

Beamanator Oct 24, 2024

Beamanator Oct 24, 2024

allgandalf Oct 24, 2024

allgandalf commented Oct 24, 2024

allgandalf commented Nov 13, 2024 •

edited

Loading

		describe('Automatically approved report message via automatic (not by a human) action is', () => {
		test('Automatically Approved Report message when report is forwarded (Control feature)', () => {

[HOLD #51296] [Unit & UI Tests]: add unit test for automatically approved expense #51330

Are you sure you want to change the base?

[HOLD #51296] [Unit & UI Tests]: add unit test for automatically approved expense #51330

Conversation

allgandalf commented Oct 23, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

allgandalf Oct 23, 2024

Choose a reason for hiding this comment

Beamanator Oct 24, 2024

Choose a reason for hiding this comment

allgandalf Oct 24, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Oct 23, 2024

allgandalf commented Oct 23, 2024

Beamanator left a comment

Choose a reason for hiding this comment

Beamanator Oct 24, 2024

Choose a reason for hiding this comment

Beamanator Oct 24, 2024

Choose a reason for hiding this comment

allgandalf Oct 24, 2024

Choose a reason for hiding this comment

allgandalf commented Oct 24, 2024

allgandalf commented Nov 13, 2024 • edited Loading

allgandalf commented Nov 13, 2024 •

edited

Loading