Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] e2e: unify test metrics naming #51338

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[NoQA] e2e: unify test metrics naming #51338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/libs/E2E/tests/appStartTimeTest.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
import Config from 'react-native-config';
import type {NativeConfig} from 'react-native-config';
import type {PerformanceEntry} from 'react-native-performance';
import E2ELogin from '@libs/E2E/actions/e2eLogin';
import waitForAppLoaded from '@libs/E2E/actions/waitForAppLoaded';
import E2EClient from '@libs/E2E/client';
import getConfigValueOrThrow from '@libs/E2E/utils/getConfigValueOrThrow';
import Performance from '@libs/Performance';

const test = () => {
const test = (config: NativeConfig) => {
const name = getConfigValueOrThrow('name', config);
// check for login (if already logged in the action will simply resolve)
E2ELogin().then((neededLogin) => {
if (neededLogin) {
Expand All @@ -25,7 +28,7 @@ const test = () => {
metrics.map((metric) =>
E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
name: `App start ${metric.name}`,
name: `${name} ${metric.name}`,
metric: metric.duration,
unit: 'ms',
}),
Expand Down
5 changes: 3 additions & 2 deletions src/libs/E2E/tests/chatOpeningTest.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const test = (config: NativeConfig) => {
console.debug('[E2E] Logging in for chat opening');

const reportID = getConfigValueOrThrow('reportID', config);
const name = getConfigValueOrThrow('name', config);

E2ELogin().then((neededLogin) => {
if (neededLogin) {
Expand Down Expand Up @@ -48,7 +49,7 @@ const test = (config: NativeConfig) => {
if (entry.name === CONST.TIMING.CHAT_RENDER) {
E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
name: 'Chat opening',
name: `${name} Chat opening`,
metric: entry.duration,
unit: 'ms',
})
Expand All @@ -64,7 +65,7 @@ const test = (config: NativeConfig) => {
if (entry.name === CONST.TIMING.OPEN_REPORT) {
E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
name: 'Chat TTI',
name: `${name} Chat TTI`,
metric: entry.duration,
unit: 'ms',
})
Expand Down
3 changes: 2 additions & 1 deletion src/libs/E2E/tests/linkingTest.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const test = (config: NativeConfig) => {
const reportID = getConfigValueOrThrow('reportID', config);
const linkedReportID = getConfigValueOrThrow('linkedReportID', config);
const linkedReportActionID = getConfigValueOrThrow('linkedReportActionID', config);
const name = getConfigValueOrThrow('name', config);

E2ELogin().then((neededLogin) => {
if (neededLogin) {
Expand Down Expand Up @@ -74,7 +75,7 @@ const test = (config: NativeConfig) => {

E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
name: 'Comment linking',
name,
metric: entry.duration,
unit: 'ms',
});
Expand Down
14 changes: 9 additions & 5 deletions src/libs/E2E/tests/openSearchRouterTest.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
import Config from 'react-native-config';
import type {NativeConfig} from 'react-native-config';
import * as E2EGenericPressableWrapper from '@components/Pressable/GenericPressable/index.e2e';
import E2ELogin from '@libs/E2E/actions/e2eLogin';
import waitForAppLoaded from '@libs/E2E/actions/waitForAppLoaded';
import E2EClient from '@libs/E2E/client';
import getConfigValueOrThrow from '@libs/E2E/utils/getConfigValueOrThrow';
import getPromiseWithResolve from '@libs/E2E/utils/getPromiseWithResolve';
import Performance from '@libs/Performance';
import CONST from '@src/CONST';

const test = () => {
const test = (config: NativeConfig) => {
// check for login (if already logged in the action will simply resolve)
console.debug('[E2E] Logging in for new search router');

const name = getConfigValueOrThrow('name', config);

E2ELogin().then((neededLogin: boolean): Promise<Response> | undefined => {
if (neededLogin) {
return waitForAppLoaded().then(() =>
Expand Down Expand Up @@ -39,7 +43,7 @@ const test = () => {
E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
error: 'Search button not found',
name: 'Open Search Router TTI',
name: `${name} Open Search Router TTI`,
}).then(() => E2EClient.submitTestDone());
return;
}
Expand All @@ -48,7 +52,7 @@ const test = () => {
E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
error: 'Search button found but onPress prop was not present',
name: 'Open Search Router TTI',
name: `${name} Open Search Router TTI`,
}).then(() => E2EClient.submitTestDone());
return;
}
Expand All @@ -59,7 +63,7 @@ const test = () => {
if (entry.name === CONST.TIMING.SEARCH_ROUTER_RENDER) {
E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
name: 'Open Search Router TTI',
name: `${name} Open Search Router TTI`,
metric: entry.duration,
unit: 'ms',
})
Expand All @@ -75,7 +79,7 @@ const test = () => {
if (entry.name === CONST.TIMING.LOAD_SEARCH_OPTIONS) {
E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
name: 'Load Search Options',
name: `${name} Load Search Options`,
metric: entry.duration,
unit: 'ms',
})
Expand Down
5 changes: 3 additions & 2 deletions src/libs/E2E/tests/reportTypingTest.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const test = (config: NativeConfig) => {

const reportID = getConfigValueOrThrow('reportID', config);
const message = getConfigValueOrThrow('message', config);
const name = getConfigValueOrThrow('name', config);

E2ELogin().then((neededLogin) => {
if (neededLogin) {
Expand All @@ -45,7 +46,7 @@ const test = (config: NativeConfig) => {
if (entry.name === CONST.TIMING.MESSAGE_SENT) {
E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
name: 'Message sent',
name: `${name} Message sent`,
metric: entry.duration,
unit: 'ms',
}).then(messageSentResolve);
Expand Down Expand Up @@ -77,7 +78,7 @@ const test = (config: NativeConfig) => {

E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
name: 'Composer typing rerender count',
name: `${name} Composer typing rerender count`,
metric: rerenderCount,
unit: 'renders',
})
Expand Down
Loading