-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure the first result in most recents is highlighted when user uses CMD+K #52298
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
de6e681
Make sure the first result in most recents is highlighted when user u…
nyomanjyotisa ac997b5
lint fix
nyomanjyotisa 1007716
initial focus only for web and desktop, and don't scroll on initial f…
nyomanjyotisa f03e1e0
minor fix
nyomanjyotisa dd17a40
minor fix
nyomanjyotisa fe78ba6
minor fix
nyomanjyotisa b86b260
Render SearchRouterList in SearchRouter component only after fetching…
nyomanjyotisa 2312a87
dont scroll to focused index in initial render search router list
nyomanjyotisa fd76ed7
minor fix
nyomanjyotisa e502f95
minor fix
nyomanjyotisa d3778db
Merge branch 'main' into issue-51894
nyomanjyotisa 913a059
minor fix
nyomanjyotisa e9bea23
minor fix
nyomanjyotisa a9ab802
lint fix
nyomanjyotisa 7861d45
minor fix
nyomanjyotisa e4e2ab1
lint fix
nyomanjyotisa ef484ce
minor fix
nyomanjyotisa 4457266
Merge branch 'main' into issue-51894
nyomanjyotisa ee1acd6
minor fix
nyomanjyotisa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: I think we don't need
contextualReportID
condition here bcoz currently also that condition truthy for any value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a NAB? We should never merge code like this @Pujan92 😒
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be NAB, my bad 😢