-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Initial setup for LHN tests #52452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the tracking issue and found that this PR doesn't require C+ review, so just approve it to push it forward for internal review. :)
cc @mountiny
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think it would be great to standardize on the comments and make sure all the tests are clearly described, but make sure the comments explain why something is happening/ why we doing it and not what we are doing
39d0036
to
114e455
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OlimpiaZurek great, can you please just update with the empty lines?
// When the SidebarLinks are rendered without a specified report ID. | ||
LHNTestUtils.getDefaultRenderedSidebarLinks(); | ||
const report = createReport(); | ||
// And the Onyx state is initialized with a report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: for style guide and readability we should leave empty line above the comments
// And the Onyx state is initialized with a report. | |
// And the Onyx state is initialized with a report. |
tests/ui/LHNItemsPresence.tsx
Outdated
}); | ||
// Then the report should not appear in the sidebar as it is not pinned. | ||
expect(getOptionRows()).toHaveLength(0); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here I think we do not need the space as there is no comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer, thanks!
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.63-1 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.63-3 🚀
|
Explanation of Change
This PR adds the basic setup for LHN tests, with a few utility functions and some existing mocks that we can reuse. I noticed there were some broken and skipped LHN tests in the code. A few of these tests are still useful, so I’ve included them here, but most were outdated and not needed.
Fixed Issues
$ #52036
PROPOSAL:
Tests
N/A
Offline tests
N/A
QA Steps
N/A
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop