Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal QA]: Show card name instead of Bank for Company cards search #52625

Merged
merged 3 commits into from
Nov 19, 2024
Merged

[Internal QA]: Show card name instead of Bank for Company cards search #52625

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ce633a
Show card name instead of Bank for Company cards search
narefyev91 Nov 15, 2024
2d805db
line
narefyev91 Nov 15, 2024
a0ec0c4
update after c+ review
narefyev91 Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import type {CategorySection} from '@libs/OptionsListUtils';
import type {OptionData} from '@libs/ReportUtils';
import Navigation from '@navigation/Navigation';
import * as SearchActions from '@userActions/Search';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';

Expand All @@ -36,7 +37,7 @@ function SearchFiltersCardPage() {
return {
lastFourPAN: card.lastFourPAN,
isVirtual: card?.nameValuePairs?.isVirtual,
text: card.bank,
text: card.bank === CONST.EXPENSIFY_CARD.BANK ? card.bank : card?.nameValuePairs?.cardTitle ?? card?.cardName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB, but i feel we should define a variable cardName and move this logic there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allgandalf updated!

keyForList: card.cardID.toString(),
isSelected: newCards.includes(card.cardID.toString()),
bankIcon: icon,
Expand Down
Loading