-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct bottom padding on edit approval workflow #53570
fix: correct bottom padding on edit approval workflow #53570
Conversation
I’ll start the checklist within an hour |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-04.at.23.48.30.movAndroid: mWeb ChromeScreen.Recording.2024-12-04.at.23.49.41.moviOS: NativeScreen.Recording.2024-12-04.at.23.52.01.moviOS: mWeb SafariScreen.Recording.2024-12-04.at.23.51.26.movMacOS: Chrome / SafariScreen.Recording.2024-12-04.at.23.52.52.movMacOS: DesktopScreen.Recording.2024-12-04.at.23.51.02.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix: correct bottom padding on edit approval workflow (cherry picked from commit bfce334) (CP triggered by puneetlath)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.0.71-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Explanation of Change
Added safe bottom padding via
includeSafeAreaPaddingBottom
property.Fixed Issues
$ #53522
PROPOSAL: N/A
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop