Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <emoji> is mistaken as <em> #760

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix <emoji> is mistaken as <em> #760

merged 1 commit into from
Jul 26, 2024

Conversation

gijoe0295
Copy link
Contributor

@gijoe0295 gijoe0295 commented Jul 22, 2024 •
edited
Loading

Fixed Issues

$ Expensify/App#45635
$ PROPOSAL: Expensify/App#45635 (comment)

Tests

  1. Send this message:
~👿~ _abc_
  1. Edit the message
  2. Verify the message in edit composer matches the original message in step 1
  3. Open workspace room
  4. Change room description to the message in step 1 and save
  5. Open room description page again
  6. Verify the room description matches the original description in step 1

Screenshots/Videos

Android: Native

Screenshot_1721871271

Android: mWeb Chrome

Screenshot_1721871353

iOS: Native
iOS: mWeb Safari

simulator_screenshot_BD4A70AE-D1FA-43FA-BA23-BD5044CA7E90

MacOS: Chrome / Safari

Screenshot 2024-07-25 at 08 32 54

Screenshot 2024-07-25 at 08 42 30

MacOS: Desktop

Screenshot 2024-07-25 at 08 37 08

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@gijoe0295
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@gijoe0295 gijoe0295 mentioned this pull request Jul 22, 2024
Closed
6 tasks
@gijoe0295 gijoe0295 marked this pull request as ready for review July 25, 2024 01:37
@gijoe0295 gijoe0295 requested a review from a team as a code owner July 25, 2024 01:37
@gijoe0295 gijoe0295 changed the title [WIP] Fix <emoji> is mistaken as <em> Fix <emoji> is mistaken as <em> Jul 25, 2024
@melvin-bot melvin-bot bot requested review from neil-marcellini and removed request for a team July 25, 2024 01:38
@gijoe0295
Copy link
Contributor Author

@parasharrajat This one can be review now.

@parasharrajat
Copy link
Member

@neil-marcellini Please trigger workflows

parasharrajat
parasharrajat approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

🎀 👀 🎀 C+ reviewed

neil-marcellini
neil-marcellini approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks! @cristipaval is managing the issue so I'll request his review too.

@cristipaval cristipaval merged commit 4cc5e30 into Expensify:main Jul 26, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

🚀Published to npm in v2.0.56

@gijoe0295 gijoe0295 mentioned this pull request Jul 26, 2024
Merged
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neil-marcellini neil-marcellini neil-marcellini approved these changes

@parasharrajat parasharrajat parasharrajat approved these changes

@cristipaval cristipaval cristipaval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gijoe0295 @parasharrajat @cristipaval @neil-marcellini