Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: find the caret domrect with largest bottom value #454

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

dominictb
Copy link
Contributor

Details

Related Issues

$ Expensify/App#46389
PROPOSAL: Expensify/App#46389 (comment)

Manual Tests

  1. Add overflow and maxHeight attribute in: https://github.com/Expensify/react-native-live-markdown/blob/main/example/src/App.tsx#L190-L196
  2. Run example web app
  3. Insert multiple-line text until a scroll bar is shown on the right
  4. On a new line insert a markdown text (eg. bold)
  5. Hit the enter key on the keyboard

Verify that: the text input should scroll automatically down to reveal the new line.

Linked PRs

BartoszGrajdek
BartoszGrajdek previously approved these changes Aug 19, 2024
Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! I will test it tomorrow 👀

Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment

src/web/cursorUtils.ts Outdated Show resolved Hide resolved
@BartoszGrajdek
Copy link
Collaborator

Tested, it's working well ✅

Please follow the suggestion above so we can merge this 🙌🏻

@dominictb
Copy link
Contributor Author

done!

@Skalakid Skalakid merged commit 2cc529f into Expensify:main Aug 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants