Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: find the caret domrect with largest bottom value #454

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: find the caret domrect with largest bottom value #454

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a68bd4
fix: find the caret domrect with largest bottom value
dominictb Aug 19, 2024
dd9e1f0
fix: update comment
dominictb Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/web/cursorUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,19 @@ function scrollCursorIntoView(target: HTMLInputElement) {
return;
}

const caretRect = selection.getRangeAt(0).getClientRects()[0];
const caretRects = selection.getRangeAt(0).getClientRects();

// we'll find the caretRect from the DOMRectList above with the largest bottom value
let caretRect = caretRects[0];
if (caretRect) {
for (let i = 1; i < caretRects.length; i++) {
const ithCaretRect = caretRects[i];
if (ithCaretRect && ithCaretRect.bottom > caretRect.bottom) {
caretRect = ithCaretRect;
}
}
}
dominictb marked this conversation as resolved.
Show resolved Hide resolved

const editableRect = target.getBoundingClientRect();

// Adjust for padding and border
Expand Down
Loading