Support custom font family for codeblocks and inline code on Android #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertKozik
approved these changes
Jan 18, 2024
tomekzaw
commented
Jan 18, 2024
Comment on lines
-7
to
-9
| public class MarkdownFontFamilySpan extends TypefaceSpan implements MarkdownSpan { | ||
| public MarkdownFontFamilySpan(@NonNull String fontFamily) { | ||
| super(fontFamily); |
There was a problem hiding this comment.
TypefaceSpan does not support custom fonts added by React Native so we need to come up with our own solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR changes the implementation of
MarkdownFontFamilySpanso that it supports custom fonts on Android.Related Issues
GH_LINK
Manual Tests
Linked PRs