Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event targets returned by paste eventListeners #178

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Feb 9, 2024

Details

This PR fixes the problem with different event targets depending on markdown input content.

Related Issues

#177

Manual Tests

After adding document.addEventListener('paste', yourFunction); check if event.target is always equal to MarkdownTextInput ref.

Linked PRs

Expensify/App#36269

@Skalakid Skalakid changed the title add event wrapper that sets event target to contentEditable div Fix event targets returned by paste eventListeners Feb 9, 2024
@Skalakid Skalakid requested a review from robertKozik February 9, 2024 15:40
@robertKozik
Copy link
Collaborator

Fixes Expensify/App#36269

@Skalakid Skalakid merged commit 870e2f6 into main Feb 14, 2024
2 checks passed
@Skalakid Skalakid deleted the @Skalakid/fix-paste-event-target branch February 14, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants