Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pod-install script #299

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Remove pod-install script #299

merged 1 commit into from
Apr 12, 2024

Conversation

tomekzaw
Copy link
Collaborator

@tomekzaw tomekzaw commented Apr 12, 2024

Details

This PR gets rid of pod-install script that automatically installed Pods for iOS when running yarn to install node_modules.

The reason is that pod install is generally slow and we don't want to run it each time we re-install node_modules.

Also, the recommended usage is bundler install && bundler exec pod install.

Related Issues

GH_LINK

Manual Tests

Linked PRs

@tomekzaw tomekzaw requested a review from BartoszGrajdek April 12, 2024 10:21
Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! 👀

@tomekzaw tomekzaw merged commit 4919dac into main Apr 12, 2024
5 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/remove-pod-install branch April 12, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants