[Mentions v2] Add support for <mention-report /> tag #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Apr 15, 2024
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
|
please upgrade screenshot in PR description as well |
robertKozik
force-pushed
the
room-mentions
branch
from
96d0323 to
c1a2cb8
Compare
|
Are this jobs stuck or is that normal? |
|
It takes lot of time 😅 I'll proceed with merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR is part of Mentions v2 design doc. It adds support for new kind of mention: room mention which is described with
<mention-report />HTML tag. This mention should be styled the same as user mentionRelated Issues
Expensify/App#39542
Manual Tests
Type room mention (starts with
#followed by any combination of small letters, numbers and hyphens ) and verify that