-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors when compiling with Swift file on iOS lower than 14 #315
Conversation
@staszekscp Could you please check if this change works correctly with static/dynamic linking in the hybrid app? |
@@ -30,6 +30,5 @@ Pod::Spec.new do |s| | |||
s.subspec "common" do |ss| | |||
ss.source_files = "cpp/**/*.{cpp,h}" | |||
ss.header_dir = "RNLiveMarkdown" | |||
ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/cpp\"" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you've checked, but just to make sure: this doesn't break the new arch build, right?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! @staszekscp confirms it works for him as well.
Details
If a Swift file was added to the project with podspec target set to iOS 13 and lower, the app wouldn't compile and would throw
file not found
errors.