Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web implementation #32

Merged
merged 12 commits into from
Feb 7, 2024
Merged

Add web implementation #32

merged 12 commits into from
Feb 7, 2024

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Dec 13, 2023 •
edited by tomekzaw
Loading

No description provided.

@Skalakid Skalakid requested review from tomekzaw and BartoszGrajdek and removed request for tomekzaw and BartoszGrajdek December 15, 2023 12:17
BartoszGrajdek
BartoszGrajdek reviewed Dec 17, 2023
View reviewed changes
src/web/parserUtils.ts Outdated Show resolved Hide resolved
src/web/parserUtils.ts Outdated Show resolved Hide resolved
src/web/parserUtils.ts Outdated Show resolved Hide resolved
src/web/cursorUtils.ts Outdated Show resolved Hide resolved
src/web/cursorUtils.ts Outdated Show resolved Hide resolved
src/web/cursorUtils.ts Outdated Show resolved Hide resolved
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
tomekzaw
tomekzaw reviewed Dec 18, 2023
View reviewed changes
example/ios/Podfile.lock Outdated Show resolved Hide resolved
parser/index.js Outdated Show resolved Hide resolved
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
BartoszGrajdek
BartoszGrajdek reviewed Dec 18, 2023
View reviewed changes
types/global.d.ts Outdated Show resolved Hide resolved
tomekzaw
tomekzaw reviewed Dec 18, 2023
View reviewed changes
src/web/cursorUtils.ts Outdated Show resolved Hide resolved
@tomekzaw tomekzaw self-requested a review December 19, 2023 16:47
tomekzaw
tomekzaw reviewed Dec 20, 2023
View reviewed changes
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
src/web/cursorUtils.ts Outdated Show resolved Hide resolved
@Skalakid
Copy link
Collaborator Author

TODO:

  • fix invisible <br> inside empty text input. When you enter some text with new lines and then delete all text with backspace, the content editable will have <br> inside but div will look like its empty
Screen.Recording.2023-12-28.at.10.57.12.mov
  • add web implementation to Expensify NewDot app. Current problem is that some event listeners are setting wrong cursor position and replace text every time key is down. Also when you stop writing after 1 second one character will be added to the textinput for no reason
Screen.Recording.2023-12-28.at.10.59.39.mov

@Skalakid Skalakid requested a review from tomekzaw January 19, 2024 16:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@robertKozik robertKozik mentioned this pull request Feb 2, 2024
Closed
@tomekzaw
Copy link
Collaborator

tomekzaw commented Feb 2, 2024

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@Skalakid
Copy link
Collaborator Author

Skalakid commented Feb 2, 2024

I have read the CLA Document and I hereby sign the CLA

tomekzaw
tomekzaw requested changes Feb 2, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
parser/index.ts Outdated Show resolved Hide resolved
parser/index.ts Outdated Show resolved Hide resolved
src/MarkdownTextInputDecoratorViewNativeComponent.ts Outdated Show resolved Hide resolved
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
src/styleUtils.ts Show resolved Hide resolved
src/styleUtils.ts Outdated Show resolved Hide resolved
@Skalakid Skalakid requested a review from tomekzaw February 5, 2024 10:07
tomekzaw
tomekzaw reviewed Feb 5, 2024
View reviewed changes
src/__tests__/index.test.tsx Outdated Show resolved Hide resolved
src/styleUtils.ts Outdated Show resolved Hide resolved
src/web/historyClass.ts Outdated Show resolved Hide resolved
src/web/historyClass.ts Outdated Show resolved Hide resolved
src/web/historyClass.ts Outdated Show resolved Hide resolved
src/web/historyClass.ts Outdated Show resolved Hide resolved
tomekzaw
tomekzaw previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Skalakid @robertKozik Congratulations on this PR! 🥳

@tomekzaw tomekzaw dismissed their stale review February 5, 2024 15:34

The merge-base changed after approval.

tomekzaw
tomekzaw previously approved these changes Feb 5, 2024
View reviewed changes
@tomekzaw tomekzaw merged commit b6c1fb0 into main Feb 7, 2024
2 checks passed
@tomekzaw tomekzaw deleted the @Skalakid/web branch February 7, 2024 21:49
@danieldoglas danieldoglas mentioned this pull request Feb 8, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertKozik robertKozik robertKozik left review comments

@BartoszGrajdek BartoszGrajdek BartoszGrajdek left review comments

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Skalakid @tomekzaw @BartoszGrajdek @robertKozik