Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emoji vertical alignment #395

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

BartoszGrajdek
Copy link
Collaborator

Details

This PR changes the positioning of cursor next to an enlarged emoji so that it's in the middle vertically.

Related Issues

GH_LINK
Expensify/App#40692

Manual Tests

  1. Change fontSize for emoji in StyleUtils.ts.
  2. Check how cursor behaves next to text
image

Linked PRs

N/A

@BartoszGrajdek BartoszGrajdek changed the title feat: fix vertical alignment of cursor next to emoji Fix emoji vertical alignment Jun 20, 2024
Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roryabraham
Copy link
Contributor

Oooh big green button. Looks like I have write access in here so I'm going to click the big green button 😈

@roryabraham roryabraham merged commit 60554fe into main Jun 21, 2024
5 checks passed
@roryabraham roryabraham deleted the @BartoszGrajdek/cursor-vertical-alignment branch June 21, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants