Use Hermes instead of JSC on iOS #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertKozik
previously approved these changes
Jan 3, 2024
|
TODO: apply changes from #103 |
6 tasks
Skalakid
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
LGTM, I tested iOS and performance seems good to me. Also, all markdown styles work fine.
The only thing is that I can see some warnings in couple of unchanged files, like:
ios/RCTUITextView+Markdown.mm
undeclared selector 'updateLocalData' [-Wundeclared-selector]
Is it related to your changes?
|
Closing this PR in favor of #400 due to unsigned commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #400.
Previously, we would use built-in JSC (JavaScriptCore) on iOS and Hermes on Android for running the JS parser.
This PR migrates iOS to use Hermes instead of JSC in order to align the iOS implementation with Android.