Support node@14, and pull in #209, #245, and #255 #323

randytarampi · 2020-04-29T05:52:41Z

This builds on the work in #317 and https://github.com/mixer/lwip/releases/tag/v1.0.3, and is released under https://www.npmjs.com/package/@randy.tarampi/lwip.

This should also close #209, close #245, and close #255.

There's a whole host of changes here – notable ones called out in the CHANGELOG – some of which are breaking for the current state of the module, but who's using node<8 these days anyways?

coveralls · 2020-04-29T17:54:40Z

Coverage increased (+1.1%) to 99.429% when pulling b1f9f87 on randytarampi:master into a559d24 on EyalAr:master.

codecov-io · 2020-05-07T20:51:47Z

Codecov Report

Merging #323 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files           5        5           
  Lines         525      525           
=======================================
  Hits          522      522           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888bccb...888bccb. Read the comment docs.

codecov-commenter · 2020-05-24T19:52:13Z

Codecov Report

❗ No coverage uploaded for pull request base (master@a559d24). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #323   +/-   ##
=========================================
  Coverage          ?   99.42%           
=========================================
  Files             ?        5           
  Lines             ?      525           
  Branches          ?        0           
=========================================
  Hits              ?      522           
  Misses            ?        3           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a559d24...8a18e40. Read the comment docs.

Snyk has created this PR to upgrade eslint from 7.10.0 to 7.11.0. See this package in npm: https://www.npmjs.com/package/eslint See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

Snyk has created this PR to upgrade semantic-release from 17.1.2 to 17.2.1. See this package in npm: https://www.npmjs.com/package/semantic-release See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

Snyk has created this PR to upgrade nan from 2.14.1 to 2.14.2. See this package in npm: https://www.npmjs.com/package/nan See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-FLAT-596927

Snyk has created this PR to upgrade mocha from 8.1.3 to 8.2.0. See this package in npm: https://www.npmjs.com/package/mocha See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…db64933b15258 [Snyk] Security upgrade mocha from 8.1.3 to 8.2.0

…bbfe97a91c18f6476 [Snyk] Upgrade mocha from 8.1.3 to 8.2.0

…f8b4b952611c9bc15 [Snyk] Upgrade nan from 2.14.1 to 2.14.2

…ce9aeab98ba41c982 [Snyk] Upgrade semantic-release from 17.1.2 to 17.2.1

…dc50611715386e458 [Snyk] Upgrade eslint from 7.10.0 to 7.11.0

codecov-io · 2020-10-18T21:18:26Z

Codecov Report

❗ No coverage uploaded for pull request base (master@a559d24). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #323   +/-   ##
=========================================
  Coverage          ?   99.42%           
=========================================
  Files             ?        5           
  Lines             ?      525           
  Branches          ?        0           
=========================================
  Hits              ?      522           
  Misses            ?        3           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a559d24...cea7d33. Read the comment docs.

…7e6537c5feb599dce [Snyk] Upgrade snyk from 1.405.1 to 1.406.0

I mean, the cloud service is scanning the GitHub repos anyways, so there's no need to run this locally right? Or am I getting this switch the other way around...? 🤔

Snyk has created this PR to upgrade snyk from 1.406.0 to 1.414.1. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…7cb3241a73dcc5ee7 [Snyk] Upgrade snyk from 1.406.0 to 1.414.1

[skip ci] ## [3.0.12](v3.0.11...v3.0.12) (2020-10-18) ### Bug Fixes * package.json & package-lock.json to reduce vulnerabilities ([bd42ca9](bd42ca9)) * upgrade eslint from 7.10.0 to 7.11.0 ([8f72cff](8f72cff)) * upgrade mocha from 8.1.3 to 8.2.0 ([9fbeaf2](9fbeaf2)) * upgrade nan from 2.14.1 to 2.14.2 ([9b8adc2](9b8adc2)) * upgrade semantic-release from 17.1.2 to 17.2.1 ([f812b98](f812b98)) * upgrade snyk from 1.405.1 to 1.406.0 ([74324ce](74324ce)) * upgrade snyk from 1.406.0 to 1.414.1 ([8b54df3](8b54df3))

Snyk has created this PR to upgrade snyk from 1.414.1 to 1.415.0. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…cd1b1e19103f0d93b [Snyk] Upgrade snyk from 1.414.1 to 1.415.0

[skip ci] ## [3.0.13](v3.0.12...v3.0.13) (2020-10-20) ### Bug Fixes * upgrade snyk from 1.414.1 to 1.415.0 ([296608b](296608b))

Snyk has created this PR to upgrade snyk from 1.415.0 to 1.416.0. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…bd4912b093b60fce9 [Snyk] Upgrade snyk from 1.415.0 to 1.416.0

[skip ci] ## [3.0.14](v3.0.13...v3.0.14) (2020-10-21) ### Bug Fixes * upgrade snyk from 1.415.0 to 1.416.0 ([c48a917](c48a917))

Snyk has created this PR to upgrade snyk from 1.416.0 to 1.419.0. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

Snyk has created this PR to upgrade run-script-os from 1.1.1 to 1.1.3. See this package in npm: https://www.npmjs.com/package/run-script-os See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

Snyk has created this PR to upgrade eslint from 7.11.0 to 7.12.0. See this package in npm: https://www.npmjs.com/package/eslint See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

Snyk has created this PR to upgrade semantic-release from 17.2.1 to 17.2.2. See this package in npm: https://www.npmjs.com/package/semantic-release See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…65c2867ee95ebb0e80 [Snyk] Upgrade eslint from 7.26.0 to 7.27.0

…83d23fafae6433ae9c [Snyk] Upgrade eslint-plugin-import from 2.23.2 to 2.23.3

…e1de0000cb2ef61bab [Snyk] Upgrade snyk from 1.604.0 to 1.605.0

Snyk has created this PR to upgrade snyk from 1.605.0 to 1.616.0. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…5c5c01cfa8df10d919 [Snyk] Upgrade snyk from 1.605.0 to 1.616.0

Snyk has created this PR to upgrade snyk from 1.616.0 to 1.618.0. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

Snyk has created this PR to upgrade eslint-plugin-import from 2.23.3 to 2.23.4. See this package in npm: https://www.npmjs.com/package/eslint-plugin-import See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…17678d760afe59661f [Snyk] Upgrade eslint-plugin-import from 2.23.3 to 2.23.4

…26271034e8daee7103 [Snyk] Upgrade snyk from 1.616.0 to 1.618.0

Snyk has created this PR to upgrade snyk from 1.618.0 to 1.620.0. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…c546840c3ed8255ad2 [Snyk] Upgrade snyk from 1.618.0 to 1.620.0

Snyk has created this PR to upgrade snyk from 1.620.0 to 1.621.0. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…b767a7b51de72c4c4f [Snyk] Upgrade snyk from 1.620.0 to 1.621.0

Snyk has created this PR to upgrade eslint from 7.27.0 to 7.28.0. See this package in npm: https://www.npmjs.com/package/eslint See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

Snyk has created this PR to upgrade snyk from 1.621.0 to 1.622.0. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…53efe9025e96918238 [Snyk] Upgrade eslint from 7.27.0 to 7.28.0

…6ba008ad1dc2e4bfe1 [Snyk] Upgrade snyk from 1.621.0 to 1.622.0

Snyk has created this PR to upgrade snyk from 1.622.0 to 1.623.0. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…12af6f0ae679403b96 [Snyk] Upgrade snyk from 1.622.0 to 1.623.0

Snyk has created this PR to upgrade snyk from 1.623.0 to 1.624.0. See this package in npm: https://www.npmjs.com/package/snyk See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…87fe6369494e4276f1 [Snyk] Upgrade snyk from 1.623.0 to 1.624.0

Snyk has created this PR to upgrade coveralls from 3.1.0 to 3.1.1. See this package in npm: https://www.npmjs.com/package/coveralls See this project in Snyk: https://app.snyk.io/org/randytarampi/project/c1a13acc-9a11-409f-81a5-90f6de868dda?utm_source=github&utm_medium=upgrade-pr

…7ce6893ade7da5d87e [Snyk] Upgrade coveralls from 3.1.0 to 3.1.1

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-JSZIP-1251497

…e4365ff4f553f7 [Snyk] Security upgrade snyk from 1.624.0 to 1.667.0

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SSH2-1656673

…dca5acb4bc8885 [Snyk] Security upgrade snyk from 1.667.0 to 1.685.0

caitp · 2022-03-29T16:06:32Z

src/encoder/encoder.h

@@ -126,6 +128,6 @@ NAN_METHOD(encodeToGifBuffer);
 void pngWriteCB(png_structp png_ptr, png_bytep data, png_size_t length);
 int gifWriteCB(GifFileType * gif, const GifByteType * chunk, int len);
 void remapTransparentPixels(unsigned char * target, const unsigned char * map, size_t width, size_t height, int transColor, int threshold);
-void initAll(Handle<Object> exports);
+void initAll(v8::Local<v8::Object> exports);


Not an owner for this project or anything, but I'd personally appreciate it if we removed the using namespace <v8, node, etc>; statements above and make API namespaces explicit everywhere in the module, as is done here.

👍

Handle had been deprecated for years, so replacing it with Local just makes sense

caitp

v8 API changes and library updates and abi compat abstractions look good to me.

Ultimately I'm more worried about the upstream port being usable again, so I'm not too concerned with these extra changes and would take it either way --- but IME, it's generally better for a project to add changes in decisive, purpose-driven or goal-oriented chunks, as it helps with things like codereview, finding the source of regressions or bugs, etc.

It isn't obvious from the github diff what is changing with the changed images. Are these binary changes required for tests to pass? It would be worth documenting this or else removing them from the diff

caitp · 2022-03-29T16:24:51Z

lib/Batch.js


-    function Batch(image) {
+const path = require('path'),


I would try to avoid substantial refactoring like this in a change titled "support node@14", personally

caitp · 2022-03-29T16:27:09Z

tests/01.getters/index.js

@@ -1,70 +1,69 @@
-var join = require('path').join,
-    assert = require('assert'),
+const assert = require('assert'),


many small refactorings in tests like this (var->lexical declarations, function expressions -> arrow functions, etc) can also be a challenge to review and might be better left to a followup

caitp · 2022-03-29T16:42:23Z

.editorconfig

@@ -0,0 +1,35 @@
+# EditorConfig is awesome: http://EditorConfig.org


love editorconfig, not sure it fits with an ABI compat patch, personally. I'd take this in a separate PR

caitp · 2022-03-29T16:42:38Z

.eslintignore

@@ -0,0 +1,6 @@
+node_modules


caitp · 2022-03-29T16:42:48Z

.eslintrc.yaml

@@ -0,0 +1,33 @@
+extends:


caitp · 2022-03-29T16:43:17Z

.gitignore

@@ -1,6 +1,55 @@
-build


I'd avoid reordering this to stuff to keep the diff/blame easier to follow

caitp · 2022-03-29T16:45:02Z

.nycrc

@@ -0,0 +1,39 @@
+{


love code coverage, do we need to add it in this PR? I'd probably add this in a separate PR before this tbh

caitp · 2022-03-29T16:47:42Z

CPPLINT.cfg

@@ -0,0 +1,3 @@
+verbose = 5


caitp · 2022-03-29T16:49:27Z

README.md

 # Light-weight image processor for NodeJS

-[![Join the chat at https://gitter.im/EyalAr/lwip](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/EyalAr/lwip?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+[![npm versions](https://img.shields.io/npm/v/@randy.tarampi/lwip.svg?style=flat-square)](https://www.npmjs.org/package/@randy.tarampi/lwip)


probably this stuff should point to the upstream version (speaking of, probably don't include downstream fork package renaming in the pull request for the upstream version). If it were up to me, I'd add these changes in separate PRs introducing these extras

caitp · 2022-03-29T16:52:09Z

README.md

+[![Install @randy.tarampi/lwip](https://nodeico.herokuapp.com/@randy.tarampi/lwip.svg)](https://www.npmjs.com/package/@randy.tarampi/lwip)
+
+
+This is a branch based off of [@kant2002/lwip](https://www.npmjs.com/package/@kant2002/lwip) and [@mcph/lwip](https://www.npmjs.com/package/@mcph/lwip), customized for my own use.


It's worth crediting the original authors, but being an upstream branch, maybe "customized for my own use" stands out as strange

snyk-bot and others added 10 commits October 10, 2020 21:30

fix: package.json & package-lock.json to reduce vulnerabilities

bd42ca9

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-FLAT-596927

Merge pull request #67 from randytarampi/snyk-fix-7f3b177f322f79dacf4…

b9f79c6

…db64933b15258 [Snyk] Security upgrade mocha from 8.1.3 to 8.2.0

Merge pull request #68 from randytarampi/snyk-upgrade-fb32c45547d0e56…

2530581

…bbfe97a91c18f6476 [Snyk] Upgrade mocha from 8.1.3 to 8.2.0

Merge pull request #66 from randytarampi/snyk-upgrade-9093314b5d0e795…

30ff037

…f8b4b952611c9bc15 [Snyk] Upgrade nan from 2.14.1 to 2.14.2

Merge pull request #65 from randytarampi/snyk-upgrade-ef0e13b6c43d95e…

9c4d5ea

…ce9aeab98ba41c982 [Snyk] Upgrade semantic-release from 17.1.2 to 17.2.1

Merge pull request #64 from randytarampi/snyk-upgrade-51183bb7b0fe78d…

7e15562

…dc50611715386e458 [Snyk] Upgrade eslint from 7.10.0 to 7.11.0

randytarampi and others added 16 commits October 18, 2020 23:18

Merge branch 'master' into snyk-upgrade-06652a5bf7620847e6537c5feb599dce

36624ef

Merge pull request #63 from randytarampi/snyk-upgrade-06652a5bf762084…

ae038bf

…7e6537c5feb599dce [Snyk] Upgrade snyk from 1.405.1 to 1.406.0

chore(package): Set snyk: false.

39f9343

I mean, the cloud service is scanning the GitHub repos anyways, so there's no need to run this locally right? Or am I getting this switch the other way around...? 🤔

Merge pull request #69 from randytarampi/snyk-upgrade-711e685a2057683…

04c143a

…7cb3241a73dcc5ee7 [Snyk] Upgrade snyk from 1.406.0 to 1.414.1

Merge pull request #70 from randytarampi/snyk-upgrade-52f6e8e14cd132b…

3848ee5

…cd1b1e19103f0d93b [Snyk] Upgrade snyk from 1.414.1 to 1.415.0

release(travis): Release 3.0.13

0d00cfc

[skip ci] ## [3.0.13](v3.0.12...v3.0.13) (2020-10-20) ### Bug Fixes * upgrade snyk from 1.414.1 to 1.415.0 ([296608b](296608b))

Merge pull request #71 from randytarampi/snyk-upgrade-8d934f11a2e0ed4…

4dbcc17

…bd4912b093b60fce9 [Snyk] Upgrade snyk from 1.415.0 to 1.416.0

release(travis): Release 3.0.14

02e43d0

[skip ci] ## [3.0.14](v3.0.13...v3.0.14) (2020-10-21) ### Bug Fixes * upgrade snyk from 1.415.0 to 1.416.0 ([c48a917](c48a917))

randytarampi and others added 28 commits May 28, 2021 12:22

Merge pull request #173 from randytarampi/snyk-upgrade-3b468dea311a10…

398a5ca

…65c2867ee95ebb0e80 [Snyk] Upgrade eslint from 7.26.0 to 7.27.0

Merge branch 'master' into snyk-upgrade-7dfc2e9146a6a783d23fafae6433ae9c

0c15261

Merge pull request #172 from randytarampi/snyk-upgrade-7dfc2e9146a6a7…

b435f60

…83d23fafae6433ae9c [Snyk] Upgrade eslint-plugin-import from 2.23.2 to 2.23.3

Merge pull request #171 from randytarampi/snyk-upgrade-d589bc43267d21…

b77dd8a

…e1de0000cb2ef61bab [Snyk] Upgrade snyk from 1.604.0 to 1.605.0

Merge pull request #174 from randytarampi/snyk-upgrade-a12c134f6a57e7…

be75db5

…5c5c01cfa8df10d919 [Snyk] Upgrade snyk from 1.605.0 to 1.616.0

Merge pull request #176 from randytarampi/snyk-upgrade-086ae2718fac89…

23c81fa

…17678d760afe59661f [Snyk] Upgrade eslint-plugin-import from 2.23.3 to 2.23.4

Merge pull request #175 from randytarampi/snyk-upgrade-b18c1f803f37e2…

9de22aa

…26271034e8daee7103 [Snyk] Upgrade snyk from 1.616.0 to 1.618.0

Merge pull request #177 from randytarampi/snyk-upgrade-d8af2979b1c0bf…

98af52f

…c546840c3ed8255ad2 [Snyk] Upgrade snyk from 1.618.0 to 1.620.0

Merge pull request #178 from randytarampi/snyk-upgrade-a53744e8133794…

01f9a41

…b767a7b51de72c4c4f [Snyk] Upgrade snyk from 1.620.0 to 1.621.0

Merge pull request #179 from randytarampi/snyk-upgrade-e2927d3e8aafe1…

6927487

…53efe9025e96918238 [Snyk] Upgrade eslint from 7.27.0 to 7.28.0

Merge pull request #180 from randytarampi/snyk-upgrade-d792a0ed08f664…

4369a1c

…6ba008ad1dc2e4bfe1 [Snyk] Upgrade snyk from 1.621.0 to 1.622.0

Merge pull request #181 from randytarampi/snyk-upgrade-04a6f06ad190d1…

0bf37c9

…12af6f0ae679403b96 [Snyk] Upgrade snyk from 1.622.0 to 1.623.0

Merge pull request #182 from randytarampi/snyk-upgrade-3b2541195c8f01…

b1f9f87

…87fe6369494e4276f1 [Snyk] Upgrade snyk from 1.623.0 to 1.624.0

Merge pull request #186 from randytarampi/snyk-upgrade-76eb0a0d919057…

de7a90a

…7ce6893ade7da5d87e [Snyk] Upgrade coveralls from 3.1.0 to 3.1.1

fix: package.json & package-lock.json to reduce vulnerabilities

504a0db

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-JSZIP-1251497

Merge pull request #187 from randytarampi/snyk-fix-cb9c9357f710be3a71…

764c53c

…e4365ff4f553f7 [Snyk] Security upgrade snyk from 1.624.0 to 1.667.0

fix: package.json & package-lock.json to reduce vulnerabilities

8cdc4ea

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SSH2-1656673

Merge pull request #191 from randytarampi/snyk-fix-34ed01e6d8ebd0a886…

5cef435

…dca5acb4bc8885 [Snyk] Security upgrade snyk from 1.667.0 to 1.685.0

caitp reviewed Mar 29, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support node@14, and pull in #209, #245, and #255 #323

Support node@14, and pull in #209, #245, and #255 #323

randytarampi commented Apr 29, 2020 •

edited

Loading

coveralls commented Apr 29, 2020 •

edited

Loading

codecov-io commented May 7, 2020 •

edited

Loading

codecov-commenter commented May 24, 2020 •

edited

Loading

codecov-io commented Oct 18, 2020 •

edited

Loading

caitp Mar 29, 2022 •

edited

Loading

caitp left a comment

caitp Mar 29, 2022

caitp Mar 29, 2022

caitp Mar 29, 2022

caitp Mar 29, 2022

caitp Mar 29, 2022

caitp Mar 29, 2022

caitp Mar 29, 2022

caitp Mar 29, 2022

caitp Mar 29, 2022

caitp Mar 29, 2022

		@@ -0,0 +1,35 @@
		# EditorConfig is awesome: http://EditorConfig.org

		[![Install @randy.tarampi/lwip](https://nodeico.herokuapp.com/@randy.tarampi/lwip.svg)](https://www.npmjs.com/package/@randy.tarampi/lwip)


		This is a branch based off of [@kant2002/lwip](https://www.npmjs.com/package/@kant2002/lwip) and [@mcph/lwip](https://www.npmjs.com/package/@mcph/lwip), customized for my own use.

Support node@14, and pull in #209, #245, and #255 #323

Are you sure you want to change the base?

Support node@14, and pull in #209, #245, and #255 #323

Conversation

randytarampi commented Apr 29, 2020 • edited Loading

coveralls commented Apr 29, 2020 • edited Loading

codecov-io commented May 7, 2020 • edited Loading

Codecov Report

codecov-commenter commented May 24, 2020 • edited Loading

Codecov Report

codecov-io commented Oct 18, 2020 • edited Loading

Codecov Report

caitp Mar 29, 2022 • edited Loading

Choose a reason for hiding this comment

caitp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

randytarampi commented Apr 29, 2020 •

edited

Loading

coveralls commented Apr 29, 2020 •

edited

Loading

codecov-io commented May 7, 2020 •

edited

Loading

codecov-commenter commented May 24, 2020 •

edited

Loading

codecov-io commented Oct 18, 2020 •

edited

Loading

caitp Mar 29, 2022 •

edited

Loading