Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yoti to project - relates to issue #2 #10

Merged
merged 3 commits into from
Feb 8, 2017
Merged

Add yoti to project - relates to issue #2 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54353c6
Create home page
RhodesPeter Feb 8, 2017
47ad303
Add inline QR code, relates to issue #2
RhodesPeter Feb 8, 2017
47e8613
Add keys file to project, relates to issue #2
RhodesPeter Feb 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ pids
*.pid
*.seed

*.pem

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

Expand Down
10 changes: 10 additions & 0 deletions public/confirmation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title></title>
</head>
<body>

</body>
</html>
25 changes: 25 additions & 0 deletions public/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1">
<script src="https://sdk.yoti.com/clients/browser.js"></script>
<title>Scout membership validation</title>
</head>
<body>
<h1>home page!</h1>
<span class="" data-target='embed'
data-yoti-application-id='0b9cd4fa-9a44-41cb-b78f-f3be16a3daa8'
data-yoti-type="inline"
data-yoti-scenario-id="7aa7dd7f-c73c-4384-8af7-14906d71a5f2"
data-size="small"
>Sign up with Yoti</span>

<script>
_ybg.config.service = 'https://code.yoti.com/app/'
_ybg.init()
</script>

</body>
</html>
11 changes: 0 additions & 11 deletions public/static.html
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions src/handlers/home.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
const homeHandler = (request, reply) => {
return reply(
`<h1>Hello world</h1><a href="static.html">go to a static page</a>`
);
return reply.file("home.html");
};

const homeRoute = {
Expand Down
2 changes: 1 addition & 1 deletion src/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ server.register([Inert], (err) => { // We register extra modules like inert here
server.route(routes); // Plug the routes we imported earlier into the server
});

module.exports = server;
module.exports = server;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like whitespace that has been caught by an automatic linter. Ideally you wouldn't have this showing up as a change to your code in this pull request (since there's no actual change to this file).

Can I suggest that either both of you turn the automtic linting on, or both of you turn this off? Otherwise one person's automatic linting will catch things that the other person has missed 👍