Add confirmation route and handler, relates to issue #11 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsms90
reviewed
Feb 8, 2017
src/handlers/confirmation.js
Outdated
| }) | ||
| }; | ||
|
|
||
| const confirmationRoute = { |
There was a problem hiding this comment.
@RhodesPeter Do you want to be defining your routes inside a folder called "handlers"?
|
I have changed the file name from handlers to routes @jsms90. |
|
Sorry I accidentally closed the PR. Ready to merge now :) |
|
@RhodesPeter Cool. You may want to separate your routes and handlers later. Modularisation is just an architectural choice (as far as I know). Just wanted to highlight it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added the file confirmation.js which relates to issue #11