Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeType.update stac_dist/city_features_collection/city_features_collection.json #267

Merged
merged 11 commits into from
Jul 4, 2024

Conversation

fairicube-data
Copy link
Collaborator

{"filename": "city_features_collection/city_features_collection.json", "item_type": "stac_dist", "change_type": "Update", "user": "FAiRICUBE", "data_owner": true}

@KathiSchleidt KathiSchleidt requested a review from mari-s4e July 4, 2024 08:23
@KathiSchleidt
Copy link
Member

Just scanned this PR out of curiosity, worried in 2 aspects:

  • envelope/bbox seems way larger than the data, just covers EU, but specifies
    • "x" "extent": [-61.119105,55.5130685]
    • "y" "extent": [-21.3035115,65.564344]
  • This is a vector dataset (GeoJSON), but we have bands described. Is the plan to try and describe vector datasets using grid concepts?

@mari-s4e
Copy link
Contributor

mari-s4e commented Jul 4, 2024

Hi Kathi, thank you for looking into this!

envelope/bbox seems way larger than the data, just covers EU, but specifies..

double checked the extent, it is correct. Post colonialism has far reaching consequences ;)

This is a vector dataset (GeoJSON), but we have bands described. Is the plan to try and describe vector datasets using grid concepts?

I would rather not, but right now the band field in the catalog editor is mandatory, so I added I couple of bands to get past the validation test

@mari-s4e mari-s4e merged commit 6009c0b into main Jul 4, 2024
2 checks passed
@mari-s4e
Copy link
Contributor

mari-s4e commented Jul 4, 2024

@eox-cs1 , @baloola this data-request is merged, but it does not show up in the data-access catalog. Why?

@baloola
Copy link
Member

baloola commented Jul 4, 2024

Thanks @mari-s4e I'll give it a look

@baloola
Copy link
Member

baloola commented Jul 4, 2024

@mari-s4e I see that the start date is not before end date.

"start_datetime": "2024-04-18T00:00Z",
"end_datetime": "2018-12-31T00:00Z",

If this is the case I can manually change that ( if you confirm I will do it )

(plus I'll edit the validation script to check that)

@mari-s4e
Copy link
Contributor

mari-s4e commented Jul 4, 2024

Thanks for spotting the error. Start date should be 2018-01-01. If you update the validation script, please update the editor UI too! I had to submit the data request five times before catching all mandatory fields, because they are not signalled in the UI.

@baloola
Copy link
Member

baloola commented Jul 4, 2024

Yes, I'm working on adding some validation message ( for values that will fail the test but can be submitted ), sorry for the delay

@baloola baloola deleted the stac-dist-city-features-collec branch July 4, 2024 12:43
@baloola
Copy link
Member

baloola commented Jul 4, 2024

@mari-s4e
Copy link
Contributor

mari-s4e commented Jul 4, 2024

Thank you Mussab! How does it work now if I need to edit the metadata? Can I do it through the editor?

@baloola
Copy link
Member

baloola commented Jul 4, 2024

Once you merge the PR, it is no longer possible to edit items via the editor, that is why we ask not to merge PRs except when all the parties involved agree (Data provider, Project lead, CU).
That's been said, I can manually re-create(not revert) the PR again if you want to (but it will not be appearing on the catalog)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants