-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChangeType.update stac_dist/city_features_collection/city_features_collection.json #267
Conversation
…for pull request submission
…for pull request submission
…for pull request submission
Just scanned this PR out of curiosity, worried in 2 aspects:
|
…for pull request submission
…for pull request submission
…for pull request submission
…for pull request submission
Hi Kathi, thank you for looking into this!
double checked the extent, it is correct. Post colonialism has far reaching consequences ;)
I would rather not, but right now the band field in the catalog editor is mandatory, so I added I couple of bands to get past the validation test |
Thanks @mari-s4e I'll give it a look |
@mari-s4e I see that the start date is not before end date. "start_datetime": "2024-04-18T00:00Z",
"end_datetime": "2018-12-31T00:00Z", If this is the case I can manually change that ( if you confirm I will do it ) (plus I'll edit the validation script to check that) |
Thanks for spotting the error. Start date should be 2018-01-01. If you update the validation script, please update the editor UI too! I had to submit the data request five times before catching all mandatory fields, because they are not signalled in the UI. |
Yes, I'm working on adding some validation message ( for values that will fail the test but can be submitted ), sorry for the delay |
Thank you Mussab! How does it work now if I need to edit the metadata? Can I do it through the editor? |
Once you merge the PR, it is no longer possible to edit items via the editor, that is why we ask not to merge PRs except when all the parties involved agree (Data provider, Project lead, CU). |
{"filename": "city_features_collection/city_features_collection.json", "item_type": "stac_dist", "change_type": "Update", "user": "FAiRICUBE", "data_owner": true}