Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stac_dist/corine_land_cover/corine_land_cover.json-2 #280

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

baloola
Copy link
Member

@baloola baloola commented Jun 15, 2024

No description provided.

@misev
Copy link
Contributor

misev commented Jul 10, 2024

I have the same issue with updating the catalog entry for corine_land_cover as before with LGN: clicking Submit doesn't do anything.

@baloola
Copy link
Member Author

baloola commented Jul 10, 2024

I'll invistigate

@baloola
Copy link
Member Author

baloola commented Jul 10, 2024

I couldn't reproduce the issue, probably an issue caused by a value in the submitted form, our monitoring system needs a little bit of work, once I get the logs from the backend I'll get more insights about the error.

@misev
Copy link
Contributor

misev commented Jul 10, 2024

I saved my input in case you want to try with replicating it: catalog-editor.eoxhub.fairicube.eu.zip

@baloola baloola requested review from eox-cs1 and misev July 10, 2024 22:02
@baloola
Copy link
Member Author

baloola commented Jul 11, 2024

Thanks @misev, could you try again ?

@misev
Copy link
Contributor

misev commented Jul 11, 2024

@KathiSchleidt please check this metadata merge PR.

In addition I think the following people should check as well:

@misev
Copy link
Contributor

misev commented Jul 11, 2024

@KathiSchleidt The data request table in D5.1 looks a bit different from the priorities indicated in the catalog data request, I'm not sure which one is authoritative for requesting UC partner reviews?

Screenshot_20240711_120121

@Susannaioni
Copy link

In addition I think the following people should check as well:

@misev yes, UC5 had priority 1 under Corine land cover

@KathiSchleidt
Copy link
Member

@misev yes, there's a bit of confusion around the UC as NHM ended up doing 2 use cases, both UC3 & UC5 are NHM, whereby UC5 emerged late. In addition, a LOT went wrong with the Inventory Sheet over the last 2 years, UC4 (NILU) is the one UC I'm sure will NOT use CLC!

On use_case_NHM, to my memory both NHM UC will probably use CLC
use_case_NHM: @sonjastndl
use_case_NHM_2: @Susannaioni

I've added the known suspects as reviewers.

In addition, I noticed a discrepancy between the temporal information in the CLC Coverage vs. the metadata (once more thanks for digging into the available metadata on this, identifying the correct temporal intervals!), in the md record, we still have:

"time": {
"extent": [],
"type": "temporal",
"values": [
  "1990-01-01T00:00Z",
  "2000-01-01T00:00Z",
  "2006-01-01T00:00Z",
  "2012-01-01T00:00Z",
  "2018-01-01T00:00Z"
], ...

Please align!

@misev
Copy link
Contributor

misev commented Jul 15, 2024

In addition, I noticed a discrepancy between the temporal information in the CLC Coverage vs. the metadata

The catalog editor allows to only enter single time points for irregular axis. Not sure how should I indicate the intervals for each slice?

Screenshot_20240715_132746

Copy link

@robknapen robknapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. I still think the interpretation of the temporal dimension is a bit artificial, especially compared to the spatial dimensions. But probably the best possible solution at the moment.

@misev
Copy link
Contributor

misev commented Jul 23, 2024

I realized it may not be obvious how to review the data request @Susannaioni : go to the "Files changed" tab, check the XML (alternatively click Edit on corine_land_cover in the catalog editor), then finally click on the green "Review changes" button to approve or something else.

@misev misev merged commit 01e87d5 into main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants