Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeType.update stac_dist/water_and_wetness_10m/water_and_wetness_10m.json #317

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

fairicube-data
Copy link
Collaborator

{"filename": "water_and_wetness_10m/water_and_wetness_10m.json", "item_type": "stac_dist", "change_type": "Update", "user": "FAiRICUBE", "data_owner": true}

@KathiSchleidt
Copy link
Member

@misev Looks good, but I have an issue with the band definition, currently
"definition": "https://land.copernicus.eu/en/technical-library/hrl-water-wetness-2018-user-manual/@@download/file"

The definition field should provide a link to the ObservableProperty, only problem is that we don't have such an ObservableProperty available at present. I've now created a request for a FAIRiCUBE Codelist for a Water and Wetness Observable Property entry, once Antonio creates this entry the metadata record here should be updated accordingly.

This will probably be relevant for many of the datasets, please check what Observable Properties we need codelist entries for, propose them as required

@misev
Copy link
Contributor

misev commented Jul 26, 2024

Ok this will need to be done essentially for all the new catalog entries I've prepared. I wonder if it can be "batched" into a single metadata resource request?

@misev
Copy link
Contributor

misev commented Jul 26, 2024

Who is supposed to prepare these requests actually? So far I've done them myself and it's been a ton of manual copy-paste work. I had the impression that UC partners were supposed to make these, but the ones I saw (e.g. from WER) were pretty bad quality.

@KathiSchleidt
Copy link
Member

@misev I'd feel most confident if we first agreed on what ObservableProperty codelists we need for the various datasets, create the ObservableProperty codelist entries, then update for all datasets. Described in #318

I'm also wondering if we shouldn't provide more detail in the "category_list" attribute under bands. I'm aware that this field has been poorly defined, mostly missing in existing standards. Would it make sense to create a data structure here to provide both the values and their meanings?

@KathiSchleidt
Copy link
Member

@misev to your question on who is to prepare these lists, the idea was that UC partners provide as much as they can (please remember that our UC partners are NOT EO experts!), get support from the technical partners where they get lost.

Unfortunately, this process broke several times over the last 2 years due to known reasons, the UC partner finally gave up and shifted to EOX. Thus I'd see it as CU responsibility to re-engage the UC partners, then collaboratively collect all required information. Sorry that the alignment between data requests and UC has gone a bit sideways, I believe you're aware of the reasons (that I may not state here)

@misev
Copy link
Contributor

misev commented Jul 26, 2024

@misev I'd feel most confident if we first agreed on what ObservableProperty codelists we need for the various datasets, create the ObservableProperty codelist entries, then update for all datasets. Described in #318

Sounds good, I commented there with a table of pending requests for CU datacubes.

I'm also wondering if we shouldn't provide more detail in the "category_list" attribute under bands. I'm aware that this field has been poorly defined, mostly missing in existing standards. Would it make sense to create a data structure here to provide both the values and their meanings?

That would be good, it's more of a question for the catalog developers though I guess, as it depends on whether it can fit such a structure.

@misev
Copy link
Contributor

misev commented Jul 26, 2024

@misev to your question on who is to prepare these lists, the idea was that UC partners provide as much as they can (please remember that our UC partners are NOT EO experts!), get support from the technical partners where they get lost.

Ok I understand that. The catalog editor interface can definitely be improved to help with this, as it is even for me it was hard to figure out some details let alone non-EO experts. Some short hints/explanations of the fields would be certainly helpful.

@KathiSchleidt
Copy link
Member

@misev on "category_list", I had long discussions with Peter on also providing such categorization from within Coverages but failed badly (all my proposals were pushed back, no alternatives provided). While providing in the STAC metadata works (once we get it to work!), I still think that this information should be included in the rangeType when the DataRecord is of type Category

Happy for any and all feedback on the catalog editor (and any other FAIRiCUBE tools you're using!). As I'm not directly involved in this process, only so much feedback I can provide at an abstract level

Copy link

@sonjastndl sonjastndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot suggest any changes for now.

@misev
Copy link
Contributor

misev commented Aug 28, 2024

@sonjastndl ok you could just click on "Review changes" -> "Approve" (on the Files changed tab)

Copy link

@sonjastndl sonjastndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still figuring out how to, because clicking "Review without explicit approval but comment" led me to this and now I see that my approving review is set.

@misev misev merged commit 7f8cb11 into main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants