Add FiniteElement python wrapper
#3542
Conversation
| """Function space finite element.""" | ||
| return self._cpp_object.element # type: ignore | ||
| return FiniteElement(self._cpp_object.element) |
There was a problem hiding this comment.
This creates a new FiniteElement wrapper each time. Would it be better to wrap the element in the initialiser?
There was a problem hiding this comment.
That would require an additional state variable of the wrapper class FunctionSpace keeping track of the FiniteElement, which contradicts it being a wrapper to provide access only to the cpp_object, as we would then have two finite_element's around to manage.
Also the FiniteElement object itself is only a wrapper, it performs no computations or produces additional states, so it's fine to be created whenever we expose a FiniteElement.
There was a problem hiding this comment.
Perhaps this is naive, but could https://docs.python.org/3/library/functools.html#functools.cached_property be used?
…rapper' into add_finiteelement_wrapper
Together with #3509 fixes #3483.