Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add many geometrical quantities to ffcx expression generator. #725

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

jorgensd
Copy link
Member

Fix various errors in the definition of geometry tables

Fix various errors in the definition of geometry tables
@coveralls
Copy link

coveralls commented Nov 17, 2024

Coverage Status

coverage: 82.122% (+1.0%) from 81.168%
when pulling 8957b93 on dokken/expand-facet-expressions
into 3a6eb07 on main.

@jorgensd
Copy link
Member Author

@michalhabera I've added tests that uses basix. Thus this checks that our expression generator handles the basix data correctly.

@michalhabera
Copy link
Contributor

@michalhabera I've added tests that uses basix. Thus this checks that our expression generator handles the basix data correctly.

I think that your test logic is correct. We basix evaluates these we should not test against numerical values, but against what basix returns.

But can you unify naming there for translated names? E.g. reference_facet_jacobian -> facet_jacobians, so we translate UFL names to basix names. Currently there is additional naming scheme for which I do not see the point and system.

@jorgensd
Copy link
Member Author

@michalhabera I've added tests that uses basix. Thus this checks that our expression generator handles the basix data correctly.

I think that your test logic is correct. We basix evaluates these we should not test against numerical values, but against what basix returns.

But can you unify naming there for translated names? E.g. reference_facet_jacobian -> facet_jacobians, so we translate UFL names to basix names. Currently there is additional naming scheme for which I do not see the point and system.

Done

test/test_jit_expression.py Outdated Show resolved Hide resolved
test/test_jit_expression.py Outdated Show resolved Hide resolved
@jorgensd jorgensd added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 712a57d Nov 22, 2024
14 of 15 checks passed
@jorgensd jorgensd deleted the dokken/expand-facet-expressions branch November 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants