fix? #203
fix? #203
Conversation
| "short" : "A reference from one resource to another", | ||
| "definition" : "A reference from one resource to another.", | ||
| "comment" : "Each occurrence of the zib HealthProfessional is normally represented by _two_ FHIR resources: a PractitionerRole resource (instance of [nl-core-HealthProfessional-PractitionerRole](http://nictiz.nl/fhir/StructureDefinition/nl-core-HealthProfessional-PractitionerRole)) and a Practitioner resource (instance of [nl-core-HealthProfessional-Practitioner](http://nictiz.nl/fhir/StructureDefinition/nl-core-HealthProfessional-Practitioner)). The Practitioner resource is referenced from the PractitionerRole instance. For this reason, sending systems should fill the reference to the PractitionerRole instance here, and not the Practitioner resource. Receiving systems can then retrieve the reference to the Practitioner resource from that PractitionerRole instance.\r\n\r\nIn rare circumstances, there is only a Practitioner instance, in which case it is that instance which will be referenced here. However, since this should be the exception, the nl-core-HealthProfessional-Practitioner profile is not explicitly mentioned as a target profile.", | ||
| "short" : "Requester", |
There was a problem hiding this comment.
.comment now reverts to the base definition from FHIR. This is not the desired behavior, it should be the value from the data type profile used here.
On the other hand, .short, .definition and .alias now use the correct values (they come from the base profile and are not overridden by anything).
| { | ||
| "identity" : "rim", | ||
| "map" : "The target of a resource reference is a RIM entry point (Act, Role, or Entity)" | ||
| "identity" : "zib-nursingintervention-v3.2-2020EN", |
There was a problem hiding this comment.
Adding this mapping is the desired behavior.
| @@ -1422,8 +1420,8 @@ | |||
| "id" : "CarePlan.contributor:requester.extension:contributorIsRequester", | |||
| "path" : "CarePlan.contributor.extension", | |||
| "sliceName" : "contributorIsRequester", | |||
| "short" : "Optional Extensions Element", | |||
| "definition" : "Optional Extension Element - found in all resources.", | |||
| "short" : "Extension", | |||
There was a problem hiding this comment.
The extension is not included in the test case. Should this be added as well?
| @@ -2194,7 +2184,6 @@ | |||
| "code" : "Extension", | |||
| "profile" : ["http://nictiz.nl/fhir/StructureDefinition/ext-CarePlan-MaterialUsed"] | |||
| }], | |||
| "condition" : ["ele-1"], | |||
There was a problem hiding this comment.
Not sure why this condition is removed. Shouldn't it always be present?
| @@ -2318,7 +2300,6 @@ | |||
| }], | |||
| "code" : "http://hl7.org/fhirpath/System.String" | |||
| }], | |||
| "fixedUri" : "http://nictiz.nl/fhir/StructureDefinition/ext-CarePlan-MaterialUsed", | |||
There was a problem hiding this comment.
Not sure if this is due to the fact that the extension is not included in the test case, but I think it should not be removed?
| "comment" : "Each occurrence of the zib HealthProfessional is normally represented by _two_ FHIR resources: a PractitionerRole resource (instance of [nl-core-HealthProfessional-PractitionerRole](http://nictiz.nl/fhir/StructureDefinition/nl-core-HealthProfessional-PractitionerRole)) and a Practitioner resource (instance of [nl-core-HealthProfessional-Practitioner](http://nictiz.nl/fhir/StructureDefinition/nl-core-HealthProfessional-Practitioner)). The Practitioner resource is referenced from the PractitionerRole instance. For this reason, sending systems should fill the reference to the PractitionerRole instance here, and not the Practitioner resource. Receiving systems can then retrieve the reference to the Practitioner resource from that PractitionerRole instance.\r\n\r\nIn rare circumstances, there is only a Practitioner instance, in which case it is that instance which will be referenced here. However, since this should be the exception, the nl-core-HealthProfessional-Practitioner profile is not explicitly mentioned as a target profile.", | ||
| "short" : "HealthcareProvider", | ||
| "definition" : "The health professional carrying out the nursing procedure.", | ||
| "comment" : "A performer MAY also be a participant in the care plan.", |
There was a problem hiding this comment.
Like above:
.comment now reverts to the base definition from FHIR. This is not the desired behavior, it should be the value from the data type profile used here.
On the other hand, .short, .definition and .alias now use the correct values (they come from the base profile and are not overridden by anything).
| @@ -4127,12 +4109,21 @@ | |||
| "isModifier" : false, | |||
| "isSummary" : false, | |||
| "mapping" : [{ | |||
| "identity" : "rim", | |||
| "map" : "n/a" | |||
| "identity" : "zib-nursingintervention-v3.2-2020EN", | |||
There was a problem hiding this comment.
Inheriting this mapping key is the desired behavior.
No description provided.