Fix PHP 7.4 issues

FLUX-SE · Nov 22, 2024 · fee6675 · fee6675
1 parent d0760b6
commit fee6675
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 20 deletions.
diff --git a/spec/Extension/CancelExistingPaymentIntentExtensionSpec.php b/spec/Extension/CancelExistingPaymentIntentExtensionSpec.php
@@ -104,9 +104,9 @@ public function it_doesnt_found_the_related_session_and_do_nothing(
             ->willReturn($allSessionRequest);
 
         $allSessionRequest->setParameters([
-            'payment_intent' => $piId
+            'payment_intent' => $piId,
         ])->shouldBeCalled();
-        $allSessionRequest->getApiResources()->willReturn(Collection::constructFrom(['data'=>[]]));
+        $allSessionRequest->getApiResources()->willReturn(Collection::constructFrom(['data' => []]));
 
         $gateway->execute($allSessionRequest)->shouldBeCalled();
 
@@ -139,15 +139,15 @@ public function it_founds_a_related_expired_session_and_does_nothing(
             ->willReturn($allSessionRequest);
 
         $allSessionRequest->setParameters([
-            'payment_intent' => $piId
+            'payment_intent' => $piId,
         ])->shouldBeCalled();
         $allSessionRequest->getApiResources()->willReturn(Collection::constructFrom([
-            'data'=>[
+            'data' => [
                 [
                     'id' => $csId,
                     'status' => Session::STATUS_EXPIRED,
-                ]
-            ]
+                ],
+            ],
         ]));
 
         $gateway->execute($allSessionRequest)->shouldBeCalled();
@@ -183,15 +183,15 @@ public function it_founds_a_related_session_and_expires_it(
             ->willReturn($allSessionRequest);
 
         $allSessionRequest->setParameters([
-            'payment_intent' => $piId
+            'payment_intent' => $piId,
         ])->shouldBeCalled();
         $allSessionRequest->getApiResources()->willReturn(Collection::constructFrom([
-            'data'=>[
+            'data' => [
                 [
                     'id' => $csId,
                     'status' => Session::STATUS_OPEN,
-                ]
-            ]
+                ],
+            ],
         ]));
 
         $gateway->execute($allSessionRequest)->shouldBeCalled();

diff --git a/spec/StateMachine/CancelOrderProcessorSpec.php b/spec/StateMachine/CancelOrderProcessorSpec.php
@@ -6,20 +6,20 @@
 
 use FluxSE\SyliusPayumStripePlugin\Command\CancelPayment;
 use PhpSpec\ObjectBehavior;
-use SM\Event\TransitionEvent;
 use Sylius\Component\Core\Model\PaymentInterface;
 use Symfony\Component\Messenger\Envelope;
 use Symfony\Component\Messenger\MessageBusInterface;
 
 final class CancelOrderProcessorSpec extends ObjectBehavior
 {
-    public function let(MessageBusInterface $commandBus): void {
+    public function let(MessageBusInterface $commandBus): void
+    {
         $this->beConstructedWith($commandBus);
     }
 
     public function it_is_invokable_when_it_is_new(
         PaymentInterface $payment,
-        MessageBusInterface $commandBus,
+        MessageBusInterface $commandBus
     ): void {
         $payment->getId()->willReturn(1);
 

diff --git a/spec/StateMachine/CaptureAuthorizedOrderProcessorSpec.php b/spec/StateMachine/CaptureAuthorizedOrderProcessorSpec.php
@@ -6,14 +6,14 @@
 
 use FluxSE\SyliusPayumStripePlugin\Command\CaptureAuthorizedPayment;
 use PhpSpec\ObjectBehavior;
-use SM\Event\TransitionEvent;
 use Sylius\Component\Core\Model\PaymentInterface;
 use Symfony\Component\Messenger\Envelope;
 use Symfony\Component\Messenger\MessageBusInterface;
 
 final class CaptureAuthorizedOrderProcessorSpec extends ObjectBehavior
 {
-    public function let(MessageBusInterface $commandBus): void {
+    public function let(MessageBusInterface $commandBus): void
+    {
         $this->beConstructedWith($commandBus);
     }
 

diff --git a/spec/StateMachine/RefundOrderProcessorSpec.php b/spec/StateMachine/RefundOrderProcessorSpec.php
@@ -6,14 +6,14 @@
 
 use FluxSE\SyliusPayumStripePlugin\Command\RefundPayment;
 use PhpSpec\ObjectBehavior;
-use SM\Event\TransitionEvent;
 use Sylius\Component\Core\Model\PaymentInterface;
 use Symfony\Component\Messenger\Envelope;
 use Symfony\Component\Messenger\MessageBusInterface;
 
 final class RefundOrderProcessorSpec extends ObjectBehavior
 {
-    public function let(MessageBusInterface $commandBus): void {
+    public function let(MessageBusInterface $commandBus): void
+    {
         $this->beConstructedWith($commandBus, false);
     }
 
@@ -33,7 +33,6 @@ public function it_do_nothing_when_it_is_disabled(
         PaymentInterface $payment,
         MessageBusInterface $commandBus
     ): void {
-
         $this->beConstructedWith($commandBus, true);
 
         $command = new RefundPayment(1);

diff --git a/tests/Behat/Bug/PantherCookieSetter.php b/tests/Behat/Bug/PantherCookieSetter.php
@@ -10,10 +10,16 @@
 
 final class PantherCookieSetter implements CookieSetterInterface
 {
+    private Session $minkSession;
+
+    private CookieSetterInterface $decoratedCookieSetter;
+
     public function __construct(
-        private Session $minkSession,
-        private CookieSetterInterface $decoratedCookieSetter
+        Session $minkSession,
+        CookieSetterInterface $decoratedCookieSetter
     ) {
+        $this->decoratedCookieSetter = $decoratedCookieSetter;
+        $this->minkSession = $minkSession;
     }
 
     public function setCookie($name, $value): void