Rehaul

[FMotalleb]

rebuilt how command tasks worked
removed duplicate codes
optimized workflow of tasks

Summary by CodeRabbit

• New Features

  • Introduced support for task connections with methods for preparing, connecting, executing, and disconnecting.
  • Added new configuration settings for concurrency, retries, and hooks for task success and failure.
  • Implemented new structs and methods for handling timeouts, retries, and task hooks.

• Enhancements

  • Refactored task execution logic to improve error handling and retry mechanisms.
  • Improved import statement organization for better readability.

• Bug Fixes

  • Updated context handling to support new features and improve reliability.

• Chores

  • Adjusted linter settings to enhance code quality checks.
  • Reorganized and optimized configuration files for better maintainability.

[coderabbitai]

Warning

Review failed

The pull request is closed.

Walkthrough

The recent updates encompass a range of enhancements and new features across various files. Key changes include updates to the .golangci.yml configuration, introduction of new interfaces and structs, improvements to task execution and retry mechanisms, and the addition of new fields in configuration files. These modifications aim to improve code quality, readability, and maintainability while introducing new functionalities for task management and execution.

Changes

Files	Change Summaries
.golangci.yml	Disabled gosec linter and enabled copyloopvar linter.
abstraction/cmd_connection.go	Introduced CmdConnection interface with methods for task preparation, connection, execution, and disconnection.
abstraction/executable.go	Restructured import statements for better organization.
config.doc.yaml	Enabled disabled flag, added concurrency setting, modified retries, and added on-done and on-fail tasks.
config.local.yaml	Added parameters -pt, retries: 5, and retry-delay: 5s to Test Job.
config/compiler/scheduler.go	Added CompileScheduler function to handle job scheduling configurations.
config/compiler/task.go	Added CompileTask function to compile tasks with success and failure hooks.
config/config.go	Updated Task struct with new fields and hooks, added TaskConnection struct.
core/cmd_connection/compiler.go	Introduced CompileConnection function for compiling task connections.
core/cmd_connection/local.go	Added Local struct and methods for local command execution.
core/common/cancalable.go	Introduced Cancelable struct with methods to manage cancellation functions.
core/common/hooked.go	Added Hooked struct and methods for executing hooks on task success or failure.
core/common/http_client.go	Introduced HttpClient struct for HTTP client management.
core/common/retry.go	Added methods for retry management in Retry struct.
core/common/timeout.go	Introduced Timeout struct with methods to apply timeouts to contexts.
core/task/command.go	Refactored Command struct, updated Execute method, and improved retry logic.
core/task/get.go	Refactored Get struct, updated Execute method, and improved retry logic.
core/task/helper.go	Renamed functions and added addFailedConnections function.
core/task/post.go	Refactored Post struct, updated Execute method, and improved retry logic.
ctxutils/keys.go	Added FailedRemotes context key.

Poem

In fields of code, where changes bloom,
A rabbit hops, dispelling gloom.
With linters tweaked and tasks refined,
New hooks and structs, all well-aligned.
Connections made, retries anew,
A seamless flow, a dream come true.
In code we trust, improvements grow,
The rabbit's touch, a gentle glow.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.