fix clang 19 warnings/errors #522
Conversation
controllers/actuators/electronic_throttle_impl.h|13 col 1-20 warning| Included header sensor.h is not used directly (fix available) controllers/actuators/electronic_throttle_impl.h|81 col 2-12 error| Unknown type name 'SensorType' (fix available) controllers/actuators/electronic_throttle_impl.h|94 col 2-7 error| Unknown type name 'Timer' (fix available)
controllers/algo/rusefi_hw_enums.h|23 col 19-27 error| Unknown type name 'uint16_t' (fixes available)
util/efilib.h|105 col 35-39 error| Unknown type name 'Gpio' (fix available) util/efilib.h|110 col 10-14 error| Use of undeclared identifier 'Gpio' (fix available)
init/sensor/init_lambda.cpp|6 col 1-23 warning| Included header live_data.h is not used directly (fix available)
controllers/math/engine_math.cpp|24 col 1-28 warning| Included header event_registry.h is not used directly (fixes available) controllers/math/engine_math.cpp|25 col 1-23 warning| Included header fuel_math.h is not used directly (fixes available)
controllers/algo/fuel_math.cpp|33 col 1-27 warning| Included header speed_density.h is not used directly (fix available)
init/sensor/init_tps.cpp|9 col 1-35 warning| Included header auto_generated_sensor.h is not used directly (fix available)
controllers/engine_cycle/knock_logic.h|15 col 36-48 error| Expected class name (fix available) controllers/engine_cycle/knock_logic.h|35 col 31-36 error| Use of undeclared identifier MS2NT (fix available)
controllers/sensors/impl/software_knock.cpp|98 col 33-50 warning| Result of integer division used in a floating point context; possible loss of precision
controllers/system/thread_controller.h|18 col 33-43 error| Use of undeclared identifier 'chibios_rt' (fix available) controllers/system/thread_controller.h|18 col 45-61 error| Unknown template name 'BaseStaticThread' controllers/system/thread_controller.h|21 col 8-15 error| Unknown type name 'tprio_t' (fix available) controllers/system/thread_controller.h|28 col 14-22 error| Only virtual member functions can be marked 'override' (fix available) controllers/system/thread_controller.h|29 col 9-16 error| No member named 'setName' in 'ThreadController<TStackSize>' controllers/system/thread_controller.h|37 col 37-44 error| Unknown type name 'tprio_t' (fix available) controllers/system/thread_controller.h|51 col 4-14 error| Use of undeclared identifier 'chibios_rt' (fix available) controllers/system/thread_controller.h|51 col 44-46 error| No member named 'start' in the global namespace; did you mean simply 'start'? (fix available)
|
@nmschulte is there/should be there a CI configuration showing these warnings/errors? |
That is an interesting idea, but it would require running https://clangd.llvm.org/guides/include-cleaner seems to be the feature that is telling about these
Worth reiterating: This is opinionated, though that isn't necessarily a bad thing: it's helpful. |
|
@nmschulte does not macos build run clang by default/always? more or less my question is: why change anything, what's the problem statement? |
|
I don't believe MacOS uses clang; I believe it uses Arm's GCC for that platform. I suppose in essence, what this PR is proposing is: https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/WhyIWYU.md I wasn't quite aware of that when I created this PR, but I think it's worth considering. |
|
@nmschulte |
@rusefillc where's that reference from? |
|
@nmschulte google AI could be hallucinating?
|
macos uses clang for unit tests |
Using clangd/clang 19 and Neovim LSP client/server, these changes were warnings (or sometimes errors).