-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Palmetto #28
base: master
Are you sure you want to change the base?
Conversation
…stead of indivisual setting, also implemented actual methods...
…nd implemented it a bit...
…abberPositionButton because it wasnt working, will fix later.
autoSelector.addDefault("Switch Only", Autos.SwitchOnly); | ||
autoSelector.addObject("Scale To Switch", Autos.ScaleToSwitch); | ||
autoSelector.addObject("Two Scale", Autos.TwoScale); | ||
autoSelector.addObject("Do Nothing", Autos.DoNothing); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put a new line here.
|
||
@Override | ||
public void robotInit() { | ||
oi = new OI(); | ||
drivetrain.timer.start(); | ||
sideSelector = new SendableChooser(); | ||
autoSelector = new SendableChooser(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line break here too.
|
||
String gameDataTemp = DriverStation.getInstance().getGameSpecificMessage(); | ||
if (gameDataTemp != null) { | ||
gameData = DriverStation.getInstance().getGameSpecificMessage().substring(0, 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can just do gameDataTemp.substring
. DRY
} else { | ||
//Auto code for right side | ||
switch (gameData) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Own function + test.
Robot.cubeLift.punch(); | ||
} | ||
|
||
protected void execute() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRUNE
Command scoreCubeAgain = new ScoreCmdGrp(); | ||
|
||
public LeftSideCloseScaleCloseSwitchAuto() { | ||
/*addSequential(intakeDown); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BOOOOOOOOOOOOOOO
|
||
public RightSideCloseScaleFarSwitchAuto() { | ||
/* | ||
addSequential(intakeDown); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHAME
private volatile LiftState state = LiftState.Stationary; | ||
|
||
private volatile TalonSRX rightElevatorLeader = new TalonSRX(RobotMap.RIGHT_ELEVATOR_MAIN); | ||
private VictorSPX rightElevatorSlave = new VictorSPX(RobotMap.RIGHT_ELEVATOR_SLAVE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declare stuff as IMotorController
} | ||
checkIfToppedOut(); | ||
checkIfZeroedOut(); | ||
SmartDashboard.putNumber("i counter", i); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
double currentVal = 0; | ||
switch (newPorts) { | ||
case Drivetrain: | ||
currentVal = (pdp.getCurrent(0) + pdp.getCurrent(1) + pdp.getCurrent(2) + pdp.getCurrent(3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the magic numbers?
All changes we made during the 2018 Palmetto regional.