Skip to content

Commit

Permalink
Resolve displayName error in EAP
Browse files Browse the repository at this point in the history
Fixes #459.
  • Loading branch information
FWDekker committed Jun 30, 2023
1 parent f2c4397 commit b19e568
Show file tree
Hide file tree
Showing 5 changed files with 51 additions and 34 deletions.
6 changes: 3 additions & 3 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ fun properties(key: String) = project.findProperty(key).toString()
plugins {
// Compilation
id("java")
id("org.jetbrains.kotlin.jvm") version "1.6.21" // See also `gradle.properties`
id("org.jetbrains.intellij") version "1.10.1"
id("org.jetbrains.kotlin.jvm") version "1.8.22" // See also `gradle.properties`
id("org.jetbrains.intellij") version "1.14.2"

// Tests/coverage
id("jacoco")
Expand All @@ -18,7 +18,7 @@ plugins {
id("io.gitlab.arturbosch.detekt") version "1.20.0" // See also `gradle.properties`

// Documentation
id("org.jetbrains.dokka") version "1.7.20"
id("org.jetbrains.dokka") version "1.8.20"
}


Expand Down
49 changes: 29 additions & 20 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,36 +1,45 @@
group = com.fwdekker
version = 2.7.6
version = 2.7.7

# Compatibility
# * If latest is 20xx.y, then support at least [20xx-1].[y+1].
# e.g., if latest is 2020.3, support at least 2019.4 (aka 2020.1).
# See also https://data.services.jetbrains.com/products?fields=name,releases.version,releases.build&code=IC,CL.
pluginSinceBuild = 221.0
intellijVersion = 2022.1
pluginVerifierIdeVersions = IC-2022.1.1, IC-2022.2.4, IC-2022.3, CL-2022.1.1, CL-2022.2.4, CL-2022.3
pluginSinceBuild = 222.0
intellijVersion = 2022.2
pluginVerifierIdeVersions = IC-2022.2.5, IC-2022.3.3, IC-2023.1.3, CL-2022.2.5, CL-2022.3.3, CL-2023.1.4

# Targets
# * `javaVersion` is the same as `jvmVersion`.
# * Kotlin should also be updated in `plugins` block.
javaVersion = 11
jvmVersion = 11
# * Java
# * `javaVersion` is the same as `jvmVersion`.
# * Java version should be the one used by the oldest Randomness-supported version of IntelliJ, as listed in
# https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html#intellij-platform-based-products-of-recent-ide-versions
#
# * Kotlin
# * `kotlinVersion` is the same as `kotlinApiVersion`.
# * Kotlin should also be updated in `plugins` block.
# * Kotlin version should be bundled stdlib version of oldest supported IntelliJ version listed in
# https://plugins.jetbrains.com/docs/intellij/using-kotlin.html#kotlin-standard-library
javaVersion = 17
jvmVersion = 17
kotlinVersion = 1.6
kotlinApiVersion = 1.6

# Dependencies
# * Detekt should also be updated in `plugins` block.
# * Check https://github.com/assertj/assertj-swing/releases for valid AssertJ version combinations.
assertjVersion = 3.17.2
assertjSwingVersion = 3.17.1
detektVersion = 1.20.0
emojiVersion = 5.1.1
jacocoVersion = 0.8.8
junitVersion = 5.9.1
junitRunnerVersion = 1.9.1
mockitoKotlinVersion = 4.1.0
spekVersion = 2.0.19
uuidGeneratorVersion = 3.3.0
assertjVersion = 3.17.2
assertjSwingVersion = 3.17.1
detektVersion = 1.20.0
emojiVersion = 5.1.1
jacocoVersion = 0.8.8
junitVersion = 5.9.1
junitRunnerVersion = 1.9.1
mockitoKotlinVersion = 4.1.0
spekVersion = 2.0.19
uuidGeneratorVersion = 3.3.0

# Kotlin
kotlin.code.style = official
kotlin.stdlib.default.dependency = false
kotlin.code.style = official
kotlin.incremental.useClasspathSnapshot = false
kotlin.stdlib.default.dependency = false
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ abstract class SettingsConfigurable<S : Settings<S, T>, T : Scheme<T>> : Configu
val validationInfo = component.doValidate()
if (validationInfo != null)
throw ConfigurationException(validationInfo.message, "Failed to save settings")
.also { it.quickFix = validationInfo.quickFix }
.also { it.setQuickFix(validationInfo.quickFix) }

component.saveSettings()
}
Expand Down
4 changes: 3 additions & 1 deletion src/main/resources/META-INF/change-notes.html
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
<b>Breaking changes</b>
<p>
Minimum IDE version has been increased to 2022.1.
Minimum IDE version has been increased to 2022.2.
</p>
<br />
<b>Fixes</b>
<p>
Resolve compatibility issues with upcoming IDE versions.
(<a href="https://github.com/FWDekker/intellij-randomness/issues/459">#459</a>)
(<a href="https://github.com/FWDekker/intellij-randomness/issues/460">#460</a>)
</p>
<br />
Change notes of previous updates can be found on the
Expand Down
24 changes: 15 additions & 9 deletions src/main/resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<idea-version since-build="0.0" /> <!-- Patched in from `gradle.properties` -->

<extensions defaultExtensionNs="com.intellij">
<errorHandler implementation="com.fwdekker.randomness.ErrorReporter"/>
<errorHandler implementation="com.fwdekker.randomness.ErrorReporter" />

<!-- Persistence -->
<applicationService serviceImplementation="com.fwdekker.randomness.integer.IntegerSettings" />
Expand All @@ -22,26 +22,32 @@
<!-- Settings window -->
<applicationConfigurable instance="com.fwdekker.randomness.RandomnessConfigurable"
id="randomness.MainConfigurable"
groupId="tools"
bundle="randomness">
parentId="tools"
displayName="Randomness">
<configurable instance="com.fwdekker.randomness.integer.IntegerSettingsConfigurable"
id="randomness.IntegerSettingsConfigurable"
parentId="randomness.MainConfigurable" />
parentId="randomness.MainConfigurable"
displayName="Integers" />
<configurable instance="com.fwdekker.randomness.decimal.DecimalSettingsConfigurable"
id="randomness.DecimalSettingsConfigurable"
parentId="randomness.MainConfigurable" />
parentId="randomness.MainConfigurable"
displayName="Decimals" />
<configurable instance="com.fwdekker.randomness.string.StringSettingsConfigurable"
id="randomness.StringSettingsConfigurable"
parentId="randomness.MainConfigurable" />
parentId="randomness.MainConfigurable"
displayName="Strings" />
<configurable instance="com.fwdekker.randomness.word.WordSettingsConfigurable"
id="randomness.WordSettingsConfigurable"
parentId="randomness.MainConfigurable" />
parentId="randomness.MainConfigurable"
displayName="Words" />
<configurable instance="com.fwdekker.randomness.uuid.UuidSettingsConfigurable"
id="randomness.UuidSettingsConfigurable"
parentId="randomness.MainConfigurable" />
parentId="randomness.MainConfigurable"
displayName="UUIDs" />
<configurable instance="com.fwdekker.randomness.array.ArraySettingsConfigurable"
id="randomness.ArraySettingsConfigurable"
parentId="randomness.MainConfigurable" />
parentId="randomness.MainConfigurable"
displayName="Arrays" />
</applicationConfigurable>
</extensions>

Expand Down

0 comments on commit b19e568

Please sign in to comment.