Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Add optional registries & refactor registry sync #4233

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

modmuss50
Copy link
Member

@modmuss50 modmuss50 commented Nov 15, 2024

  • General code cleanup, a lot of stuff can now be made client only as we no longer persist ids.
    • There is scope to move even more (such as the registry remapping code) to the client, but ill leave this for later.
  • Add some more unit tests :)
  • Add optional registries

Optional registries / stricter defaults

The goal of these changes is to document the expected behaviour of missing registry's when a client connects to a modded server. This behaviour is now consistent between a vanilla clients and modded clients. This has nothing to do with individual registry entries (yet).

Some mods have their own registries that only need to be synced when the connecting client has their mod, I have added a new OPTIONAL registry attribute that allows this. This attribute is sent in the registry sync packet.

The behaviour of a connecting client is as follows:

Screenshot 2024-11-15 at 20 25 17

These changes will only apply to 1.21.4 as they are breaking.

TODO

  • Test with real clients and servers
  • Better error message when a registry is missing, I just reused the entries one for now?

@modmuss50 modmuss50 added in progress This issue has PR(s) open to resolve it (or a PR that is WIP) registry-sync Pull requests and issues related to registry sync labels Nov 15, 2024
@modmuss50 modmuss50 marked this pull request as ready for review November 26, 2024 09:33
@modmuss50 modmuss50 added priority:high High priority PRs that need review and work now. Review these first. and removed in progress This issue has PR(s) open to resolve it (or a PR that is WIP) labels Nov 26, 2024
@modmuss50 modmuss50 added the last call If you care, make yourself heard right away! label Nov 26, 2024
@modmuss50 modmuss50 changed the title [1.21.4] Refactor registry sync [1.21.4] Add optional registries & refactor registry sync Nov 26, 2024
@modmuss50 modmuss50 merged commit cc0fa2f into FabricMC:1.21.4 Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last call If you care, make yourself heard right away! priority:high High priority PRs that need review and work now. Review these first. registry-sync Pull requests and issues related to registry sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants