-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization Support For Crosshair Setup #2148
Open
IBRS-4Ever
wants to merge
2
commits into
Facepunch:master
Choose a base branch
from
IBRS-4Ever:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
IBRS-4Ever
commented
Nov 8, 2024
robotboy655
requested changes
Nov 8, 2024
Comment on lines
473
to
488
Option_Crosshair.Title=Default Crosshair Setup | ||
Option_Crosshair.Style_HL2=Half-Life 2 | ||
Option_Crosshair.Style_Dot=Dot Image | ||
Option_Crosshair.Style_Classic=Classic | ||
Option_Crosshair.Gap=Gap | ||
Option_Crosshair.Size=Size | ||
Option_Crosshair.Thickness=Thickness | ||
Option_Crosshair.Dot=Dot | ||
Option_Crosshair.T_Style=T-Style | ||
Option_Crosshair.Alpha=Use Alpha | ||
Option_Crosshair.Quick_Info=Quick Info | ||
Option_Crosshair.Outline=Outline | ||
Option_Crosshair.Outline_Thickness=Outline Thickness | ||
Option_Crosshair.Preview_1=Preview 1 | ||
Option_Crosshair.Preview_2=Preview 2 | ||
Option_Crosshair.Reset_Crosshair=Reset Crosshair |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The localization strings (Option_Crosshair.Reset_Crosshair
and others) must be all lowercase to match the rest of the localization strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
robotboy655
added
the
Enhancement
The pull request enhances current functionality.
label
Nov 8, 2024
robotboy655
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.